Skip to contentSkip to conversation

leds: Adjust documentation of brightness sysfs node

PATCH Superseded Andy Shevchenko 2 participants 5 messages Mar 20 – May 20

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 leds: Adjust documentation of brightness sysfs node

Adjust documentation of brightness sysfs node about accepted value range. The code accepts only decimal values. We may not relax that due to different readings for, e.g., octal 0100, which becomes 64 instead of currently parsed 100.

---

v2: rephrased the sentence to make it clearer (Lee)

 Documentation/ABI/testing/sysfs-class-led | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/ABI/testing/sysfs-class-led +2 -2
index 0313b82644f2..d4c918cc11a1 100644
@@ -22,8 +22,8 @@ Description:
 		  For additional details please refer to
 		  Documentation/leds/leds-class-multicolor.rst.
 
-		The value is between 0 and
-		/sys/class/leds/<led>/max_brightness.
+		The value is between 0 and /sys/class/leds/<led>/max_brightness
+		and is represented by as a decimal.
 
 		Writing 0 to this file clears active trigger.
 
Signature · 1 line
2.50.1
#1 lore raw
Quoted 4 lines · Andy Shevchenko

Adjust documentation of brightness sysfs node about accepted value range. The code accepts only decimal values. We may not relax that due to different readings for, e.g., octal 0100, which becomes 64 instead of currently parsed 100.

Lee, Can we have this being applied? Perhaps even for this (v7.1) cycle.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 7 lines · Andy Shevchenko
Quoted 4 lines · Andy Shevchenko

Adjust documentation of brightness sysfs node about accepted value range. The code accepts only decimal values. We may not relax that due to different readings for, e.g., octal 0100, which becomes 64 instead of currently parsed 100.

Lee, Can we have this being applied? Perhaps even for this (v7.1) cycle.

This is not in my inbox. Please [RESEND].

Signature · 1 line
Lee Jones
#3 lore raw
Quoted 10 lines · Lee Jones
Quoted 7 lines · Andy Shevchenko
Quoted 4 lines · Andy Shevchenko

Adjust documentation of brightness sysfs node about accepted value range. The code accepts only decimal values. We may not relax that due to different readings for, e.g., octal 0100, which becomes 64 instead of currently parsed 100.

Lee, Can we have this being applied? Perhaps even for this (v7.1) cycle.

This is not in my inbox. Please [RESEND].

Done as [email protected].

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Lee Jones
Quoted 6 lines · Andy Shevchenko
Quoted 4 lines · Andy Shevchenko

Adjust documentation of brightness sysfs node about accepted value range. The code accepts only decimal values. We may not relax that due to different readings for, e.g., octal 0100, which becomes 64 instead of currently parsed 100.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Lee, Can we have this being applied? Perhaps even for this (v7.1) cycle.

This is not in my inbox. Please [RESEND].

Done as [email protected].

Still didn't end up in my inbox, oddly!

Applied with external tooling.

Signature · 1 line
Lee Jones