Skip to contentSkip to conversation

shadow-native: Change upstream status of disable_syslog.patch

PATCH In review [email protected] 2 participants 2 messages May 7 – May 12

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 shadow-native: Change upstream status of disable_syslog.patch

From: Dmitry Sakhonchik <[email protected]>

Upstream has accepted configure option and merged it into their master branch.

https://github.com/shadow-maint/shadow/pull/1618

After they release v4.20 we can remove the patch and rewrite recipe with the configure option.

Fixes [YOCTO #15785]

---
 meta/recipes-extended/shadow/files/disable_syslog.patch | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-extended/shadow/files/disable_syslog.patch +2 -1
index 7299a8e61c..9f8ffcd379 100644
@@ -2,8 +2,9 @@ When building images using shadow-native, we shouldn't be spamming the host's
 log with lots of syslog messages which aren't relavent. Disable syslog use
 in the native case.
 
-Upstream-Status: Inappropriate [Would upstream accept a configure option?]
+Upstream-Status: Inappropriate [upstream has accepted a better patch at https://github.com/shadow-maint/shadow/pull/1618]
 Signed-off-by: Richard Purdie <[email protected]>
+Signed-off-by: Dmitry Sakhonchik <[email protected]>
 
 Index: shadow-4.17.2/lib/defines.h
 ===================================================================
#1 lore raw
Quoted 26 lines · Dmitry Sakhonchik via lists.openembedded.org

From: Dmitry Sakhonchik <[email protected]>

Upstream has accepted configure option and merged it into their master branch.

https://github.com/shadow-maint/shadow/pull/1618

After they release v4.20 we can remove the patch and rewrite recipe with the configure option.

Fixes [YOCTO #15785]

---
 meta/recipes-extended/shadow/files/disable_syslog.patch | 3 ++-

 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-extended/shadow/files/disable_syslog.patch +0 -0
index 7299a8e61c..9f8ffcd379 100644
@@ -2,8 +2,9 @@ When building images using shadow-native, we shouldn't be spamming the host's

 log with lots of syslog messages which aren't relavent. Disable syslog use in the native case.

meta/recipes-extended/shadow/files/disable_syslog.patch +1 -1
-Upstream-Status: Inappropriate [Would upstream accept a configure option?]
+Upstream-Status: Inappropriate [upstream has accepted a better patch at https://github.com/shadow-maint/shadow/pull/1618]
Quoted 1 line

+Signed-off-by: Dmitry Sakhonchik <[email protected]>

Thanks for doing this, it is really great to see it fixed properly upstream in a way meaning we can drop patches in due course!

Cheers,

Richard