input: misc: add support for Imagis ISA1200 haptic motor driver
Subsystems (3)
v4 cover input: misc: add support for Imagis ISA1200 haptic motor driver
The ISA1200 is a haptic feedback unit from Imagis Technology using two motors for haptic feedback in mobile phones. Used in many mobile devices c. 2012 including Samsung Galxy S Advance GT-I9070 (Janice), Samsung Beam GT-I8350 (Gavini), LG Optimus 4X P880 and LG Optimus Vu P895.
The exact datasheet for the ISA1200 is not available; all data was modeled based on available downstream kernel sources for various devices and fragments of information scattered across the internet.
---
Changes in v4:
- added INPUT_FF_MEMLESS option selection
- fixed missing clock status set
- guard start/stop calls in isa1200_play_work with lock
- clamp ldo voltages to allowed range
- fixed imagis,pll-div parsing
- dropped Tested-by from schema adding commit
Changes in v3:
- added clock state tracking
- dropped level check in vibrator close
- added clkdiv clamping
- added comments regarding registers 5 and 6
Changes in v2:
- imagis,clk-div switched to accept actual divider value
- dropped DT header
- adjusted imagis,period-ns range
- initiated hctrl0 and hctrl1 values in isa1200_start
- fixed situation when PWM might return -EPROBE_DEFER to be treated properly
- added chech a clock or PWM is available
- fixed regulator voltages check being off by 10
- added chech if state.period is not zero
- added action call to disable clock and gpios on error
- used managed version of work init
- added work cancel on suspend
- PW calls are done under mutex lock
---
Linus Walleij (1):
Input: isa1200 - new driver for Imagis ISA1200
Svyatoslav Ryhel (1):
dt-bindings: input: Document Imagis ISA1200 haptic motor driver
.../bindings/input/imagis,isa1200.yaml | 140 +++++ drivers/input/misc/Kconfig | 12 + drivers/input/misc/Makefile | 1 + drivers/input/misc/isa1200.c | 540 ++++++++++++++++++ 4 files changed, 693 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/imagis,isa1200.yaml create mode 100644 drivers/input/misc/isa1200.c
Signature · 1 line
2.51.0
PATCH v4 1/2 dt-bindings: input: Document Imagis ISA1200 haptic motor driver
Document the Imagis ISA1200 haptic motor driver, used primarily in mobile handheld devices and capable of supporting up to two motors.
The exact datasheet for the ISA1200 is not available; all data was modeled based on available downstream kernel sources for various devices and fragments of information scattered across the internet.
--- .../bindings/input/imagis,isa1200.yaml | 140 ++++++++++++++++++ 1 file changed, 140 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/imagis,isa1200.yaml
Documentation/devicetree/bindings/input/imagis,isa1200.yaml new file +140 -0
@@ -0,0 +1,140 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/imagis,isa1200.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Imagis ISA1200 haptic motor driver + +maintainers: + - Svyatoslav Ryhel <[email protected]> + - Linus Walleij <[email protected]> + +description: + The ISA1200 is a high-performance enhanced haptic motor driver designed + for mobile hand-held devices. It supports various voltages for both ERM + (Eccentric Rotating Mass) and LRA (Linear Resonant Actuator) type + actuators. Thanks to an embedded LDO, battery power can be used directly + in handheld applications. + +properties: + compatible: + const: imagis,isa1200 + + reg: + maxItems: 1 + + control-gpios: + description: + One or two GPIOs flagged as active high linked to HEN and LEN pins + maxItems: 2 + + clocks: + maxItems: 1 + + pwms: + maxItems: 1 + + vdd-supply: + description: + Regulator for 2.4V - 5.5V power supply + + vddp-supply: + description: + Regulator for 2.4V - 3.6V IO power supply + + imagis,clk-div: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Divider for the external input clock/PWM + enum: [128, 256, 512, 1024] + default: 128 + + imagis,pll-div: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Divider for the internal PLL clock + minimum: 1 + maximum: 15 + default: 1 + + imagis,mode: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Defines the motor type isa1200 drives + 0 - LRA (Linear Resonant Actuator) + 1 - ERM (Eccentric Rotating Mass) + enum: [0, 1] + default: 0 + + imagis,period-ns: + description: + Period of the internal PWM channel in nanoseconds. + minimum: 10000 + maximum: 30000 + + imagis,duty-cycle-ns: + description: + Duty cycle of the external/internal PWM channel in nanoseconds, + defaults to 50% of the channel's period + + ldo: + $ref: /schemas/regulator/regulator.yaml# + type: object + description: + Embedded LDO regulator with voltage range 2.3V - 3.8V + unevaluatedProperties: false + + required: + - regulator-min-microvolt + - regulator-max-microvolt + +required: + - compatible + - reg + - ldo + +anyOf: + - required: + - clocks + - imagis,period-ns + - required: + - pwms + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + haptic-engine@49 { + compatible = "imagis,isa1200"; + reg = <0x49>; + + clocks = <&isa1200_refclk>; + + control-gpios = <&gpio 22 GPIO_ACTIVE_HIGH>, + <&gpio 23 GPIO_ACTIVE_HIGH>; + + vdd-supply = <&vdd_3v3_vbat>; + vddp-supply = <&vdd_2v8_vvib>; + + imagis,clk-div = <256>; + imagis,pll-div = <2>; + + imagis,mode = <0>; /* LRA_MODE */ + + imagis,period-ns = <13400>; + imagis,duty-cycle-ns = <100>; + + ldo { + regulator-name = "vdd_vib"; + regulator-min-microvolt = <2300000>; + regulator-max-microvolt = <2300000>; + }; + }; + };
Signature · 1 line
2.51.0
PATCH v4 2/2 Input: isa1200 - new driver for Imagis ISA1200
In reply to Svyatoslav RyhelFrom: Linus Walleij <[email protected]>
The ISA1200 is a haptic feedback unit from Imagis Technology using two motors for haptic feedback in mobile phones. Used in many mobile devices c. 2012 including Samsung Galxy S Advance GT-I9070 (Janice), Samsung Beam GT-I8350 (Gavini), LG Optimus 4X P880 and LG Optimus Vu P895.
The exact datasheet for the ISA1200 is not available; all data was modeled based on available downstream kernel sources for various devices and fragments of information scattered across the internet.
--- drivers/input/misc/Kconfig | 12 + drivers/input/misc/Makefile | 1 + drivers/input/misc/isa1200.c | 540 +++++++++++++++++++++++++++++++++++ 3 files changed, 553 insertions(+) create mode 100644 drivers/input/misc/isa1200.c
drivers/input/misc/Kconfig +12 -0
@@ -852,6 +852,18 @@ config INPUT_IQS7222 To compile this driver as a module, choose M here: the module will be called iqs7222. +config INPUT_ISA1200_HAPTIC + tristate "Imagis ISA1200 haptic feedback unit" + depends on I2C + select INPUT_FF_MEMLESS + select REGMAP_I2C + help + Say Y to enable support for the Imagis ISA1200 haptic + feedback unit. + + To compile this driver as a module, choose M here: the + module will be called isa1200. + config INPUT_CMA3000 tristate "VTI CMA3000 Tri-axis accelerometer" help
drivers/input/misc/Makefile +1 -0
@@ -49,6 +49,7 @@ obj-$(CONFIG_INPUT_IMS_PCU) += ims-pcu.o obj-$(CONFIG_INPUT_IQS269A) += iqs269a.o obj-$(CONFIG_INPUT_IQS626A) += iqs626a.o obj-$(CONFIG_INPUT_IQS7222) += iqs7222.o +obj-$(CONFIG_INPUT_ISA1200_HAPTIC) += isa1200.o obj-$(CONFIG_INPUT_KEYSPAN_REMOTE) += keyspan_remote.o obj-$(CONFIG_INPUT_KXTJ9) += kxtj9.o obj-$(CONFIG_INPUT_M68K_BEEP) += m68kspkr.o
drivers/input/misc/isa1200.c new file +540 -0
540 lines not on this page · raw message
Signature · 1 line
2.51.0
Dmitry Torokhov
maintainerRe: [PATCH v4 2/2] Input: isa1200 - new driver for Imagis ISA1200
Hi Svyatoslav,
Quoted 124 lines · Svyatoslav Ryhel
From: Linus Walleij <[email protected]>
The ISA1200 is a haptic feedback unit from Imagis Technology using two motors for haptic feedback in mobile phones. Used in many mobile devices c. 2012 including Samsung Galxy S Advance GT-I9070 (Janice), Samsung Beam GT-I8350 (Gavini), LG Optimus 4X P880 and LG Optimus Vu P895.
The exact datasheet for the ISA1200 is not available; all data was modeled based on available downstream kernel sources for various devices and fragments of information scattered across the internet.
Signed-off-by Linus Walleij <[email protected]>Co-developed-by Svyatoslav Ryhel <[email protected]>Signed-off-by Svyatoslav Ryhel <[email protected]>--- drivers/input/misc/Kconfig | 12 + drivers/input/misc/Makefile | 1 + drivers/input/misc/isa1200.c | 540 +++++++++++++++++++++++++++++++++++ 3 files changed, 553 insertions(+) create mode 100644 drivers/input/misc/isa1200.cdrivers/input/misc/Kconfig +12
-0@@ -852,6 +852,18 @@ config INPUT_IQS7222 To compile this driver as a module, choose M here: the module will be called iqs7222. +config INPUT_ISA1200_HAPTIC + tristate "Imagis ISA1200 haptic feedback unit" + depends on I2C + select INPUT_FF_MEMLESS + select REGMAP_I2C + help + Say Y to enable support for the Imagis ISA1200 haptic + feedback unit. + + To compile this driver as a module, choose M here: the + module will be called isa1200. + config INPUT_CMA3000 tristate "VTI CMA3000 Tri-axis accelerometer" helpdrivers/input/misc/Makefile +1
-0@@ -49,6 +49,7 @@ obj-$(CONFIG_INPUT_IMS_PCU) += ims-pcu.o obj-$(CONFIG_INPUT_IQS269A) += iqs269a.o obj-$(CONFIG_INPUT_IQS626A) += iqs626a.o obj-$(CONFIG_INPUT_IQS7222) += iqs7222.o +obj-$(CONFIG_INPUT_ISA1200_HAPTIC) += isa1200.o obj-$(CONFIG_INPUT_KEYSPAN_REMOTE) += keyspan_remote.o obj-$(CONFIG_INPUT_KXTJ9) += kxtj9.o obj-$(CONFIG_INPUT_M68K_BEEP) += m68kspkr.odrivers/input/misc/isa1200.c new file +61
-0@@ -0,0 +1,540 @@ +// SPDX-License-Identifier: GPL-2.0+ + +#include <linux/array_size.h> +#include <linux/bitmap.h> +#include <linux/bits.h> +#include <linux/clk.h> +#include <linux/delay.h> +#include <linux/device.h> +#include <linux/devm-helpers.h> +#include <linux/err.h> +#include <linux/gpio/consumer.h> +#include <linux/i2c.h> +#include <linux/input.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/property.h> +#include <linux/pwm.h> +#include <linux/regmap.h> +#include <linux/regulator/consumer.h> +#include <linux/units.h> + +/* +* System control (LDO regulator) +* +* LDO voltage to register mapping is linear, but it is split in two parts: +* 2.3V - 3.0V map to 0x08 - 0x0f; 3.1V - 3.8V map to 0x00 - 0x7 +*/ + +#define ISA1200_SCTRL 0x00 +#define ISA1200_LDO_VOLTAGE_BASE 0x08 +#define ISA1200_LDO_VOLTAGE_STEP 100000 +#define ISA1200_LDO_VOLTAGE_2V3 23 +#define ISA1200_LDO_VOLTAGE_3V1 31 +#define ISA1200_LDO_VOLTAGE_MIN 2300000 +#define ISA1200_LDO_VOLTAGE_MAX 3800000 + +/* +* The output frequency is calculated with this formula: +* +* base clock frequency +* fout = ----------------------------------------- +* (128 - PWM_FREQ) * 2 * PLLDIV * PWM_PERIOD +* +* The base clock frequency is the clock frequency provided on the +* clock input to the chip, divided by the value in HCTRL0 +* +* PWM_FREQ is configured in register HCTRL4, it is common to set this +* to 0 to get only two variables to calculate. +* +* PLLDIV is configured in register HCTRL3 (bits 7..4, so 0..15) +* PWM_PERIOD is configured in register HCTRL6 +* Further the duty cycle can be configured in HCTRL5 +*/ + +/* +* HCTRL0 configures clock or PWM input and selects the divider for +* the clock input. +*/ +#define ISA1200_HCTRL0 0x30 +#define ISA1200_HCTRL0_HAP_ENABLE BIT(7) +#define ISA1200_HCTRL0_PWM_GEN_MODE BIT(4)
drivers/input/misc/isa1200.c line 71
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+#define ISA1200_HCTRL0_PWM_INPUT_MODE BIT(3) +#define ISA1200_HCTRL0_CLKDIV_128 128 + +/* +* HCTRL1 configures the motor type and clock sourse +*/ +#define ISA1200_HCTRL1 0x31 +#define ISA1200_HCTRL1_EXT_CLOCK BIT(7) +#define ISA1200_HCTRL1_DAC_INVERT BIT(6) +#define ISA1200_HCTRL1_MODE (n) (((n) & 1) << 5)
I wonder if this should simply be BIT(5) and you conditionally use it in the code. The macro is not really usable to disable the setting...
Quoted 49 lines
drivers/input/misc/isa1200.c new file +49
-0+ +/* HCTRL2 controls software reset of the chip */ +#define ISA1200_HCTRL2 0x32 +#define ISA1200_HCTRL2_SW_RESET BIT(0) + +/* +* HCTRL3 controls the PLL divisor +* +* Bits [0,1] are always set to 1 (we don't know what they are +* used for) and bit 4 and upward control the PLL divisor. +*/ +#define ISA1200_HCTRL3 0x33 +#define ISA1200_HCTRL3_DEFAULT 0x03 +#define ISA1200_HCTRL3_PLLDIV (n) (((n) & 0xf) << 4) + +/* HCTRL4 controls the PWM frequency of external channel */ +#define ISA1200_HCTRL4 0x34 + +/* HCTRL5 controls the PWM high duty cycle of internal channel */ +#define ISA1200_HCTRL5 0x35 + +/* HCTRL6 controls the PWM period of internal channel */ +#define ISA1200_HCTRL6 0x36 +#define ISA1200_HCTRL6_PERIOD_SCALE 100 + +/* The use for these registers is unknown but they exist */ +#define ISA1200_HCTRL7 0x37 +#define ISA1200_HCTRL8 0x38 +#define ISA1200_HCTRL9 0x39 +#define ISA1200_HCTRLA 0x3a +#define ISA1200_HCTRLB 0x3b +#define ISA1200_HCTRLC 0x3c +#define ISA1200_HCTRLD 0x3d + +#define ISA1200_EN_PINS_MAX 2 + +struct isa1200_config { +u32 ldo_voltage; +u32 mode; +u32 clkdiv; +u32 plldiv; +u32 freq; +u32 period; +u32 duty; +}; + +struct isa1200 { +struct input_dev *input; +struct regmap *map;
drivers/input/misc/isa1200.c line 130
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+ +struct clk *clk; +struct pwm_device *pwm; +struct gpio_descs *enable_gpios; + +struct work_struct play_work; +struct isa1200_config config; + +int level; +bool clk_on;
I think you need not only clk_on, but general "active" flag that you would set at the end of isa1200_start().
Quoted 5 lines
drivers/input/misc/isa1200.c new file +5
-0+}; + +static const struct regmap_config isa1200_regmap_config = { + .reg_bits =8 , + .val_bits =8 ,
drivers/input/misc/isa1200.c line 145
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+ .max_register = ISA1200_HCTRLD, +}; + +static void isa1200_start (struct isa1200 *isa) +{ +struct isa1200_config *config = &isa->config; +struct pwm_state state; +u8 hctrl0 =0 , hctrl1 =0 ; +DECLARE_BITMAP (values,ISA1200_EN_PINS_MAX ); +int ret;
Please use "error" or "err" for all variables that only hold error codes (or 0) instead of a real value that is used for something.
drivers/input/misc/isa1200.c line 148
Quoted 3 lines
drivers/input/misc/isa1200.c new file +3
-0+ +if (!isa->clk_on) { + ret =clk_prepare_enable (isa->clk);
This return 0 on success so
if (error) return;
Quoted 85 lines
drivers/input/misc/isa1200.c new file +85
-0+if (ret <0 ) +return ; + + isa->clk_on = true; + } + +bitmap_fill (values,ISA1200_EN_PINS_MAX ); +gpiod_multi_set_value_cansleep (isa->enable_gpios, values); + +usleep_range (200 ,300 ); + +regmap_write (isa->map,ISA1200_SCTRL , config->ldo_voltage); + +if (isa->clk) { + hctrl0 =ISA1200_HCTRL0_PWM_GEN_MODE ; + hctrl1 =ISA1200_HCTRL1_EXT_CLOCK ; + } + +if (isa->pwm) { + hctrl0 =ISA1200_HCTRL0_PWM_INPUT_MODE ; + hctrl1 =0 ; + } + + hctrl0 |=__ffs (config->clkdiv /ISA1200_HCTRL0_CLKDIV_128 ); + hctrl1 |=ISA1200_HCTRL1_DAC_INVERT ; + hctrl1 |=ISA1200_HCTRL1_MODE (config->mode); + +regmap_write (isa->map,ISA1200_HCTRL0 , hctrl0); +regmap_write (isa->map,ISA1200_HCTRL1 , hctrl1); + +/* Make sure to de-assert software reset */ +regmap_write (isa->map,ISA1200_HCTRL2 ,0x00 ); + +/* PLL divisor */ +regmap_write (isa->map,ISA1200_HCTRL3 , +ISA1200_HCTRL3_PLLDIV (config->plldiv) | +ISA1200_HCTRL3_DEFAULT ); + +/* Frequency */ +regmap_write (isa->map,ISA1200_HCTRL4 , config->freq); +/* Duty cycle */ +regmap_write (isa->map,ISA1200_HCTRL5 , config->period >>1 ); +/* Period */ +regmap_write (isa->map,ISA1200_HCTRL6 , config->period); + + hctrl0 |=ISA1200_HCTRL0_HAP_ENABLE ; +regmap_write (isa->map,ISA1200_HCTRL0 , hctrl0); + +if (isa->clk) +regmap_write (isa->map,ISA1200_HCTRL5 , config->duty); + +if (isa->pwm) { +pwm_get_state (isa->pwm, &state); + state.duty_cycle = config->duty; + state.enabled = true; +pwm_apply_might_sleep (isa->pwm, &state); + } +} + +static void isa1200_power_off (void *data) +{ +struct isa1200 *isa = data; + +DECLARE_BITMAP (values,ISA1200_EN_PINS_MAX ); + +bitmap_zero (values,ISA1200_EN_PINS_MAX ); +gpiod_multi_set_value_cansleep (isa->enable_gpios, values); + +if (isa->clk_on) { +clk_disable_unprepare (isa->clk); + isa->clk_on = false; + } +} + +static void isa1200_stop (struct isa1200 *isa) +{ +struct pwm_state state; + +if (isa->pwm) { +pwm_get_state (isa->pwm, &state); + state.duty_cycle =0 ; + state.enabled = false; +pwm_apply_might_sleep (isa->pwm, &state); + } +
drivers/input/misc/isa1200.c line 243
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+regmap_write (isa->map,ISA1200_HCTRL0 ,0x00 ); +isa1200_power_off (isa); +} + +static void isa1200_play_work (struct work_struct *work) +{ +struct isa1200 *isa = + container_of(work, struct isa1200, play_work); + +guard (mutex)(&isa->input->mutex);
I think this mutex is dangerous here. You really want to stop/cancel work in suspend() and close() instead of blocking on the mutex and then continuing.
Quoted 30 lines
drivers/input/misc/isa1200.c new file +30
-0+ +if (isa->level) +isa1200_start (isa); +else +isa1200_stop (isa); +} + +static int isa1200_vibrator_play_effect (struct input_dev *input,void *data, +struct ff_effect *effect) +{ +struct isa1200 *isa =input_get_drvdata (input); +int level; + +/* +* TODO: we currently only support rumble. +* The ISA1200 can control two motors and some devices +* also have two motors mounted. +*/ + level = effect->u.rumble.strong_magnitude; +if (!level) + level = effect->u.rumble.weak_magnitude; + +dev_dbg (&input->dev,"FF effect type %d level %d\n" , + effect->type, level); + +if (isa->level != level) { + isa->level = level; +schedule_work (&isa->play_work); + } +
drivers/input/misc/isa1200.c line 283
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+return 0 ; +} + +static void isa1200_vibrator_close (struct input_dev *input) +{ +struct isa1200 *isa =input_get_drvdata (input); + +cancel_work_sync (&isa->play_work); + +if (isa->level)
So here I think you need to check that "active" flag that would represent the committed state.
Quoted 159 lines
drivers/input/misc/isa1200.c new file +159
-0+isa1200_stop (isa); + + isa->level =0 ; +} + +static int isa1200_of_probe (struct i2c_client *client) +{ +static const char *const isa1200_supplies[] = {"vdd" ,"vddp" }; +struct isa1200 *isa =i2c_get_clientdata (client); +struct isa1200_config *config = &isa->config; +struct device *dev = &client->dev; +struct fwnode_handle *ldo_node; +int ret; + + isa->clk =devm_clk_get_optional (dev,NULL ); +if (IS_ERR (isa->clk)) +return dev_err_probe (dev,PTR_ERR (isa->clk), +"failed to get clock\n" ); + + isa->pwm =devm_pwm_get (dev,NULL ); +if (IS_ERR (isa->pwm)) { + ret =PTR_ERR (isa->pwm); +if (ret == -ENODEV || ret == -EINVAL ) + isa->pwm =NULL ; +else +return dev_err_probe (dev, ret,"getting PWM\n" ); + } + +if (!isa->clk && !isa->pwm) +return dev_err_probe (dev, -EINVAL , +"clock or PWM are required, none were provided\n" ); + + ret =devm_regulator_bulk_get_enable (dev,ARRAY_SIZE (isa1200_supplies), + isa1200_supplies); +if (ret) +return dev_err_probe (dev, ret,"failed to set up supplies\n" ); + + isa->enable_gpios =devm_gpiod_get_array_optional (dev,"control" , +GPIOD_OUT_LOW ); +if (IS_ERR (isa->enable_gpios)) +return dev_err_probe (dev,PTR_ERR (isa->enable_gpios), +"failed to get enable gpios\n" ); + + ldo_node =device_get_named_child_node (dev,"ldo" ); +if (!ldo_node) +return dev_err_probe (dev, -ENODEV , +"failed to get embedded LDO node\n" ); + + ret =fwnode_property_read_u32 (ldo_node,"regulator-min-microvolt" , + &config->ldo_voltage); +fwnode_handle_put (ldo_node); +if (ret) +return dev_err_probe (dev, ret, +"failed to get ldo voltage\n" ); + + config->ldo_voltage =clamp (config->ldo_voltage, +ISA1200_LDO_VOLTAGE_MIN , +ISA1200_LDO_VOLTAGE_MAX ); + + config->ldo_voltage /=ISA1200_LDO_VOLTAGE_STEP ; +if (config->ldo_voltage <ISA1200_LDO_VOLTAGE_3V1 ) + config->ldo_voltage = config->ldo_voltage - +ISA1200_LDO_VOLTAGE_2V3 + +ISA1200_LDO_VOLTAGE_BASE ; +else + config->ldo_voltage -=ISA1200_LDO_VOLTAGE_3V1 ; + + config->mode =0 ;/* LRA_MODE */ +device_property_read_u32 (dev,"imagis,mode" , &config->mode); + + config->clkdiv =ISA1200_HCTRL0_CLKDIV_128 ; +device_property_read_u32 (dev,"imagis,clk-div" , &config->clkdiv); +if (!config->clkdiv) +return dev_err_probe (dev, -EINVAL ,"clk-div cannot be zero\n" ); + + config->clkdiv =clamp (config->clkdiv,ISA1200_HCTRL0_CLKDIV_128 , +ISA1200_HCTRL0_CLKDIV_128 <<3 ); + + ret =device_property_read_u32 (dev,"imagis,pll-div" , &config->plldiv); +if (ret <0 || !config->plldiv) + config->plldiv =1 ; + + config->period =0 ; + config->freq =0 ; + config->duty =0 ; + +if (isa->clk) { + ret =device_property_read_u32 (dev,"imagis,period-ns" , + &config->period); +if (ret) +return dev_err_probe (dev, ret, +"failed to get period\n" ); + +/* +* TODO: The scale value is arbitrary, but it fits observations +* quite well, and the exact conversion method is unknown. +* The period property value returned above is the HCTRL6 +* register value set by the vendor code, multiplied by 100. +*/ + config->period /=ISA1200_HCTRL6_PERIOD_SCALE ; + config->duty = config->period >>1 ; + } + +if (isa->pwm) { +struct pwm_state state; + +pwm_init_state (isa->pwm, &state); + +if (!state.period) +return dev_err_probe (dev, -EINVAL , +"PWM period cannot be zero\n" ); + + config->freq =div64_u64 (NANO , state.period * config->clkdiv); + config->duty = state.period >>1 ; + + ret =pwm_apply_might_sleep (isa->pwm, &state); +if (ret) +return dev_err_probe (dev, ret, +"failed to apply initial PWM state\n" ); + } + +/* +* TODO: If device is using a clock, this property should return the +* value written to the HCTRL5 register by downstrem code. It likely +* needs to be converted into a meaningful duty cycle value, though +* unfortunately the exact conversion mechanism is unknown. If the +* device uses PWM, this property will return the correct duty cycle +* in nanoseconds. +*/ +device_property_read_u32 (dev,"imagis,duty-cycle-ns" , &config->duty); + +return 0 ; +} + +static int isa1200_probe (struct i2c_client *client) +{ +struct isa1200 *isa; +struct device *dev = &client->dev; +DECLARE_BITMAP (values,ISA1200_EN_PINS_MAX ); +u32 val; +int ret; + + isa =devm_kzalloc (dev,sizeof (*isa),GFP_KERNEL ); +if (!isa) +return -ENOMEM ; + + isa->input =devm_input_allocate_device (dev); +if (!isa->input) +return -ENOMEM ; + +i2c_set_clientdata (client, isa); + + ret =isa1200_of_probe (client); +if (ret) +return ret; + + isa->map =devm_regmap_init_i2c (client, &isa1200_regmap_config); +if (IS_ERR (isa->map)) + return dev_err_probe(dev, PTR_ERR(isa->map),
drivers/input/misc/isa1200.c line 452
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+ "failed to initialize register map\n"); + + ret =clk_prepare_enable (isa->clk); +if (ret <0 ) +return dev_err_probe (dev, ret,"failed to enable clock\n" ); + + isa->clk_on = true; + +bitmap_fill (values,ISA1200_EN_PINS_MAX ); +gpiod_multi_set_value_cansleep (isa->enable_gpios, values);
You should factor our isa1200_power_on() from isa1200_start() and use it here.
drivers/input/misc/isa1200.c line 456
Quoted 4 lines
drivers/input/misc/isa1200.c new file +4
-0+ + ret =devm_add_action_or_reset (dev, isa1200_power_off, isa); +if (ret) +return ret;
close() is taking care of powering off the device.
drivers/input/misc/isa1200.c line 463
Quoted 7 lines
drivers/input/misc/isa1200.c new file +7
-0+ +usleep_range (200 ,300 ); + +/* Read a register so we know that regmap and I2C transport works */ + ret =regmap_read (isa->map,ISA1200_SCTRL , &val); +if (ret) +return dev_err_probe (dev, ret,"failed to read SCTRL\n" );
You should call isa1200_power_off() here. You do not know when the first effect will play. In the meantime the device should be in low power state.
drivers/input/misc/isa1200.c line 467
Quoted 4 lines
drivers/input/misc/isa1200.c new file +4
-0+ + ret =devm_work_autocancel (dev, &isa->play_work, isa1200_play_work); +if (ret) +return dev_err_probe (dev, ret,"failed to init work\n" );
I do not think you need it here. You supply input->close() and that should take care of stopping/canceling the work. Input core guarantees to call close() if the device is "open" whne unregistering.
drivers/input/misc/isa1200.c line 470
Quoted 3 lines
drivers/input/misc/isa1200.c new file +3
-0+ + isa->input->name ="isa1200-haptic" ; + isa->input->id.bustype =BUS_HOST ;
Not BUS_I2C?
drivers/input/misc/isa1200.c line 471
Quoted 1 line
drivers/input/misc/isa1200.c new file +1
-0+ isa->input->dev.parent = dev;
Parent is already set by devm_input_allocate_device().
drivers/input/misc/isa1200.c line 482
Quoted 11 lines
drivers/input/misc/isa1200.c new file +11
-0+ isa->input->close = isa1200_vibrator_close; + +input_set_drvdata (isa->input, isa); + +/* TODO: this hardware can likely support more than rumble */ +input_set_capability (isa->input,EV_FF ,FF_RUMBLE ); + + ret =input_ff_create_memless (isa->input,NULL , + isa1200_vibrator_play_effect); +if (ret) +return dev_err_probe (dev, ret,"couldn't create FF dev\n" );
"failed ..."
drivers/input/misc/isa1200.c line 486
Quoted 4 lines
drivers/input/misc/isa1200.c new file +4
-0+ + ret =input_register_device (isa->input); +if (ret) +return dev_err_probe (dev, ret,"couldn't register input dev\n" );
"failed ..."
drivers/input/misc/isa1200.c line 488
Quoted 2 lines
drivers/input/misc/isa1200.c new file +2
-0+ +return ret;
return 0;
drivers/input/misc/isa1200.c line 495
Quoted 7 lines
drivers/input/misc/isa1200.c new file +7
-0+} + +static int isa1200_suspend (struct device *dev) +{ +struct isa1200 *isa =dev_get_drvdata (dev); + +cancel_work_sync (&isa->play_work);
Move it under input_device_enabled().
Quoted 35 lines
drivers/input/misc/isa1200.c new file +35
-0+ +guard (mutex)(&isa->input->mutex); + +if (input_device_enabled (isa->input)) +if (isa->level) +isa1200_stop (isa); + +return 0 ; +} + +static int isa1200_resume (struct device *dev) +{ +struct isa1200 *isa =dev_get_drvdata (dev); + +guard (mutex)(&isa->input->mutex); + +if (input_device_enabled (isa->input)) +if (isa->level) +isa1200_start (isa); + +return 0 ; +} + +static DEFINE_SIMPLE_DEV_PM_OPS(isa1200_pm_ops, isa1200_suspend, isa1200_resume); + +static const struct of_device_id isa1200_of_match[] = { + { .compatible ="imagis,isa1200" }, + {/* sentinel */ } +}; +MODULE_DEVICE_TABLE (of, isa1200_of_match); + +static struct i2c_driver isa1200_i2c_driver = { + .driver = { + .name ="isa1200" , + .of_match_table = isa1200_of_match,
drivers/input/misc/isa1200.c line 540
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+ .pm = pm_sleep_ptr(&isa1200_pm_ops), + }, + .probe = isa1200_probe, +}; +module_i2c_driver (isa1200_i2c_driver); + +MODULE_AUTHOR ("Linus Walleij <[email protected]>" ); +MODULE_AUTHOR ("Svyatoslav Ryhel <[email protected]>" ); +MODULE_DESCRIPTION ("Imagis ISA1200 haptic feedback unit" ); +MODULE_LICENSE ("GPL" );
Thanks.
Signature · 1 line
Dmitry
Re: [PATCH v4 2/2] Input: isa1200 - new driver for Imagis ISA1200
чт, 7 трав. 2026 р. о 22:26 Dmitry Torokhov <[email protected]> пише:
Quoted 133 lines
Hi Svyatoslav,
Quoted 129 lines · Svyatoslav Ryhel
From: Linus Walleij <[email protected]>
The ISA1200 is a haptic feedback unit from Imagis Technology using two motors for haptic feedback in mobile phones. Used in many mobile devices c. 2012 including Samsung Galxy S Advance GT-I9070 (Janice), Samsung Beam GT-I8350 (Gavini), LG Optimus 4X P880 and LG Optimus Vu P895.
The exact datasheet for the ISA1200 is not available; all data was modeled based on available downstream kernel sources for various devices and fragments of information scattered across the internet.
Signed-off-by Linus Walleij <[email protected]>Co-developed-by Svyatoslav Ryhel <[email protected]>Signed-off-by Svyatoslav Ryhel <[email protected]>--- drivers/input/misc/Kconfig | 12 + drivers/input/misc/Makefile | 1 + drivers/input/misc/isa1200.c | 540 +++++++++++++++++++++++++++++++++++ 3 files changed, 553 insertions(+) create mode 100644 drivers/input/misc/isa1200.cdrivers/input/misc/Kconfig +12
-0@@ -852,6 +852,18 @@ config INPUT_IQS7222 To compile this driver as a module, choose M here: the module will be called iqs7222. +config INPUT_ISA1200_HAPTIC + tristate "Imagis ISA1200 haptic feedback unit" + depends on I2C + select INPUT_FF_MEMLESS + select REGMAP_I2C + help + Say Y to enable support for the Imagis ISA1200 haptic + feedback unit. + + To compile this driver as a module, choose M here: the + module will be called isa1200. + config INPUT_CMA3000 tristate "VTI CMA3000 Tri-axis accelerometer" helpdrivers/input/misc/Makefile +1
-0@@ -49,6 +49,7 @@ obj-$(CONFIG_INPUT_IMS_PCU) += ims-pcu.o obj-$(CONFIG_INPUT_IQS269A) += iqs269a.o obj-$(CONFIG_INPUT_IQS626A) += iqs626a.o obj-$(CONFIG_INPUT_IQS7222) += iqs7222.o +obj-$(CONFIG_INPUT_ISA1200_HAPTIC) += isa1200.o obj-$(CONFIG_INPUT_KEYSPAN_REMOTE) += keyspan_remote.o obj-$(CONFIG_INPUT_KXTJ9) += kxtj9.o obj-$(CONFIG_INPUT_M68K_BEEP) += m68kspkr.odrivers/input/misc/isa1200.c new file +66
-0@@ -0,0 +1,540 @@ +// SPDX-License-Identifier: GPL-2.0+ + +#include <linux/array_size.h> +#include <linux/bitmap.h> +#include <linux/bits.h> +#include <linux/clk.h> +#include <linux/delay.h> +#include <linux/device.h> +#include <linux/devm-helpers.h> +#include <linux/err.h> +#include <linux/gpio/consumer.h> +#include <linux/i2c.h> +#include <linux/input.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/property.h> +#include <linux/pwm.h> +#include <linux/regmap.h> +#include <linux/regulator/consumer.h> +#include <linux/units.h> + +/* +* System control (LDO regulator) +* +* LDO voltage to register mapping is linear, but it is split in two parts: +* 2.3V - 3.0V map to 0x08 - 0x0f; 3.1V - 3.8V map to 0x00 - 0x7 +*/ + +#define ISA1200_SCTRL 0x00 +#define ISA1200_LDO_VOLTAGE_BASE 0x08 +#define ISA1200_LDO_VOLTAGE_STEP 100000 +#define ISA1200_LDO_VOLTAGE_2V3 23 +#define ISA1200_LDO_VOLTAGE_3V1 31 +#define ISA1200_LDO_VOLTAGE_MIN 2300000 +#define ISA1200_LDO_VOLTAGE_MAX 3800000 + +/* +* The output frequency is calculated with this formula: +* +* base clock frequency +* fout = ----------------------------------------- +* (128 - PWM_FREQ) * 2 * PLLDIV * PWM_PERIOD +* +* The base clock frequency is the clock frequency provided on the +* clock input to the chip, divided by the value in HCTRL0 +* +* PWM_FREQ is configured in register HCTRL4, it is common to set this +* to 0 to get only two variables to calculate. +* +* PLLDIV is configured in register HCTRL3 (bits 7..4, so 0..15) +* PWM_PERIOD is configured in register HCTRL6 +* Further the duty cycle can be configured in HCTRL5 +*/ + +/* +* HCTRL0 configures clock or PWM input and selects the divider for +* the clock input. +*/ +#define ISA1200_HCTRL0 0x30 +#define ISA1200_HCTRL0_HAP_ENABLE BIT(7) +#define ISA1200_HCTRL0_PWM_GEN_MODE BIT(4) +#define ISA1200_HCTRL0_PWM_INPUT_MODE BIT(3) +#define ISA1200_HCTRL0_CLKDIV_128 128 + +/* +* HCTRL1 configures the motor type and clock sourse
Quoted 9 lines
drivers/input/misc/isa1200.c line 71
Quoted 5 lines
drivers/input/misc/isa1200.c new file +5
-0+*/ +#define ISA1200_HCTRL1 0x31 +#define ISA1200_HCTRL1_EXT_CLOCK BIT(7) +#define ISA1200_HCTRL1_DAC_INVERT BIT(6) +#define ISA1200_HCTRL1_MODE (n) (((n) & 1) << 5)I wonder if this should simply be BIT(5) and you conditionally use it in the code. The macro is not really usable to disable the setting...
That was the initial idea but mode is not boolean it is an enum and macro fits better to handle enum. Code does not enable/disable this field, this field is configured with every start call.
Quoted 54 lines
Quoted 54 lines
drivers/input/misc/isa1200.c new file +54
-0+ +/* HCTRL2 controls software reset of the chip */ +#define ISA1200_HCTRL2 0x32 +#define ISA1200_HCTRL2_SW_RESET BIT(0) + +/* +* HCTRL3 controls the PLL divisor +* +* Bits [0,1] are always set to 1 (we don't know what they are +* used for) and bit 4 and upward control the PLL divisor. +*/ +#define ISA1200_HCTRL3 0x33 +#define ISA1200_HCTRL3_DEFAULT 0x03 +#define ISA1200_HCTRL3_PLLDIV (n) (((n) & 0xf) << 4) + +/* HCTRL4 controls the PWM frequency of external channel */ +#define ISA1200_HCTRL4 0x34 + +/* HCTRL5 controls the PWM high duty cycle of internal channel */ +#define ISA1200_HCTRL5 0x35 + +/* HCTRL6 controls the PWM period of internal channel */ +#define ISA1200_HCTRL6 0x36 +#define ISA1200_HCTRL6_PERIOD_SCALE 100 + +/* The use for these registers is unknown but they exist */ +#define ISA1200_HCTRL7 0x37 +#define ISA1200_HCTRL8 0x38 +#define ISA1200_HCTRL9 0x39 +#define ISA1200_HCTRLA 0x3a +#define ISA1200_HCTRLB 0x3b +#define ISA1200_HCTRLC 0x3c +#define ISA1200_HCTRLD 0x3d + +#define ISA1200_EN_PINS_MAX 2 + +struct isa1200_config { +u32 ldo_voltage; +u32 mode; +u32 clkdiv; +u32 plldiv; +u32 freq; +u32 period; +u32 duty; +}; + +struct isa1200 { +struct input_dev *input; +struct regmap *map; + +struct clk *clk; +struct pwm_device *pwm; +struct gpio_descs *enable_gpios; +
Quoted 9 lines
drivers/input/misc/isa1200.c line 130
Quoted 5 lines
drivers/input/misc/isa1200.c new file +5
-0+struct work_struct play_work; +struct isa1200_config config; + +int level; +bool clk_on;I think you need not only
clk_on, but general "active" flag that you would set at the end ofisa1200_start().
Acknowledged.
Quoted 10 lines
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+}; + +static const struct regmap_config isa1200_regmap_config = { + .reg_bits =8 , + .val_bits =8 , + .max_register =ISA1200_HCTRLD , +}; + +static void isa1200_start (struct isa1200 *isa) +{
Quoted 9 lines
drivers/input/misc/isa1200.c line 145
Quoted 5 lines
drivers/input/misc/isa1200.c new file +5
-0+struct isa1200_config *config = &isa->config; +struct pwm_state state; +u8 hctrl0 =0 , hctrl1 =0 ; +DECLARE_BITMAP (values,ISA1200_EN_PINS_MAX ); +int ret;Please use "error" or "err" for all variables that only hold error codes (or 0) instead of a real value that is used for something.
Not real value, but return value. Why I cannot use ret aka return value? It is much more versatile since it can hold any function return value including errors.
Quoted 9 lines
drivers/input/misc/isa1200.c line 148
Quoted 3 lines
drivers/input/misc/isa1200.c new file +3
-0+ +if (!isa->clk_on) { + ret =clk_prepare_enable (isa->clk);This return 0 on success so
if (error) return;
No, code is correct. If clock enable fails, further function execution should stop since regmap operations on unconfigured device is not desirable. Since this function is void using general "active" flag as you suggested to indicate that start reached end would be beneficial.
Quoted 91 lines
Quoted 91 lines
drivers/input/misc/isa1200.c new file +91
-0+if (ret <0 ) +return ; + + isa->clk_on = true; + } + +bitmap_fill (values,ISA1200_EN_PINS_MAX ); +gpiod_multi_set_value_cansleep (isa->enable_gpios, values); + +usleep_range (200 ,300 ); + +regmap_write (isa->map,ISA1200_SCTRL , config->ldo_voltage); + +if (isa->clk) { + hctrl0 =ISA1200_HCTRL0_PWM_GEN_MODE ; + hctrl1 =ISA1200_HCTRL1_EXT_CLOCK ; + } + +if (isa->pwm) { + hctrl0 =ISA1200_HCTRL0_PWM_INPUT_MODE ; + hctrl1 =0 ; + } + + hctrl0 |=__ffs (config->clkdiv /ISA1200_HCTRL0_CLKDIV_128 ); + hctrl1 |=ISA1200_HCTRL1_DAC_INVERT ; + hctrl1 |=ISA1200_HCTRL1_MODE (config->mode); + +regmap_write (isa->map,ISA1200_HCTRL0 , hctrl0); +regmap_write (isa->map,ISA1200_HCTRL1 , hctrl1); + +/* Make sure to de-assert software reset */ +regmap_write (isa->map,ISA1200_HCTRL2 ,0x00 ); + +/* PLL divisor */ +regmap_write (isa->map,ISA1200_HCTRL3 , +ISA1200_HCTRL3_PLLDIV (config->plldiv) | +ISA1200_HCTRL3_DEFAULT ); + +/* Frequency */ +regmap_write (isa->map,ISA1200_HCTRL4 , config->freq); +/* Duty cycle */ +regmap_write (isa->map,ISA1200_HCTRL5 , config->period >>1 ); +/* Period */ +regmap_write (isa->map,ISA1200_HCTRL6 , config->period); + + hctrl0 |=ISA1200_HCTRL0_HAP_ENABLE ; +regmap_write (isa->map,ISA1200_HCTRL0 , hctrl0); + +if (isa->clk) +regmap_write (isa->map,ISA1200_HCTRL5 , config->duty); + +if (isa->pwm) { +pwm_get_state (isa->pwm, &state); + state.duty_cycle = config->duty; + state.enabled = true; +pwm_apply_might_sleep (isa->pwm, &state); + } +} + +static void isa1200_power_off (void *data) +{ +struct isa1200 *isa = data; + +DECLARE_BITMAP (values,ISA1200_EN_PINS_MAX ); + +bitmap_zero (values,ISA1200_EN_PINS_MAX ); +gpiod_multi_set_value_cansleep (isa->enable_gpios, values); + +if (isa->clk_on) { +clk_disable_unprepare (isa->clk); + isa->clk_on = false; + } +} + +static void isa1200_stop (struct isa1200 *isa) +{ +struct pwm_state state; + +if (isa->pwm) { +pwm_get_state (isa->pwm, &state); + state.duty_cycle =0 ; + state.enabled = false; +pwm_apply_might_sleep (isa->pwm, &state); + } + +regmap_write (isa->map,ISA1200_HCTRL0 ,0x00 ); +isa1200_power_off (isa); +} + +static void isa1200_play_work (struct work_struct *work) +{
Quoted 9 lines
drivers/input/misc/isa1200.c line 243
Quoted 4 lines
drivers/input/misc/isa1200.c new file +4
-0+struct isa1200 *isa = + container_of(work, struct isa1200, play_work); + +guard (mutex)(&isa->input->mutex);I think this mutex is dangerous here. You really want to stop/cancel work in
suspend()andclose()instead of blocking on the mutex and then continuing.
This is controversial solution, I do agree.
Quoted 35 lines
Quoted 35 lines
drivers/input/misc/isa1200.c new file +35
-0+ +if (isa->level) +isa1200_start (isa); +else +isa1200_stop (isa); +} + +static int isa1200_vibrator_play_effect (struct input_dev *input,void *data, +struct ff_effect *effect) +{ +struct isa1200 *isa =input_get_drvdata (input); +int level; + +/* +* TODO: we currently only support rumble. +* The ISA1200 can control two motors and some devices +* also have two motors mounted. +*/ + level = effect->u.rumble.strong_magnitude; +if (!level) + level = effect->u.rumble.weak_magnitude; + +dev_dbg (&input->dev,"FF effect type %d level %d\n" , + effect->type, level); + +if (isa->level != level) { + isa->level = level; +schedule_work (&isa->play_work); + } + +return 0 ; +} + +static void isa1200_vibrator_close (struct input_dev *input) +{
Quoted 9 lines
drivers/input/misc/isa1200.c line 283
Quoted 5 lines
drivers/input/misc/isa1200.c new file +5
-0+struct isa1200 *isa =input_get_drvdata (input); + +cancel_work_sync (&isa->play_work); + +if (isa->level)So here I think you need to check that "active" flag that would represent the committed state.
Yes, acknowledged.
Quoted 180 lines
Quoted 159 lines
drivers/input/misc/isa1200.c new file +159
-0+isa1200_stop (isa); + + isa->level =0 ; +} + +static int isa1200_of_probe (struct i2c_client *client) +{ +static const char *const isa1200_supplies[] = {"vdd" ,"vddp" }; +struct isa1200 *isa =i2c_get_clientdata (client); +struct isa1200_config *config = &isa->config; +struct device *dev = &client->dev; +struct fwnode_handle *ldo_node; +int ret; + + isa->clk =devm_clk_get_optional (dev,NULL ); +if (IS_ERR (isa->clk)) +return dev_err_probe (dev,PTR_ERR (isa->clk), +"failed to get clock\n" ); + + isa->pwm =devm_pwm_get (dev,NULL ); +if (IS_ERR (isa->pwm)) { + ret =PTR_ERR (isa->pwm); +if (ret == -ENODEV || ret == -EINVAL ) + isa->pwm =NULL ; +else +return dev_err_probe (dev, ret,"getting PWM\n" ); + } + +if (!isa->clk && !isa->pwm) +return dev_err_probe (dev, -EINVAL , +"clock or PWM are required, none were provided\n" ); + + ret =devm_regulator_bulk_get_enable (dev,ARRAY_SIZE (isa1200_supplies), + isa1200_supplies); +if (ret) +return dev_err_probe (dev, ret,"failed to set up supplies\n" ); + + isa->enable_gpios =devm_gpiod_get_array_optional (dev,"control" , +GPIOD_OUT_LOW ); +if (IS_ERR (isa->enable_gpios)) +return dev_err_probe (dev,PTR_ERR (isa->enable_gpios), +"failed to get enable gpios\n" ); + + ldo_node =device_get_named_child_node (dev,"ldo" ); +if (!ldo_node) +return dev_err_probe (dev, -ENODEV , +"failed to get embedded LDO node\n" ); + + ret =fwnode_property_read_u32 (ldo_node,"regulator-min-microvolt" , + &config->ldo_voltage); +fwnode_handle_put (ldo_node); +if (ret) +return dev_err_probe (dev, ret, +"failed to get ldo voltage\n" ); + + config->ldo_voltage =clamp (config->ldo_voltage, +ISA1200_LDO_VOLTAGE_MIN , +ISA1200_LDO_VOLTAGE_MAX ); + + config->ldo_voltage /=ISA1200_LDO_VOLTAGE_STEP ; +if (config->ldo_voltage <ISA1200_LDO_VOLTAGE_3V1 ) + config->ldo_voltage = config->ldo_voltage - +ISA1200_LDO_VOLTAGE_2V3 + +ISA1200_LDO_VOLTAGE_BASE ; +else + config->ldo_voltage -=ISA1200_LDO_VOLTAGE_3V1 ; + + config->mode =0 ;/* LRA_MODE */ +device_property_read_u32 (dev,"imagis,mode" , &config->mode); + + config->clkdiv =ISA1200_HCTRL0_CLKDIV_128 ; +device_property_read_u32 (dev,"imagis,clk-div" , &config->clkdiv); +if (!config->clkdiv) +return dev_err_probe (dev, -EINVAL ,"clk-div cannot be zero\n" ); + + config->clkdiv =clamp (config->clkdiv,ISA1200_HCTRL0_CLKDIV_128 , +ISA1200_HCTRL0_CLKDIV_128 <<3 ); + + ret =device_property_read_u32 (dev,"imagis,pll-div" , &config->plldiv); +if (ret <0 || !config->plldiv) + config->plldiv =1 ; + + config->period =0 ; + config->freq =0 ; + config->duty =0 ; + +if (isa->clk) { + ret =device_property_read_u32 (dev,"imagis,period-ns" , + &config->period); +if (ret) +return dev_err_probe (dev, ret, +"failed to get period\n" ); + +/* +* TODO: The scale value is arbitrary, but it fits observations +* quite well, and the exact conversion method is unknown. +* The period property value returned above is the HCTRL6 +* register value set by the vendor code, multiplied by 100. +*/ + config->period /=ISA1200_HCTRL6_PERIOD_SCALE ; + config->duty = config->period >>1 ; + } + +if (isa->pwm) { +struct pwm_state state; + +pwm_init_state (isa->pwm, &state); + +if (!state.period) +return dev_err_probe (dev, -EINVAL , +"PWM period cannot be zero\n" ); + + config->freq =div64_u64 (NANO , state.period * config->clkdiv); + config->duty = state.period >>1 ; + + ret =pwm_apply_might_sleep (isa->pwm, &state); +if (ret) +return dev_err_probe (dev, ret, +"failed to apply initial PWM state\n" ); + } + +/* +* TODO: If device is using a clock, this property should return the +* value written to the HCTRL5 register by downstrem code. It likely +* needs to be converted into a meaningful duty cycle value, though +* unfortunately the exact conversion mechanism is unknown. If the +* device uses PWM, this property will return the correct duty cycle +* in nanoseconds. +*/ +device_property_read_u32 (dev,"imagis,duty-cycle-ns" , &config->duty); + +return 0 ; +} + +static int isa1200_probe (struct i2c_client *client) +{ +struct isa1200 *isa; +struct device *dev = &client->dev; +DECLARE_BITMAP (values,ISA1200_EN_PINS_MAX ); +u32 val; +int ret; + + isa =devm_kzalloc (dev,sizeof (*isa),GFP_KERNEL ); +if (!isa) +return -ENOMEM ; + + isa->input =devm_input_allocate_device (dev); +if (!isa->input) +return -ENOMEM ; + +i2c_set_clientdata (client, isa); + + ret =isa1200_of_probe (client); +if (ret) +return ret; + + isa->map =devm_regmap_init_i2c (client, &isa1200_regmap_config); +if (IS_ERR (isa->map)) + return dev_err_probe(dev, PTR_ERR(isa->map),drivers/input/misc/isa1200.c line 452
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+ "failed to initialize register map\n"); + + ret =clk_prepare_enable (isa->clk); +if (ret <0 ) +return dev_err_probe (dev, ret,"failed to enable clock\n" ); + + isa->clk_on = true; + +bitmap_fill (values,ISA1200_EN_PINS_MAX ); +gpiod_multi_set_value_cansleep (isa->enable_gpios, values);You should factor our
isa1200_power_on()fromisa1200_start()and use it here.drivers/input/misc/isa1200.c line 456
Quoted 4 lines
drivers/input/misc/isa1200.c new file +4
-0+ + ret =devm_add_action_or_reset (dev, isa1200_power_off, isa); +if (ret) +return ret;
close()is taking care of powering off the device.
Quoted 12 lines
drivers/input/misc/isa1200.c line 463
Quoted 7 lines
drivers/input/misc/isa1200.c new file +7
-0+ +usleep_range (200 ,300 ); + +/* Read a register so we know that regmap and I2C transport works */ + ret =regmap_read (isa->map,ISA1200_SCTRL , &val); +if (ret) +return dev_err_probe (dev, ret,"failed to read SCTRL\n" );You should call
isa1200_power_off()here. You do not know when the first effect will play. In the meantime the device should be in low power state.
Oh, so probe should leave device powered off. That is very nice, I can just remove regmap access, and don't touch power sequences at all. That will simplify code quite a bit.
Quoted 9 lines
drivers/input/misc/isa1200.c line 467
Quoted 4 lines
drivers/input/misc/isa1200.c new file +4
-0+ + ret =devm_work_autocancel (dev, &isa->play_work, isa1200_play_work); +if (ret) +return dev_err_probe (dev, ret,"failed to init work\n" );I do not think you need it here. You supply
input->close()and that should take care of stopping/canceling the work. Input core guarantees to callclose()if the device is "open" whne unregistering.
Here and all next comments. Acknowledged, I will adjust accordingly. Thank you.
Quoted 96 lines
drivers/input/misc/isa1200.c line 470
Quoted 3 lines
drivers/input/misc/isa1200.c new file +3
-0+ + isa->input->name ="isa1200-haptic" ; + isa->input->id.bustype =BUS_HOST ;Not
BUS_I2C?drivers/input/misc/isa1200.c line 471
Quoted 1 line
drivers/input/misc/isa1200.c new file +1
-0+ isa->input->dev.parent = dev;Parent is already set by
devm_input_allocate_device().drivers/input/misc/isa1200.c line 482
Quoted 11 lines
drivers/input/misc/isa1200.c new file +11
-0+ isa->input->close = isa1200_vibrator_close; + +input_set_drvdata (isa->input, isa); + +/* TODO: this hardware can likely support more than rumble */ +input_set_capability (isa->input,EV_FF ,FF_RUMBLE ); + + ret =input_ff_create_memless (isa->input,NULL , + isa1200_vibrator_play_effect); +if (ret) +return dev_err_probe (dev, ret,"couldn't create FF dev\n" );"failed ..."
drivers/input/misc/isa1200.c line 486
Quoted 4 lines
drivers/input/misc/isa1200.c new file +4
-0+ + ret =input_register_device (isa->input); +if (ret) +return dev_err_probe (dev, ret,"couldn't register input dev\n" );"failed ..."
drivers/input/misc/isa1200.c line 488
Quoted 2 lines
drivers/input/misc/isa1200.c new file +2
-0+ +return ret;return 0;drivers/input/misc/isa1200.c line 495
Quoted 7 lines
drivers/input/misc/isa1200.c new file +7
-0+} + +static int isa1200_suspend (struct device *dev) +{ +struct isa1200 *isa =dev_get_drvdata (dev); + +cancel_work_sync (&isa->play_work);Move it under
input_device_enabled().Quoted 35 lines
drivers/input/misc/isa1200.c new file +35
-0+ +guard (mutex)(&isa->input->mutex); + +if (input_device_enabled (isa->input)) +if (isa->level) +isa1200_stop (isa); + +return 0 ; +} + +static int isa1200_resume (struct device *dev) +{ +struct isa1200 *isa =dev_get_drvdata (dev); + +guard (mutex)(&isa->input->mutex); + +if (input_device_enabled (isa->input)) +if (isa->level) +isa1200_start (isa); + +return 0 ; +} + +static DEFINE_SIMPLE_DEV_PM_OPS(isa1200_pm_ops, isa1200_suspend, isa1200_resume); + +static const struct of_device_id isa1200_of_match[] = { + { .compatible ="imagis,isa1200" }, + {/* sentinel */ } +}; +MODULE_DEVICE_TABLE (of, isa1200_of_match); + +static struct i2c_driver isa1200_i2c_driver = { + .driver = { + .name ="isa1200" , + .of_match_table = isa1200_of_match,drivers/input/misc/isa1200.c line 540
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+ .pm = pm_sleep_ptr(&isa1200_pm_ops), + }, + .probe = isa1200_probe, +}; +module_i2c_driver (isa1200_i2c_driver); + +MODULE_AUTHOR ("Linus Walleij <[email protected]>" ); +MODULE_AUTHOR ("Svyatoslav Ryhel <[email protected]>" ); +MODULE_DESCRIPTION ("Imagis ISA1200 haptic feedback unit" ); +MODULE_LICENSE ("GPL" );Thanks.
--
Dmitry
Dmitry Torokhov
maintainerRe: [PATCH v4 2/2] Input: isa1200 - new driver for Imagis ISA1200
Quoted 144 lines · Svyatoslav Ryhel
чт, 7 трав. 2026 р. о 22:26 Dmitry Torokhov <[email protected]> пише:
Quoted 133 lines
Hi Svyatoslav,
Quoted 129 lines · Svyatoslav Ryhel
From: Linus Walleij <[email protected]>
The ISA1200 is a haptic feedback unit from Imagis Technology using two motors for haptic feedback in mobile phones. Used in many mobile devices c. 2012 including Samsung Galxy S Advance GT-I9070 (Janice), Samsung Beam GT-I8350 (Gavini), LG Optimus 4X P880 and LG Optimus Vu P895.
The exact datasheet for the ISA1200 is not available; all data was modeled based on available downstream kernel sources for various devices and fragments of information scattered across the internet.
Signed-off-by Linus Walleij <[email protected]>Co-developed-by Svyatoslav Ryhel <[email protected]>Signed-off-by Svyatoslav Ryhel <[email protected]>--- drivers/input/misc/Kconfig | 12 + drivers/input/misc/Makefile | 1 + drivers/input/misc/isa1200.c | 540 +++++++++++++++++++++++++++++++++++ 3 files changed, 553 insertions(+) create mode 100644 drivers/input/misc/isa1200.cdrivers/input/misc/Kconfig +12
-0@@ -852,6 +852,18 @@ config INPUT_IQS7222 To compile this driver as a module, choose M here: the module will be called iqs7222. +config INPUT_ISA1200_HAPTIC + tristate "Imagis ISA1200 haptic feedback unit" + depends on I2C + select INPUT_FF_MEMLESS + select REGMAP_I2C + help + Say Y to enable support for the Imagis ISA1200 haptic + feedback unit. + + To compile this driver as a module, choose M here: the + module will be called isa1200. + config INPUT_CMA3000 tristate "VTI CMA3000 Tri-axis accelerometer" helpdrivers/input/misc/Makefile +1
-0@@ -49,6 +49,7 @@ obj-$(CONFIG_INPUT_IMS_PCU) += ims-pcu.o obj-$(CONFIG_INPUT_IQS269A) += iqs269a.o obj-$(CONFIG_INPUT_IQS626A) += iqs626a.o obj-$(CONFIG_INPUT_IQS7222) += iqs7222.o +obj-$(CONFIG_INPUT_ISA1200_HAPTIC) += isa1200.o obj-$(CONFIG_INPUT_KEYSPAN_REMOTE) += keyspan_remote.o obj-$(CONFIG_INPUT_KXTJ9) += kxtj9.o obj-$(CONFIG_INPUT_M68K_BEEP) += m68kspkr.odrivers/input/misc/isa1200.c new file +66
-0@@ -0,0 +1,540 @@ +// SPDX-License-Identifier: GPL-2.0+ + +#include <linux/array_size.h> +#include <linux/bitmap.h> +#include <linux/bits.h> +#include <linux/clk.h> +#include <linux/delay.h> +#include <linux/device.h> +#include <linux/devm-helpers.h> +#include <linux/err.h> +#include <linux/gpio/consumer.h> +#include <linux/i2c.h> +#include <linux/input.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/property.h> +#include <linux/pwm.h> +#include <linux/regmap.h> +#include <linux/regulator/consumer.h> +#include <linux/units.h> + +/* +* System control (LDO regulator) +* +* LDO voltage to register mapping is linear, but it is split in two parts: +* 2.3V - 3.0V map to 0x08 - 0x0f; 3.1V - 3.8V map to 0x00 - 0x7 +*/ + +#define ISA1200_SCTRL 0x00 +#define ISA1200_LDO_VOLTAGE_BASE 0x08 +#define ISA1200_LDO_VOLTAGE_STEP 100000 +#define ISA1200_LDO_VOLTAGE_2V3 23 +#define ISA1200_LDO_VOLTAGE_3V1 31 +#define ISA1200_LDO_VOLTAGE_MIN 2300000 +#define ISA1200_LDO_VOLTAGE_MAX 3800000 + +/* +* The output frequency is calculated with this formula: +* +* base clock frequency +* fout = ----------------------------------------- +* (128 - PWM_FREQ) * 2 * PLLDIV * PWM_PERIOD +* +* The base clock frequency is the clock frequency provided on the +* clock input to the chip, divided by the value in HCTRL0 +* +* PWM_FREQ is configured in register HCTRL4, it is common to set this +* to 0 to get only two variables to calculate. +* +* PLLDIV is configured in register HCTRL3 (bits 7..4, so 0..15) +* PWM_PERIOD is configured in register HCTRL6 +* Further the duty cycle can be configured in HCTRL5 +*/ + +/* +* HCTRL0 configures clock or PWM input and selects the divider for +* the clock input. +*/ +#define ISA1200_HCTRL0 0x30 +#define ISA1200_HCTRL0_HAP_ENABLE BIT(7) +#define ISA1200_HCTRL0_PWM_GEN_MODE BIT(4) +#define ISA1200_HCTRL0_PWM_INPUT_MODE BIT(3) +#define ISA1200_HCTRL0_CLKDIV_128 128 + +/* +* HCTRL1 configures the motor type and clock sourse Quoted 9 lines
drivers/input/misc/isa1200.c line 71
Quoted 5 lines
drivers/input/misc/isa1200.c new file +5
-0+*/ +#define ISA1200_HCTRL1 0x31 +#define ISA1200_HCTRL1_EXT_CLOCK BIT(7) +#define ISA1200_HCTRL1_DAC_INVERT BIT(6) +#define ISA1200_HCTRL1_MODE (n) (((n) & 1) << 5)I wonder if this should simply be BIT(5) and you conditionally use it in the code. The macro is not really usable to disable the setting...
Quoted 3 lines
That was the initial idea but mode is not boolean it is an enum and macro fits better to handle enum. Code does not enable/disable this field, this field is configured with every start call.
OK.
Quoted 87 lines
Quoted 55 lines
Quoted 55 lines
drivers/input/misc/isa1200.c new file +54
-0+ +/* HCTRL2 controls software reset of the chip */ +#define ISA1200_HCTRL2 0x32 +#define ISA1200_HCTRL2_SW_RESET BIT(0) + +/* +* HCTRL3 controls the PLL divisor +* +* Bits [0,1] are always set to 1 (we don't know what they are +* used for) and bit 4 and upward control the PLL divisor. +*/ +#define ISA1200_HCTRL3 0x33 +#define ISA1200_HCTRL3_DEFAULT 0x03 +#define ISA1200_HCTRL3_PLLDIV (n) (((n) & 0xf) << 4) + +/* HCTRL4 controls the PWM frequency of external channel */ +#define ISA1200_HCTRL4 0x34 + +/* HCTRL5 controls the PWM high duty cycle of internal channel */ +#define ISA1200_HCTRL5 0x35 + +/* HCTRL6 controls the PWM period of internal channel */ +#define ISA1200_HCTRL6 0x36 +#define ISA1200_HCTRL6_PERIOD_SCALE 100 + +/* The use for these registers is unknown but they exist */ +#define ISA1200_HCTRL7 0x37 +#define ISA1200_HCTRL8 0x38 +#define ISA1200_HCTRL9 0x39 +#define ISA1200_HCTRLA 0x3a +#define ISA1200_HCTRLB 0x3b +#define ISA1200_HCTRLC 0x3c +#define ISA1200_HCTRLD 0x3d + +#define ISA1200_EN_PINS_MAX 2 + +struct isa1200_config { +u32 ldo_voltage; +u32 mode; +u32 clkdiv; +u32 plldiv; +u32 freq; +u32 period; +u32 duty; +}; + +struct isa1200 { +struct input_dev *input; +struct regmap *map; + +struct clk *clk; +struct pwm_device *pwm; +struct gpio_descs *enable_gpios; +Quoted 9 lines
drivers/input/misc/isa1200.c line 130
Quoted 5 lines
drivers/input/misc/isa1200.c new file +5
-0+struct work_struct play_work; +struct isa1200_config config; + +int level; +bool clk_on;I think you need not only
clk_on, but general "active" flag that you would set at the end ofisa1200_start().Acknowledged.
Quoted 10 lines
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+}; + +static const struct regmap_config isa1200_regmap_config = { + .reg_bits =8 , + .val_bits =8 , + .max_register =ISA1200_HCTRLD , +}; + +static void isa1200_start (struct isa1200 *isa) +{Quoted 9 lines
drivers/input/misc/isa1200.c line 145
Quoted 5 lines
drivers/input/misc/isa1200.c new file +5
-0+struct isa1200_config *config = &isa->config; +struct pwm_state state; +u8 hctrl0 =0 , hctrl1 =0 ; +DECLARE_BITMAP (values,ISA1200_EN_PINS_MAX ); +int ret;Please use "error" or "err" for all variables that only hold error codes (or 0) instead of a real value that is used for something.
Quoted 3 lines
Not real value, but return value. Why I cannot use ret aka return value? It is much more versatile since it can hold any function return value including errors.
This is my preference for input. I do not want versatility, I want the
opposite: if I see error I do not need to consider whether it holds something of value besides an error code. And if I see "ret" or "retval" I know that caller might be interested the value. And also
if (error) {
// handle error
}looks neat.
Quoted 7 lines
Quoted 7 lines
drivers/input/misc/isa1200.c line 148
Quoted 4 lines
drivers/input/misc/isa1200.c new file +3
-0+ +if (!isa->clk_on) { + ret =clk_prepare_enable (isa->clk);This return 0 on success so
Quoted 8 lines
Quoted 3 lines
if (error) return;No, code is correct. If clock enable fails, further function execution should stop since regmap operations on unconfigured device is not desirable. Since this function is void using general "active" flag as you suggested to indicate that start reached end would be beneficial.
I am simply saying that you do not need to check if value is negative, checking that it is non-zero is sufficient.
Thanks.
Signature · 1 line
Dmitry
Re: [PATCH v4 2/2] Input: isa1200 - new driver for Imagis ISA1200
пт, 8 трав. 2026 р. о 08:40 Dmitry Torokhov <[email protected]> пише:
Quoted 248 lines · Svyatoslav Ryhel
Quoted 144 lines
чт, 7 трав. 2026 р. о 22:26 Dmitry Torokhov <[email protected]> пише:
Quoted 133 lines
Hi Svyatoslav,
Quoted 129 lines · Svyatoslav Ryhel
From: Linus Walleij <[email protected]>
The ISA1200 is a haptic feedback unit from Imagis Technology using two motors for haptic feedback in mobile phones. Used in many mobile devices c. 2012 including Samsung Galxy S Advance GT-I9070 (Janice), Samsung Beam GT-I8350 (Gavini), LG Optimus 4X P880 and LG Optimus Vu P895.
The exact datasheet for the ISA1200 is not available; all data was modeled based on available downstream kernel sources for various devices and fragments of information scattered across the internet.
Signed-off-by Linus Walleij <[email protected]>Co-developed-by Svyatoslav Ryhel <[email protected]>Signed-off-by Svyatoslav Ryhel <[email protected]>--- drivers/input/misc/Kconfig | 12 + drivers/input/misc/Makefile | 1 + drivers/input/misc/isa1200.c | 540 +++++++++++++++++++++++++++++++++++ 3 files changed, 553 insertions(+) create mode 100644 drivers/input/misc/isa1200.cdrivers/input/misc/Kconfig +12
-0@@ -852,6 +852,18 @@ config INPUT_IQS7222 To compile this driver as a module, choose M here: the module will be called iqs7222. +config INPUT_ISA1200_HAPTIC + tristate "Imagis ISA1200 haptic feedback unit" + depends on I2C + select INPUT_FF_MEMLESS + select REGMAP_I2C + help + Say Y to enable support for the Imagis ISA1200 haptic + feedback unit. + + To compile this driver as a module, choose M here: the + module will be called isa1200. + config INPUT_CMA3000 tristate "VTI CMA3000 Tri-axis accelerometer" helpdrivers/input/misc/Makefile +1
-0@@ -49,6 +49,7 @@ obj-$(CONFIG_INPUT_IMS_PCU) += ims-pcu.o obj-$(CONFIG_INPUT_IQS269A) += iqs269a.o obj-$(CONFIG_INPUT_IQS626A) += iqs626a.o obj-$(CONFIG_INPUT_IQS7222) += iqs7222.o +obj-$(CONFIG_INPUT_ISA1200_HAPTIC) += isa1200.o obj-$(CONFIG_INPUT_KEYSPAN_REMOTE) += keyspan_remote.o obj-$(CONFIG_INPUT_KXTJ9) += kxtj9.o obj-$(CONFIG_INPUT_M68K_BEEP) += m68kspkr.odrivers/input/misc/isa1200.c new file +66
-0@@ -0,0 +1,540 @@ +// SPDX-License-Identifier: GPL-2.0+ + +#include <linux/array_size.h> +#include <linux/bitmap.h> +#include <linux/bits.h> +#include <linux/clk.h> +#include <linux/delay.h> +#include <linux/device.h> +#include <linux/devm-helpers.h> +#include <linux/err.h> +#include <linux/gpio/consumer.h> +#include <linux/i2c.h> +#include <linux/input.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/property.h> +#include <linux/pwm.h> +#include <linux/regmap.h> +#include <linux/regulator/consumer.h> +#include <linux/units.h> + +/* +* System control (LDO regulator) +* +* LDO voltage to register mapping is linear, but it is split in two parts: +* 2.3V - 3.0V map to 0x08 - 0x0f; 3.1V - 3.8V map to 0x00 - 0x7 +*/ + +#define ISA1200_SCTRL 0x00 +#define ISA1200_LDO_VOLTAGE_BASE 0x08 +#define ISA1200_LDO_VOLTAGE_STEP 100000 +#define ISA1200_LDO_VOLTAGE_2V3 23 +#define ISA1200_LDO_VOLTAGE_3V1 31 +#define ISA1200_LDO_VOLTAGE_MIN 2300000 +#define ISA1200_LDO_VOLTAGE_MAX 3800000 + +/* +* The output frequency is calculated with this formula: +* +* base clock frequency +* fout = ----------------------------------------- +* (128 - PWM_FREQ) * 2 * PLLDIV * PWM_PERIOD +* +* The base clock frequency is the clock frequency provided on the +* clock input to the chip, divided by the value in HCTRL0 +* +* PWM_FREQ is configured in register HCTRL4, it is common to set this +* to 0 to get only two variables to calculate. +* +* PLLDIV is configured in register HCTRL3 (bits 7..4, so 0..15) +* PWM_PERIOD is configured in register HCTRL6 +* Further the duty cycle can be configured in HCTRL5 +*/ + +/* +* HCTRL0 configures clock or PWM input and selects the divider for +* the clock input. +*/ +#define ISA1200_HCTRL0 0x30 +#define ISA1200_HCTRL0_HAP_ENABLE BIT(7) +#define ISA1200_HCTRL0_PWM_GEN_MODE BIT(4) +#define ISA1200_HCTRL0_PWM_INPUT_MODE BIT(3) +#define ISA1200_HCTRL0_CLKDIV_128 128 + +/* +* HCTRL1 configures the motor type and clock sourse Quoted 9 lines
drivers/input/misc/isa1200.c line 71
Quoted 5 lines
drivers/input/misc/isa1200.c new file +5
-0+*/ +#define ISA1200_HCTRL1 0x31 +#define ISA1200_HCTRL1_EXT_CLOCK BIT(7) +#define ISA1200_HCTRL1_DAC_INVERT BIT(6) +#define ISA1200_HCTRL1_MODE (n) (((n) & 1) << 5)I wonder if this should simply be BIT(5) and you conditionally use it in the code. The macro is not really usable to disable the setting...
Quoted 3 lines
That was the initial idea but mode is not boolean it is an enum and macro fits better to handle enum. Code does not enable/disable this field, this field is configured with every start call.
OK.
Quoted 87 lines
Quoted 55 lines
Quoted 55 lines
drivers/input/misc/isa1200.c new file +54
-0+ +/* HCTRL2 controls software reset of the chip */ +#define ISA1200_HCTRL2 0x32 +#define ISA1200_HCTRL2_SW_RESET BIT(0) + +/* +* HCTRL3 controls the PLL divisor +* +* Bits [0,1] are always set to 1 (we don't know what they are +* used for) and bit 4 and upward control the PLL divisor. +*/ +#define ISA1200_HCTRL3 0x33 +#define ISA1200_HCTRL3_DEFAULT 0x03 +#define ISA1200_HCTRL3_PLLDIV (n) (((n) & 0xf) << 4) + +/* HCTRL4 controls the PWM frequency of external channel */ +#define ISA1200_HCTRL4 0x34 + +/* HCTRL5 controls the PWM high duty cycle of internal channel */ +#define ISA1200_HCTRL5 0x35 + +/* HCTRL6 controls the PWM period of internal channel */ +#define ISA1200_HCTRL6 0x36 +#define ISA1200_HCTRL6_PERIOD_SCALE 100 + +/* The use for these registers is unknown but they exist */ +#define ISA1200_HCTRL7 0x37 +#define ISA1200_HCTRL8 0x38 +#define ISA1200_HCTRL9 0x39 +#define ISA1200_HCTRLA 0x3a +#define ISA1200_HCTRLB 0x3b +#define ISA1200_HCTRLC 0x3c +#define ISA1200_HCTRLD 0x3d + +#define ISA1200_EN_PINS_MAX 2 + +struct isa1200_config { +u32 ldo_voltage; +u32 mode; +u32 clkdiv; +u32 plldiv; +u32 freq; +u32 period; +u32 duty; +}; + +struct isa1200 { +struct input_dev *input; +struct regmap *map; + +struct clk *clk; +struct pwm_device *pwm; +struct gpio_descs *enable_gpios; +Quoted 9 lines
drivers/input/misc/isa1200.c line 130
Quoted 5 lines
drivers/input/misc/isa1200.c new file +5
-0+struct work_struct play_work; +struct isa1200_config config; + +int level; +bool clk_on;I think you need not only
clk_on, but general "active" flag that you would set at the end ofisa1200_start().Acknowledged.
Quoted 10 lines
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+}; + +static const struct regmap_config isa1200_regmap_config = { + .reg_bits =8 , + .val_bits =8 , + .max_register =ISA1200_HCTRLD , +}; + +static void isa1200_start (struct isa1200 *isa) +{Quoted 9 lines
drivers/input/misc/isa1200.c line 145
Quoted 5 lines
drivers/input/misc/isa1200.c new file +5
-0+struct isa1200_config *config = &isa->config; +struct pwm_state state; +u8 hctrl0 =0 , hctrl1 =0 ; +DECLARE_BITMAP (values,ISA1200_EN_PINS_MAX ); +int ret;Please use "error" or "err" for all variables that only hold error codes (or 0) instead of a real value that is used for something.
Quoted 3 lines
Not real value, but return value. Why I cannot use ret aka return value? It is much more versatile since it can hold any function return value including errors.
This is my preference for input. I do not want versatility, I want the
opposite: if I see error I do not need to consider whether it holds something of value besides an error code. And if I see "ret" or "retval" I know that caller might be interested the value. And also
Quoted 6 lines
if (error) { // handle error }looks neat.
Ok, noted
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
drivers/input/misc/isa1200.c line 148
Quoted 4 lines
drivers/input/misc/isa1200.c new file +3
-0+ +if (!isa->clk_on) { + ret =clk_prepare_enable (isa->clk);This return 0 on success so
if (error) return;
Quoted 8 lines
Quoted 4 lines
No, code is correct. If clock enable fails, further function execution should stop since regmap operations on unconfigured device is not desirable. Since this function is void using general "active" flag as you suggested to indicate that start reached end would be beneficial.
I am simply saying that you do not need to check if value is negative, checking that it is non-zero is sufficient.
I have poorly worded. I meant that err < 0 specifically checks for error code regardless of function you are checking (in most cases) and you don't have to check if the original function documentation. But if (err) is fine by me as well.
Quoted 4 lines
Thanks.
--
Dmitry
Re: [PATCH v4 2/2] Input: isa1200 - new driver for Imagis ISA1200
In reply to Dmitry Torokhovчт, 7 трав. 2026 р. о 22:26 Dmitry Torokhov <[email protected]> пише:
Quoted 624 lines
Hi Svyatoslav,
Quoted 124 lines · Svyatoslav Ryhel
From: Linus Walleij <[email protected]>
The ISA1200 is a haptic feedback unit from Imagis Technology using two motors for haptic feedback in mobile phones. Used in many mobile devices c. 2012 including Samsung Galxy S Advance GT-I9070 (Janice), Samsung Beam GT-I8350 (Gavini), LG Optimus 4X P880 and LG Optimus Vu P895.
The exact datasheet for the ISA1200 is not available; all data was modeled based on available downstream kernel sources for various devices and fragments of information scattered across the internet.
Signed-off-by Linus Walleij <[email protected]>Co-developed-by Svyatoslav Ryhel <[email protected]>Signed-off-by Svyatoslav Ryhel <[email protected]>--- drivers/input/misc/Kconfig | 12 + drivers/input/misc/Makefile | 1 + drivers/input/misc/isa1200.c | 540 +++++++++++++++++++++++++++++++++++ 3 files changed, 553 insertions(+) create mode 100644 drivers/input/misc/isa1200.cdrivers/input/misc/Kconfig +12
-0@@ -852,6 +852,18 @@ config INPUT_IQS7222 To compile this driver as a module, choose M here: the module will be called iqs7222. +config INPUT_ISA1200_HAPTIC + tristate "Imagis ISA1200 haptic feedback unit" + depends on I2C + select INPUT_FF_MEMLESS + select REGMAP_I2C + help + Say Y to enable support for the Imagis ISA1200 haptic + feedback unit. + + To compile this driver as a module, choose M here: the + module will be called isa1200. + config INPUT_CMA3000 tristate "VTI CMA3000 Tri-axis accelerometer" helpdrivers/input/misc/Makefile +1
-0@@ -49,6 +49,7 @@ obj-$(CONFIG_INPUT_IMS_PCU) += ims-pcu.o obj-$(CONFIG_INPUT_IQS269A) += iqs269a.o obj-$(CONFIG_INPUT_IQS626A) += iqs626a.o obj-$(CONFIG_INPUT_IQS7222) += iqs7222.o +obj-$(CONFIG_INPUT_ISA1200_HAPTIC) += isa1200.o obj-$(CONFIG_INPUT_KEYSPAN_REMOTE) += keyspan_remote.o obj-$(CONFIG_INPUT_KXTJ9) += kxtj9.o obj-$(CONFIG_INPUT_M68K_BEEP) += m68kspkr.odrivers/input/misc/isa1200.c new file +61
-0@@ -0,0 +1,540 @@ +// SPDX-License-Identifier: GPL-2.0+ + +#include <linux/array_size.h> +#include <linux/bitmap.h> +#include <linux/bits.h> +#include <linux/clk.h> +#include <linux/delay.h> +#include <linux/device.h> +#include <linux/devm-helpers.h> +#include <linux/err.h> +#include <linux/gpio/consumer.h> +#include <linux/i2c.h> +#include <linux/input.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/property.h> +#include <linux/pwm.h> +#include <linux/regmap.h> +#include <linux/regulator/consumer.h> +#include <linux/units.h> + +/* +* System control (LDO regulator) +* +* LDO voltage to register mapping is linear, but it is split in two parts: +* 2.3V - 3.0V map to 0x08 - 0x0f; 3.1V - 3.8V map to 0x00 - 0x7 +*/ + +#define ISA1200_SCTRL 0x00 +#define ISA1200_LDO_VOLTAGE_BASE 0x08 +#define ISA1200_LDO_VOLTAGE_STEP 100000 +#define ISA1200_LDO_VOLTAGE_2V3 23 +#define ISA1200_LDO_VOLTAGE_3V1 31 +#define ISA1200_LDO_VOLTAGE_MIN 2300000 +#define ISA1200_LDO_VOLTAGE_MAX 3800000 + +/* +* The output frequency is calculated with this formula: +* +* base clock frequency +* fout = ----------------------------------------- +* (128 - PWM_FREQ) * 2 * PLLDIV * PWM_PERIOD +* +* The base clock frequency is the clock frequency provided on the +* clock input to the chip, divided by the value in HCTRL0 +* +* PWM_FREQ is configured in register HCTRL4, it is common to set this +* to 0 to get only two variables to calculate. +* +* PLLDIV is configured in register HCTRL3 (bits 7..4, so 0..15) +* PWM_PERIOD is configured in register HCTRL6 +* Further the duty cycle can be configured in HCTRL5 +*/ + +/* +* HCTRL0 configures clock or PWM input and selects the divider for +* the clock input. +*/ +#define ISA1200_HCTRL0 0x30 +#define ISA1200_HCTRL0_HAP_ENABLE BIT(7) +#define ISA1200_HCTRL0_PWM_GEN_MODE BIT(4)drivers/input/misc/isa1200.c line 71
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+#define ISA1200_HCTRL0_PWM_INPUT_MODE BIT(3) +#define ISA1200_HCTRL0_CLKDIV_128 128 + +/* +* HCTRL1 configures the motor type and clock sourse +*/ +#define ISA1200_HCTRL1 0x31 +#define ISA1200_HCTRL1_EXT_CLOCK BIT(7) +#define ISA1200_HCTRL1_DAC_INVERT BIT(6) +#define ISA1200_HCTRL1_MODE (n) (((n) & 1) << 5)I wonder if this should simply be BIT(5) and you conditionally use it in the code. The macro is not really usable to disable the setting...
Quoted 49 lines
drivers/input/misc/isa1200.c new file +49
-0+ +/* HCTRL2 controls software reset of the chip */ +#define ISA1200_HCTRL2 0x32 +#define ISA1200_HCTRL2_SW_RESET BIT(0) + +/* +* HCTRL3 controls the PLL divisor +* +* Bits [0,1] are always set to 1 (we don't know what they are +* used for) and bit 4 and upward control the PLL divisor. +*/ +#define ISA1200_HCTRL3 0x33 +#define ISA1200_HCTRL3_DEFAULT 0x03 +#define ISA1200_HCTRL3_PLLDIV (n) (((n) & 0xf) << 4) + +/* HCTRL4 controls the PWM frequency of external channel */ +#define ISA1200_HCTRL4 0x34 + +/* HCTRL5 controls the PWM high duty cycle of internal channel */ +#define ISA1200_HCTRL5 0x35 + +/* HCTRL6 controls the PWM period of internal channel */ +#define ISA1200_HCTRL6 0x36 +#define ISA1200_HCTRL6_PERIOD_SCALE 100 + +/* The use for these registers is unknown but they exist */ +#define ISA1200_HCTRL7 0x37 +#define ISA1200_HCTRL8 0x38 +#define ISA1200_HCTRL9 0x39 +#define ISA1200_HCTRLA 0x3a +#define ISA1200_HCTRLB 0x3b +#define ISA1200_HCTRLC 0x3c +#define ISA1200_HCTRLD 0x3d + +#define ISA1200_EN_PINS_MAX 2 + +struct isa1200_config { +u32 ldo_voltage; +u32 mode; +u32 clkdiv; +u32 plldiv; +u32 freq; +u32 period; +u32 duty; +}; + +struct isa1200 { +struct input_dev *input; +struct regmap *map;drivers/input/misc/isa1200.c line 130
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+ +struct clk *clk; +struct pwm_device *pwm; +struct gpio_descs *enable_gpios; + +struct work_struct play_work; +struct isa1200_config config; + +int level; +bool clk_on;I think you need not only
clk_on, but general "active" flag that you would set at the end ofisa1200_start().Quoted 5 lines
drivers/input/misc/isa1200.c new file +5
-0+}; + +static const struct regmap_config isa1200_regmap_config = { + .reg_bits =8 , + .val_bits =8 ,drivers/input/misc/isa1200.c line 145
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+ .max_register = ISA1200_HCTRLD, +}; + +static void isa1200_start (struct isa1200 *isa) +{ +struct isa1200_config *config = &isa->config; +struct pwm_state state; +u8 hctrl0 =0 , hctrl1 =0 ; +DECLARE_BITMAP (values,ISA1200_EN_PINS_MAX ); +int ret;Please use "error" or "err" for all variables that only hold error codes (or 0) instead of a real value that is used for something.
drivers/input/misc/isa1200.c line 148
Quoted 3 lines
drivers/input/misc/isa1200.c new file +3
-0+ +if (!isa->clk_on) { + ret =clk_prepare_enable (isa->clk);This return 0 on success so
if (error) return;Quoted 85 lines
drivers/input/misc/isa1200.c new file +85
-0+if (ret <0 ) +return ; + + isa->clk_on = true; + } + +bitmap_fill (values,ISA1200_EN_PINS_MAX ); +gpiod_multi_set_value_cansleep (isa->enable_gpios, values); + +usleep_range (200 ,300 ); + +regmap_write (isa->map,ISA1200_SCTRL , config->ldo_voltage); + +if (isa->clk) { + hctrl0 =ISA1200_HCTRL0_PWM_GEN_MODE ; + hctrl1 =ISA1200_HCTRL1_EXT_CLOCK ; + } + +if (isa->pwm) { + hctrl0 =ISA1200_HCTRL0_PWM_INPUT_MODE ; + hctrl1 =0 ; + } + + hctrl0 |=__ffs (config->clkdiv /ISA1200_HCTRL0_CLKDIV_128 ); + hctrl1 |=ISA1200_HCTRL1_DAC_INVERT ; + hctrl1 |=ISA1200_HCTRL1_MODE (config->mode); + +regmap_write (isa->map,ISA1200_HCTRL0 , hctrl0); +regmap_write (isa->map,ISA1200_HCTRL1 , hctrl1); + +/* Make sure to de-assert software reset */ +regmap_write (isa->map,ISA1200_HCTRL2 ,0x00 ); + +/* PLL divisor */ +regmap_write (isa->map,ISA1200_HCTRL3 , +ISA1200_HCTRL3_PLLDIV (config->plldiv) | +ISA1200_HCTRL3_DEFAULT ); + +/* Frequency */ +regmap_write (isa->map,ISA1200_HCTRL4 , config->freq); +/* Duty cycle */ +regmap_write (isa->map,ISA1200_HCTRL5 , config->period >>1 ); +/* Period */ +regmap_write (isa->map,ISA1200_HCTRL6 , config->period); + + hctrl0 |=ISA1200_HCTRL0_HAP_ENABLE ; +regmap_write (isa->map,ISA1200_HCTRL0 , hctrl0); + +if (isa->clk) +regmap_write (isa->map,ISA1200_HCTRL5 , config->duty); + +if (isa->pwm) { +pwm_get_state (isa->pwm, &state); + state.duty_cycle = config->duty; + state.enabled = true; +pwm_apply_might_sleep (isa->pwm, &state); + } +} + +static void isa1200_power_off (void *data) +{ +struct isa1200 *isa = data; + +DECLARE_BITMAP (values,ISA1200_EN_PINS_MAX ); + +bitmap_zero (values,ISA1200_EN_PINS_MAX ); +gpiod_multi_set_value_cansleep (isa->enable_gpios, values); + +if (isa->clk_on) { +clk_disable_unprepare (isa->clk); + isa->clk_on = false; + } +} + +static void isa1200_stop (struct isa1200 *isa) +{ +struct pwm_state state; + +if (isa->pwm) { +pwm_get_state (isa->pwm, &state); + state.duty_cycle =0 ; + state.enabled = false; +pwm_apply_might_sleep (isa->pwm, &state); + } +drivers/input/misc/isa1200.c line 243
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+regmap_write (isa->map,ISA1200_HCTRL0 ,0x00 ); +isa1200_power_off (isa); +} + +static void isa1200_play_work (struct work_struct *work) +{ +struct isa1200 *isa = + container_of(work, struct isa1200, play_work); + +guard (mutex)(&isa->input->mutex);I think this mutex is dangerous here. You really want to stop/cancel work in
suspend()andclose()instead of blocking on the mutex and then continuing.Quoted 30 lines
drivers/input/misc/isa1200.c new file +30
-0+ +if (isa->level) +isa1200_start (isa); +else +isa1200_stop (isa); +} + +static int isa1200_vibrator_play_effect (struct input_dev *input,void *data, +struct ff_effect *effect) +{ +struct isa1200 *isa =input_get_drvdata (input); +int level; + +/* +* TODO: we currently only support rumble. +* The ISA1200 can control two motors and some devices +* also have two motors mounted. +*/ + level = effect->u.rumble.strong_magnitude; +if (!level) + level = effect->u.rumble.weak_magnitude; + +dev_dbg (&input->dev,"FF effect type %d level %d\n" , + effect->type, level); + +if (isa->level != level) { + isa->level = level; +schedule_work (&isa->play_work); + } +drivers/input/misc/isa1200.c line 283
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+return 0 ; +} + +static void isa1200_vibrator_close (struct input_dev *input) +{ +struct isa1200 *isa =input_get_drvdata (input); + +cancel_work_sync (&isa->play_work); + +if (isa->level)So here I think you need to check that "active" flag that would represent the committed state.
Quoted 159 lines
drivers/input/misc/isa1200.c new file +159
-0+isa1200_stop (isa); + + isa->level =0 ; +} + +static int isa1200_of_probe (struct i2c_client *client) +{ +static const char *const isa1200_supplies[] = {"vdd" ,"vddp" }; +struct isa1200 *isa =i2c_get_clientdata (client); +struct isa1200_config *config = &isa->config; +struct device *dev = &client->dev; +struct fwnode_handle *ldo_node; +int ret; + + isa->clk =devm_clk_get_optional (dev,NULL ); +if (IS_ERR (isa->clk)) +return dev_err_probe (dev,PTR_ERR (isa->clk), +"failed to get clock\n" ); + + isa->pwm =devm_pwm_get (dev,NULL ); +if (IS_ERR (isa->pwm)) { + ret =PTR_ERR (isa->pwm); +if (ret == -ENODEV || ret == -EINVAL ) + isa->pwm =NULL ; +else +return dev_err_probe (dev, ret,"getting PWM\n" ); + } + +if (!isa->clk && !isa->pwm) +return dev_err_probe (dev, -EINVAL , +"clock or PWM are required, none were provided\n" ); + + ret =devm_regulator_bulk_get_enable (dev,ARRAY_SIZE (isa1200_supplies), + isa1200_supplies); +if (ret) +return dev_err_probe (dev, ret,"failed to set up supplies\n" ); + + isa->enable_gpios =devm_gpiod_get_array_optional (dev,"control" , +GPIOD_OUT_LOW ); +if (IS_ERR (isa->enable_gpios)) +return dev_err_probe (dev,PTR_ERR (isa->enable_gpios), +"failed to get enable gpios\n" ); + + ldo_node =device_get_named_child_node (dev,"ldo" ); +if (!ldo_node) +return dev_err_probe (dev, -ENODEV , +"failed to get embedded LDO node\n" ); + + ret =fwnode_property_read_u32 (ldo_node,"regulator-min-microvolt" , + &config->ldo_voltage); +fwnode_handle_put (ldo_node); +if (ret) +return dev_err_probe (dev, ret, +"failed to get ldo voltage\n" ); + + config->ldo_voltage =clamp (config->ldo_voltage, +ISA1200_LDO_VOLTAGE_MIN , +ISA1200_LDO_VOLTAGE_MAX ); + + config->ldo_voltage /=ISA1200_LDO_VOLTAGE_STEP ; +if (config->ldo_voltage <ISA1200_LDO_VOLTAGE_3V1 ) + config->ldo_voltage = config->ldo_voltage - +ISA1200_LDO_VOLTAGE_2V3 + +ISA1200_LDO_VOLTAGE_BASE ; +else + config->ldo_voltage -=ISA1200_LDO_VOLTAGE_3V1 ; + + config->mode =0 ;/* LRA_MODE */ +device_property_read_u32 (dev,"imagis,mode" , &config->mode); + + config->clkdiv =ISA1200_HCTRL0_CLKDIV_128 ; +device_property_read_u32 (dev,"imagis,clk-div" , &config->clkdiv); +if (!config->clkdiv) +return dev_err_probe (dev, -EINVAL ,"clk-div cannot be zero\n" ); + + config->clkdiv =clamp (config->clkdiv,ISA1200_HCTRL0_CLKDIV_128 , +ISA1200_HCTRL0_CLKDIV_128 <<3 ); + + ret =device_property_read_u32 (dev,"imagis,pll-div" , &config->plldiv); +if (ret <0 || !config->plldiv) + config->plldiv =1 ; + + config->period =0 ; + config->freq =0 ; + config->duty =0 ; + +if (isa->clk) { + ret =device_property_read_u32 (dev,"imagis,period-ns" , + &config->period); +if (ret) +return dev_err_probe (dev, ret, +"failed to get period\n" ); + +/* +* TODO: The scale value is arbitrary, but it fits observations +* quite well, and the exact conversion method is unknown. +* The period property value returned above is the HCTRL6 +* register value set by the vendor code, multiplied by 100. +*/ + config->period /=ISA1200_HCTRL6_PERIOD_SCALE ; + config->duty = config->period >>1 ; + } + +if (isa->pwm) { +struct pwm_state state; + +pwm_init_state (isa->pwm, &state); + +if (!state.period) +return dev_err_probe (dev, -EINVAL , +"PWM period cannot be zero\n" ); + + config->freq =div64_u64 (NANO , state.period * config->clkdiv); + config->duty = state.period >>1 ; + + ret =pwm_apply_might_sleep (isa->pwm, &state); +if (ret) +return dev_err_probe (dev, ret, +"failed to apply initial PWM state\n" ); + } + +/* +* TODO: If device is using a clock, this property should return the +* value written to the HCTRL5 register by downstrem code. It likely +* needs to be converted into a meaningful duty cycle value, though +* unfortunately the exact conversion mechanism is unknown. If the +* device uses PWM, this property will return the correct duty cycle +* in nanoseconds. +*/ +device_property_read_u32 (dev,"imagis,duty-cycle-ns" , &config->duty); + +return 0 ; +} + +static int isa1200_probe (struct i2c_client *client) +{ +struct isa1200 *isa; +struct device *dev = &client->dev; +DECLARE_BITMAP (values,ISA1200_EN_PINS_MAX ); +u32 val; +int ret; + + isa =devm_kzalloc (dev,sizeof (*isa),GFP_KERNEL ); +if (!isa) +return -ENOMEM ; + + isa->input =devm_input_allocate_device (dev); +if (!isa->input) +return -ENOMEM ; + +i2c_set_clientdata (client, isa); + + ret =isa1200_of_probe (client); +if (ret) +return ret; + + isa->map =devm_regmap_init_i2c (client, &isa1200_regmap_config); +if (IS_ERR (isa->map)) + return dev_err_probe(dev, PTR_ERR(isa->map),drivers/input/misc/isa1200.c line 452
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+ "failed to initialize register map\n"); + + ret =clk_prepare_enable (isa->clk); +if (ret <0 ) +return dev_err_probe (dev, ret,"failed to enable clock\n" ); + + isa->clk_on = true; + +bitmap_fill (values,ISA1200_EN_PINS_MAX ); +gpiod_multi_set_value_cansleep (isa->enable_gpios, values);You should factor our
isa1200_power_on()fromisa1200_start()and use it here.drivers/input/misc/isa1200.c line 456
Quoted 4 lines
drivers/input/misc/isa1200.c new file +4
-0+ + ret =devm_add_action_or_reset (dev, isa1200_power_off, isa); +if (ret) +return ret;
close()is taking care of powering off the device.drivers/input/misc/isa1200.c line 463
Quoted 7 lines
drivers/input/misc/isa1200.c new file +7
-0+ +usleep_range (200 ,300 ); + +/* Read a register so we know that regmap and I2C transport works */ + ret =regmap_read (isa->map,ISA1200_SCTRL , &val); +if (ret) +return dev_err_probe (dev, ret,"failed to read SCTRL\n" );You should call
isa1200_power_off()here. You do not know when the first effect will play. In the meantime the device should be in low power state.drivers/input/misc/isa1200.c line 467
Quoted 4 lines
drivers/input/misc/isa1200.c new file +4
-0+ + ret =devm_work_autocancel (dev, &isa->play_work, isa1200_play_work); +if (ret) +return dev_err_probe (dev, ret,"failed to init work\n" );I do not think you need it here. You supply
input->close()and that should take care of stopping/canceling the work. Input core guarantees to callclose()if the device is "open" whne unregistering.drivers/input/misc/isa1200.c line 470
Quoted 3 lines
drivers/input/misc/isa1200.c new file +3
-0+ + isa->input->name ="isa1200-haptic" ; + isa->input->id.bustype =BUS_HOST ;Not
BUS_I2C?drivers/input/misc/isa1200.c line 471
Quoted 1 line
drivers/input/misc/isa1200.c new file +1
-0+ isa->input->dev.parent = dev;Parent is already set by
devm_input_allocate_device().drivers/input/misc/isa1200.c line 482
Quoted 11 lines
drivers/input/misc/isa1200.c new file +11
-0+ isa->input->close = isa1200_vibrator_close; + +input_set_drvdata (isa->input, isa); + +/* TODO: this hardware can likely support more than rumble */ +input_set_capability (isa->input,EV_FF ,FF_RUMBLE ); + + ret =input_ff_create_memless (isa->input,NULL , + isa1200_vibrator_play_effect); +if (ret) +return dev_err_probe (dev, ret,"couldn't create FF dev\n" );"failed ..."
drivers/input/misc/isa1200.c line 486
Quoted 4 lines
drivers/input/misc/isa1200.c new file +4
-0+ + ret =input_register_device (isa->input); +if (ret) +return dev_err_probe (dev, ret,"couldn't register input dev\n" );"failed ..."
drivers/input/misc/isa1200.c line 488
Quoted 2 lines
drivers/input/misc/isa1200.c new file +2
-0+ +return ret;return 0;drivers/input/misc/isa1200.c line 495
Quoted 7 lines
drivers/input/misc/isa1200.c new file +7
-0+} + +static int isa1200_suspend (struct device *dev) +{ +struct isa1200 *isa =dev_get_drvdata (dev); + +cancel_work_sync (&isa->play_work);Move it under
input_device_enabled().
Quoted 3 lines
drivers/input/misc/isa1200.c line 244
Quoted 3 lines
drivers/input/misc/isa1200.c new file +3
-0+ +guard (mutex)(&isa->input->mutex); +
Should I remove mutex locking from both PM functions?
Quoted 47 lines
Quoted 32 lines
drivers/input/misc/isa1200.c new file +32
-0+if (input_device_enabled (isa->input)) +if (isa->level) +isa1200_stop (isa); + +return 0 ; +} + +static int isa1200_resume (struct device *dev) +{ +struct isa1200 *isa =dev_get_drvdata (dev); + +guard (mutex)(&isa->input->mutex); + +if (input_device_enabled (isa->input)) +if (isa->level) +isa1200_start (isa); + +return 0 ; +} + +static DEFINE_SIMPLE_DEV_PM_OPS(isa1200_pm_ops, isa1200_suspend, isa1200_resume); + +static const struct of_device_id isa1200_of_match[] = { + { .compatible ="imagis,isa1200" }, + {/* sentinel */ } +}; +MODULE_DEVICE_TABLE (of, isa1200_of_match); + +static struct i2c_driver isa1200_i2c_driver = { + .driver = { + .name ="isa1200" , + .of_match_table = isa1200_of_match,drivers/input/misc/isa1200.c line 540
Quoted 10 lines
drivers/input/misc/isa1200.c new file +10
-0+ .pm = pm_sleep_ptr(&isa1200_pm_ops), + }, + .probe = isa1200_probe, +}; +module_i2c_driver (isa1200_i2c_driver); + +MODULE_AUTHOR ("Linus Walleij <[email protected]>" ); +MODULE_AUTHOR ("Svyatoslav Ryhel <[email protected]>" ); +MODULE_DESCRIPTION ("Imagis ISA1200 haptic feedback unit" ); +MODULE_LICENSE ("GPL" );Thanks.
--
Dmitry
Dmitry Torokhov
maintainerRe: [PATCH v4 2/2] Input: isa1200 - new driver for Imagis ISA1200
Quoted 5 lines · Svyatoslav Ryhel
чт, 7 трав. 2026 р. о 22:26 Dmitry Torokhov <[email protected]> пише:
Quoted 4 lines
Hi Svyatoslav,
On Thu, May 07, 2026 at 04:39:48PM +0300, Svyatoslav Ryhel wrote:
...
Quoted 10 lines
Quoted 10 lines
drivers/input/misc/isa1200.c line 495
Quoted 7 lines
drivers/input/misc/isa1200.c new file +7
-0+} + +static int isa1200_suspend (struct device *dev) +{ +struct isa1200 *isa =dev_get_drvdata (dev); + +cancel_work_sync (&isa->play_work);Move it under
input_device_enabled().
Quoted 5 lines
Quoted 3 lines
drivers/input/misc/isa1200.c line 244
Quoted 3 lines
drivers/input/misc/isa1200.c new file +3
-0+ +guard (mutex)(&isa->input->mutex); +Should I remove mutex locking from both PM functions?
No, you should remove it from isa1200_play_work().
Thanks.
Signature · 1 line
Dmitry