Skip to contentSkip to conversation

arm64: dts: agilex5: add support for debug daughter card

PATCH Applied Adrian Ng Ho Yin 5 participants 10 messages May 8 – May 14 Device tree bindings

v1 of 3 Applied Latest is v3 →

lore
Share & tools
lore

Adrian Ng Ho Yin

author
#0 lore raw

cover arm64: dts: agilex5: add support for debug daughter card

The Agilex5 SoCDK supports an optional debug daughter card that requires a dedicated device tree variant due to differences in peripheral connectivity compared to the standard SoCDK configuration.

When the debug daughter card is fitted:
- gpio0 and gmac2 are disabled
- gmac0 is enabled with RGMII PHY connectivity
- spi0 is enabled with a <device> peripheral at chip select 0
- The HPS LED is rewired from gpio0/porta to gpio1/portb

The new DTS inherits from socfpga_agilex5_socdk.dts and overrides only the nodes that differ, keeping the delta minimal.

Adrian Ng Ho Yin (2):
dt-bindings: altera: add compatible for agilex5 socdk debug daughter
card
arm64: dts: agilex5: add support for debug daughter card

 .../devicetree/bindings/arm/altera.yaml       |  1 +
 arch/arm64/boot/dts/intel/Makefile            |  1 +
 .../dts/intel/socfpga_agilex5_socdk_debug.dts | 50 +++++++++++++++++++
 3 files changed, 52 insertions(+)
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts
Signature · 1 line
2.49.GIT
author
#1 lore raw

PATCH 1/2 dt-bindings: altera: add compatible for agilex5 socdk debug daughter card

Agilex5 devkit supports a debug daughter card that inherits the configurations from socdk but disables gpio0 and gmac2 and enables gmac0 and spi0.

Signed-off-by Adrian Ng Ho Yin <[email protected]>
---
 Documentation/devicetree/bindings/arm/altera.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/altera.yaml +1 -0
index 06513895a159..c17e3bf2b077 100644
@@ -111,6 +111,7 @@ properties:
           - enum:
               - intel,socfpga-agilex5-socdk
               - intel,socfpga-agilex5-socdk-013b
+              - intel,socfpga-agilex5-socdk-debug
               - intel,socfpga-agilex5-socdk-modular
               - intel,socfpga-agilex5-socdk-nand
           - const: intel,socfpga-agilex5
Signature · 1 line
2.49.GIT
author
#3 lore raw

PATCH 2/2 arm64: dts: agilex5: add support for debug daughter card

In reply to Adrian Ng Ho Yin

Add a new dts for the Agilex 5 SoCDK when fitted with the debug daughter card where several peripherals such as gpio0 and gmac2 are disabled while gmac0 and spi0 are enabled hence requiring a separate device tree.

Signed-off-by Niravkumar L Rabara <[email protected]>
Signed-off-by Adrian Ng Ho Yin <[email protected]>
---
 arch/arm64/boot/dts/intel/Makefile            |  1 +
 .../dts/intel/socfpga_agilex5_socdk_debug.dts | 50 +++++++++++++++++++
 2 files changed, 51 insertions(+)
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts
arch/arm64/boot/dts/intel/Makefile +1 -0
index 088a03b89c99..84982bf13ee5 100644
@@ -6,6 +6,7 @@ dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_agilex_n6000.dtb \
 				socfpga_agilex3_socdk.dtb \
 				socfpga_agilex5_socdk.dtb \
 				socfpga_agilex5_socdk_013b.dtb \
+				socfpga_agilex5_socdk_debug.dtb \
 				socfpga_agilex5_socdk_modular.dtb \
 				socfpga_agilex5_socdk_nand.dtb \
 				socfpga_agilex7m_socdk.dtb \
arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts new file +50 -0

50 lines not on this page · raw message

Signature · 1 line
2.49.GIT
AI review
#4 lore raw
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Low] Abuse of the 'rohm,dh2228fv' compatible string to force the 'spidev' driver to bind. - [Low]…

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Abuse of the 'rohm,dh2228fv' compatible string to force the 'spidev' driver to bind.
- [Low] Including a '.dts' file directly instead of using a '.dtsi' include file. --

commit 3916af69e58bdb9bf4d736172238dd0b03e9465b
Author: Adrian Ng Ho Yin <[email protected]>

arm64: dts: agilex5: add support for debug daughter card

This commit adds a new device tree for the Agilex 5 SoCDK when fitted with the debug daughter card. It disables several peripherals such as gpio0 and gmac2 while enabling gmac0 and spi0 for debugging purposes.

arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts line 5

Quoted 11 lines
arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts new file +5 -0
new file mode 100644
index 0000000000000..3981a9e876b0a
@@ -0,0 +1,50 @@
+// SPDX-License-Identifier:     GPL-2.0
+/*
+ * Copyright (C) 2026, Altera Corporation
+ */
+#include "socfpga_agilex5_socdk.dts"

This isn't a bug, but does this include a final board .dts file instead of a shared .dtsi include?

Standard Device Tree conventions typically involve refactoring shared configurations into a common .dtsi file, as .dts files are meant to be the final top-level compilation unit for a board.

[ ... ]

arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts line 46

Quoted 4 lines
arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts new file +4 -0
+&spi0 {
+	status = "okay";
+	spidev@0 {
+		compatible = "rohm,dh2228fv";

Is there actually a Rohm DH2228FV hardware device present on this debug daughter card?

The commit message indicates this exposes the SPI interface for debugging. Does this code use the 'rohm,dh2228fv' compatible string solely to force the Linux spidev driver to bind?

The Device Tree is meant for describing hardware, and using fake hardware compatible strings to instantiate userspace interfaces bypasses the kernel warnings against using a bare 'spidev' compatible string.

Quoted 4 lines
arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts new file +4 -0
+		reg = <0>;
+		spi-max-frequency = <10000000>;
+	};
+};
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
#5 lore raw
Quoted 43 lines · On 08/05/2026 22:42, [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Abuse of the 'rohm,dh2228fv' compatible string to force the 'spidev' driver to bind.
- [Low] Including a '.dts' file directly instead of using a '.dtsi' include file. --

commit 3916af69e58bdb9bf4d736172238dd0b03e9465b
Author: Adrian Ng Ho Yin <[email protected]>

arm64: dts: agilex5: add support for debug daughter card

This commit adds a new device tree for the Agilex 5 SoCDK when fitted with the debug daughter card. It disables several peripherals such as gpio0 and gmac2 while enabling gmac0 and spi0 for debugging purposes.

arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts line 5

Quoted 11 lines
arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts new file +5 -0
new file mode 100644
index 0000000000000..3981a9e876b0a
@@ -0,0 +1,50 @@
+// SPDX-License-Identifier:     GPL-2.0
+/*
+ * Copyright (C) 2026, Altera Corporation
+ */
+#include "socfpga_agilex5_socdk.dts"

This isn't a bug, but does this include a final board .dts file instead of a shared .dtsi include?

Standard Device Tree conventions typically involve refactoring shared configurations into a common .dtsi file, as .dts files are meant to be the final top-level compilation unit for a board.

[ ... ]

arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts line 46

Quoted 4 lines
arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts new file +4 -0
+&spi0 {
+	status = "okay";
+	spidev@0 {
+		compatible = "rohm,dh2228fv";

Is there actually a Rohm DH2228FV hardware device present on this debug daughter card?

Quoted 3 lines

The commit message indicates this exposes the SPI interface for debugging. Does this code use the 'rohm,dh2228fv' compatible string solely to force the Linux spidev driver to bind?

Why did you completely ignore the review?

Best regards,
Krzysztof

NAK
#6 lore raw
In reply to Adrian Ng Ho Yin

arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts line 46

Quoted 6 lines · Adrian Ng Ho Yin
arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts new file +6 -0
+};
+
+&spi0 {
+	status = "okay";
+	spidev@0 {
+		compatible = "rohm,dh2228fv";

NAK, don't fake devices.

arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts line 50

Quoted 4 lines
arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts new file +4 -0
+		reg = <0>;
+		spi-max-frequency = <10000000>;
+	};
+};

Best regards,
Krzysztof

Applied
#7 lore raw
In reply to Adrian Ng Ho Yin
Quoted 10 lines · Adrian Ng Ho Yin

The Agilex5 SoCDK supports an optional debug daughter card that requires a dedicated device tree variant due to differences in peripheral connectivity compared to the standard SoCDK configuration.

When the debug daughter card is fitted:
- gpio0 and gmac2 are disabled
- gmac0 is enabled with RGMII PHY connectivity
- spi0 is enabled with a <device> peripheral at chip select 0
- The HPS LED is rewired from gpio0/porta to gpio1/portb

Quoted 8 lines

The new DTS inherits from socfpga_agilex5_socdk.dts and overrides only the nodes that differ, keeping the delta minimal.

Adrian Ng Ho Yin (2):
dt-bindings: altera: add compatible for agilex5 socdk debug daughter
card
arm64: dts: agilex5: add support for debug daughter card

Applied!

Thanks,
Dinh

#8 lore raw
Quoted 16 lines · Dinh Nguyen
Quoted 13 lines · Adrian Ng Ho Yin

The Agilex5 SoCDK supports an optional debug daughter card that requires a dedicated device tree variant due to differences in peripheral connectivity compared to the standard SoCDK configuration.

When the debug daughter card is fitted:
- gpio0 and gmac2 are disabled
- gmac0 is enabled with RGMII PHY connectivity
- spi0 is enabled with a <device> peripheral at chip select 0
- The HPS LED is rewired from gpio0/porta to gpio1/portb

The new DTS inherits from socfpga_agilex5_socdk.dts and overrides only the nodes that differ, keeping the delta minimal.

Quoted 7 lines
Quoted 5 lines

Adrian Ng Ho Yin (2):
dt-bindings: altera: add compatible for agilex5 socdk debug daughter
card
arm64: dts: agilex5: add support for debug daughter card

Applied!

No, really. This is really unreviewed poor DTS containing fake nodes. Please drop the patch.

Best regards,
Krzysztof

#9 lore raw
Quoted 23 lines · Krzysztof Kozlowski
Quoted 22 lines · Dinh Nguyen
Quoted 18 lines · Adrian Ng Ho Yin

The Agilex5 SoCDK supports an optional debug daughter card that requires a dedicated device tree variant due to differences in peripheral connectivity compared to the standard SoCDK configuration.

When the debug daughter card is fitted:
- gpio0 and gmac2 are disabled
- gmac0 is enabled with RGMII PHY connectivity
- spi0 is enabled with a <device> peripheral at chip select 0
- The HPS LED is rewired from gpio0/porta to gpio1/portb

The new DTS inherits from socfpga_agilex5_socdk.dts and overrides only the nodes that differ, keeping the delta minimal.

Adrian Ng Ho Yin (2):
dt-bindings: altera: add compatible for agilex5 socdk debug daughter
card
arm64: dts: agilex5: add support for debug daughter card

Quoted 5 lines
Quoted 1 line

Applied!

No, really. This is really unreviewed poor DTS containing fake nodes. Please drop the patch.

[2/2] arm64: dts: agilex5: add support for debug daughter card - Dropped

Please resubmit.

Dinh