Skip to contentSkip to conversation

MAINTAINERS: Add Aksh Garg as PCI CADENCE reviewer

PATCH Applied Aksh Garg 5 participants 6 messages May 8 – May 11 PCI

lore
Share & tools
lore

Aksh Garg

author
#0 lore raw

PATCH 1/1 MAINTAINERS: Add Aksh Garg as PCI CADENCE reviewer

I wish to contribute to the review process for Cadence PCIe IP drivers, hence add myself as a reviewer.

---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -1
index 2fb1c75afd16..e2c188a358ed 100644
@@ -20315,10 +20315,11 @@ F:	Documentation/devicetree/bindings/pci/marvell,armada8k-pcie.yaml
 F:	drivers/pci/controller/dwc/pcie-armada8k.c
 
 PCI DRIVER FOR CADENCE PCIE IP
+R:	Aksh Garg <[email protected]>
 L:	[email protected]
 S:	Orphan
 F:	Documentation/devicetree/bindings/pci/cdns,*
-F:	drivers/pci/controller/cadence/*cadence*
+F:	drivers/pci/controller/cadence/
 
 PCI DRIVER FOR CIX Sky1
 M:	Hans Zhang <[email protected]>
Signature · 1 line
2.34.1
#1 lore raw

Hi Aksh,

Let's wait for one day, or two days, to see if Vignesh is willing to do it.

For drivers/pci/controller/cadence, currently Aksh and Siddharth hope to become Reviewers. Manikandan believes that he can become a Maintainer. I myself also hope to apply for the role of maintainer. Then let's review the common driver related to Cadence PCIe IP, as well as the driver of the product.

Siddharth:
Depending on the frequency with which we are able to Review patches consistently, we could eventually take up the role of being a Maintainer as well.

Best regards,
Hans

Quoted 25 lines · Aksh Garg

I wish to contribute to the review process for Cadence PCIe IP drivers, hence add myself as a reviewer.

---
  MAINTAINERS | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -1
index 2fb1c75afd16..e2c188a358ed 100644
@@ -20315,10 +20315,11 @@ F:	Documentation/devicetree/bindings/pci/marvell,armada8k-pcie.yaml
  F:	drivers/pci/controller/dwc/pcie-armada8k.c
 
  PCI DRIVER FOR CADENCE PCIE IP
+R:	Aksh Garg <[email protected]>
  L:	[email protected]
  S:	Orphan
  F:	Documentation/devicetree/bindings/pci/cdns,*
-F:	drivers/pci/controller/cadence/*cadence*
+F:	drivers/pci/controller/cadence/
 
  PCI DRIVER FOR CIX Sky1
  M:	Hans Zhang <[email protected]>
#2 lore raw
Quoted 9 lines · Hans Zhang

Hi Aksh,

Let's wait for one day, or two days, to see if Vignesh is willing to do it.

For drivers/pci/controller/cadence, currently Aksh and Siddharth hope to become Reviewers. Manikandan believes that he can become a Maintainer. I myself also hope to apply for the role of maintainer. Then let's review the common driver related to Cadence PCIe IP, as well as the driver of the product.

Siddharth:
Depending on the frequency with which we are able to Review patches consistently, we could eventually take up the role of being a Maintainer as well.

Hi Aksh,

Privately, Vignesh has replied as follows:

Vignesh:
Agreed, I would prefer if Manikandan can own the driver as he would have better visibility wrt IP documentations as part of Cadence.

Sorry, I don't have the bandwidth to own the driver. Siddharth and Aksh can help review and test on all TI platforms with Cadence PCIe IP.

Could you please add Siddharth as a Reviewer? I and Manikandan are the maintainers. Of course, we need to see if Bjorn and Mani agree. Then, send this patch in the next version.

Best regards,
Hans

Quoted 29 lines

Best regards,
Hans

Quoted 24 lines · Aksh Garg

I wish to contribute to the review process for Cadence PCIe IP drivers, hence add myself as a reviewer.

---
  MAINTAINERS | 3 ++-

  1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index 2fb1c75afd16..e2c188a358ed 100644
@@ -20315,10 +20315,11 @@ F:    Documentation/devicetree/bindings/pci/ 

marvell,armada8k-pcie.yaml
  F:    drivers/pci/controller/dwc/pcie-armada8k.c PCI DRIVER FOR CADENCE PCIE IP
+R:    Aksh Garg <[email protected]>
  L:    [email protected]
  S:    Orphan
  F:    Documentation/devicetree/bindings/pci/cdns,*

MAINTAINERS +1 -1
-F:    drivers/pci/controller/cadence/*cadence*
+F:    drivers/pci/controller/cadence/

  PCI DRIVER FOR CIX Sky1
  M:    Hans Zhang <[email protected]>

#3 lore raw
Quoted 34 lines · Hans Zhang
Quoted 10 lines · Hans Zhang

Hi Aksh,

Let's wait for one day, or two days, to see if Vignesh is willing to do it.

For drivers/pci/controller/cadence, currently Aksh and Siddharth hope to become Reviewers. Manikandan believes that he can become a Maintainer. I myself also hope to apply for the role of maintainer. Then let's review the common driver related to Cadence PCIe IP, as well as the driver of the product.

Quoted 5 lines

Siddharth:
Depending on the frequency with which we are able to Review patches consistently, we could eventually take up the role of being a Maintainer as well.

Hi Aksh,

Privately, Vignesh has replied as follows:

Vignesh:
Agreed, I would prefer if Manikandan can own the driver as he would have better visibility wrt IP documentations as part of Cadence.

Sorry, I don't have the bandwidth to own the driver. Siddharth and Aksh can help review and test on all TI platforms with Cadence PCIe IP.

Quoted 4 lines

Could you please add Siddharth as a Reviewer? I and Manikandan are the maintainers. Of course, we need to see if Bjorn and Mani agree. Then, send this patch in the next version.

$ git log --oneline --author=Manikandan drivers/pci/|wc -l
4

I wouldn't vote a developer who has committed 4 patches for a driver to become a maintainer. But considering the fact that the driver is currently in 'Orphan' state, and the developer works for the company that owns the IP, I'm OK with it.

But atleast that patch has to come from him, stating that he wishes to maintain the driver. He can add reviewers in the same patch though.

- Mani

Signature · 1 line
மணிவண்ணன் சதாசிவம்
#4 lore raw
In reply to Hans Zhang
Quoted 2 lines

For drivers/pci/controller/cadence, currently Aksh and Siddharth hope to become Reviewers. Manikandan believes that he can become a Maintainer.

Manikandan needs to also learn how to disable automatic responder, per:

"I am ooo for Diwali till 23rd October."

This is a rather long break until October. I am sure, a lot of the mailing list users already growing tired of receiving this all the time.

Thank you!

Krzysztof

#5 lore raw
In reply to Aksh Garg
Quoted 4 lines · Aksh Garg

I wish to contribute to the review process for Cadence PCIe IP drivers, hence add myself as a reviewer.

Applied to pci/for-linus for v7.1, thanks!

Quoted 24 lines
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -1
index 2fb1c75afd16..e2c188a358ed 100644
@@ -20315,10 +20315,11 @@ F:	Documentation/devicetree/bindings/pci/marvell,armada8k-pcie.yaml
 F:	drivers/pci/controller/dwc/pcie-armada8k.c
 
 PCI DRIVER FOR CADENCE PCIE IP
+R:	Aksh Garg <[email protected]>
 L:	[email protected]
 S:	Orphan
 F:	Documentation/devicetree/bindings/pci/cdns,*
-F:	drivers/pci/controller/cadence/*cadence*
+F:	drivers/pci/controller/cadence/
 
 PCI DRIVER FOR CIX Sky1
 M:	Hans Zhang <[email protected]>
Signature · 1 line
2.34.1