Skip to contentSkip to conversation

i2c: acpi: Add ELAN0678 to i2c_acpi_force_100khz_device_ids

PATCH In review Niels Franke 4 participants 6 messages Apr 18 – May 13

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: acpi: Add ELAN0678 to i2c_acpi_force_100khz_device_ids

The ELAN0678 touchpad (04F3:3195) found in the Lenovo ThinkPad X13 exhibits excessive smoothing when the I2C bus runs at 400KHz, making the touchpad feel sluggish when plugged into AC power. This is the same issue previously fixed for ELAN06FA.

The device's ACPI table (Lenovo TP-R22) specifies 0x00061A80 (400KHz) for the I2cSerialBusV2 descriptor. Forcing the bus to 100KHz eliminates the sluggish behavior.

---
 drivers/i2c/i2c-core-acpi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/i2c-core-acpi.c +1 -0
index 2cbd31f77..96d339df0 100644
@@ -372,6 +372,7 @@ static const struct acpi_device_id i2c_acpi_force_100khz_device_ids[] = {
 	 */
 	{ "DLL0945", 0 },
 	{ "ELAN06FA", 0 },
+	{ "ELAN0678", 0 },
 	{}
 };
 
Signature · 1 line
2.53.0
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Niels Franke

The ELAN0678 touchpad (04F3:3195) found in the Lenovo ThinkPad X13 exhibits excessive smoothing when the I2C bus runs at 400KHz, making the touchpad feel sluggish when plugged into AC power. This is the same issue previously fixed for ELAN06FA.

The device's ACPI table (Lenovo TP-R22) specifies 0x00061A80 (400KHz) for the I2cSerialBusV2 descriptor. Forcing the bus to 100KHz eliminates the sluggish behavior.

#2 lore raw
In reply to Niels Franke
Quoted 10 lines · Niels Franke

The ELAN0678 touchpad (04F3:3195) found in the Lenovo ThinkPad X13 exhibits excessive smoothing when the I2C bus runs at 400KHz, making the touchpad feel sluggish when plugged into AC power. This is the same issue previously fixed for ELAN06FA.

The device's ACPI table (Lenovo TP-R22) specifies 0x00061A80 (400KHz) for the I2cSerialBusV2 descriptor. Forcing the bus to 100KHz eliminates the sluggish behavior.

Kept the sorting (alphanumeric) and applied to for-current, thanks!

#3 lore raw

Hi,

I have what appears to be the same issue on a ThinkPad X13 Gen 2 with Intel i5-1145G7, but with ACPI HID ELAN0676 instead of ELAN0678.

The touchpad is:

ELAN0676:00 04F3:3195 Touchpad

libinput reports:

Id: i2c:04f3:3195

dmesg shows:

i2c_designware.0 -> i2c-ELAN0676:00 -> hid-multitouch

The ACPI table contains:

Package (0x06)
{
0x04F3,
0x3195,
0x15,
One,
One,
"ELAN0676"
}

and the surrounding firmware logic maps the fifth field to speed:

Local5 == Zero -> SPED = 0x000186A0 = 100 kHz
Local5 == One -> SPED = 0x00061A80 = 400 kHz

So this machine also configures the 04F3:3195 ELAN touchpad at 400 kHz. The symptom is very frequent rubbery/sluggish pointer movement, consistent with the excessive smoothing described for ELAN0678.

Would it make sense to include ELAN0676 in the same i2c_acpi_force_100khz_device_ids quirk?

Thanks,
Odoben

Quoted 13 lines · Wolfram Sang
Quoted 10 lines · Niels Franke

The ELAN0678 touchpad (04F3:3195) found in the Lenovo ThinkPad X13 exhibits excessive smoothing when the I2C bus runs at 400KHz, making the touchpad feel sluggish when plugged into AC power. This is the same issue previously fixed for ELAN06FA.

The device's ACPI table (Lenovo TP-R22) specifies 0x00061A80 (400KHz) for the I2cSerialBusV2 descriptor. Forcing the bus to 100KHz eliminates the sluggish behavior.

Kept the sorting (alphanumeric) and applied to for-current, thanks!

#4 lore raw

Hi,

Quoted 2 lines

I have what appears to be the same issue on a ThinkPad X13 Gen 2 with Intel i5-1145G7, but with ACPI HID ELAN0676 instead of ELAN0678.

...

Quoted 2 lines

Would it make sense to include ELAN0676 in the
same i2c_acpi_force_100khz_device_ids quirk?

Sounds much like it. Can you create such a patch? Or can you test such a patch if we provide you one?

Happy hacking,

Wolfram

#5 lore raw
In reply to Odoben

Hi,

Quoted 34 lines · Odoben

Hi,

I have what appears to be the same issue on a ThinkPad X13 Gen 2 with Intel i5-1145G7, but with ACPI HID ELAN0676 instead of ELAN0678.

The touchpad is:

ELAN0676:00 04F3:3195 Touchpad

libinput reports:

Id: i2c:04f3:3195

dmesg shows:

i2c_designware.0 -> i2c-ELAN0676:00 -> hid-multitouch

The ACPI table contains:

Package (0x06)
{
0x04F3,
0x3195,
0x15,
One,
One,
"ELAN0676"
}

and the surrounding firmware logic maps the fifth field to speed:

Local5 == Zero -> SPED = 0x000186A0 = 100 kHz
Local5 == One -> SPED = 0x00061A80 = 400 kHz

Quoted 6 lines

So this machine also configures the 04F3:3195 ELAN touchpad at 400 kHz. The symptom is very frequent rubbery/sluggish pointer movement, consistent with the excessive smoothing described for ELAN0678.

Would it make sense to include ELAN0676 in the
same i2c_acpi_force_100khz_device_ids quirk?

Did you try 100Hz and it made the problem go away? In that case yes it makes sense to add the quirk.