Skip to contentSkip to conversation

ALSA: hda/cs35l56: Drop malformed default N from Kconfig

PATCH In review Andy Shevchenko 3 participants 7 messages May 13 – May 15 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda/cs35l56: Drop malformed default N from Kconfig

First of all, it has to be 'default n' (small letter n), otherwise it looks for CONFIG_N which is absent and in case of appearance will enable something unrelated. Second and most important is that 'n' *is* the default 'default' already. Hence just drop malformed line.

---
 sound/hda/codecs/side-codecs/Kconfig | 1 -
 1 file changed, 1 deletion(-)
sound/hda/codecs/side-codecs/Kconfig +0 -1
index fc5651e555e3..e51964c0a091 100644
@@ -94,7 +94,6 @@ menu "CS35L56 driver options"
 
 config SND_HDA_SCODEC_CS35L56_CAL_DEBUGFS
 	bool "CS35L56 create debugfs for factory calibration"
-	default N
 	depends on DEBUG_FS
 	select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
 	help
Signature · 1 line
2.50.1
#1 lore raw
Quoted 5 lines · Andy Shevchenko

First of all, it has to be 'default n' (small letter n), otherwise it looks for CONFIG_N which is absent and in case of appearance will enable something unrelated. Second and most important is that 'n' *is* the default 'default' already. Hence just drop malformed line.

The redundant default was added intentionally to be explicit that the default really must be "no". But if that sort of thing is forbidden you can drop the line.

I apologize for the typo, but that is why you shouldn't use case difference as language syntax.

Quoted 18 lines
---
  sound/hda/codecs/side-codecs/Kconfig | 1 -
  1 file changed, 1 deletion(-)
sound/hda/codecs/side-codecs/Kconfig +0 -1
index fc5651e555e3..e51964c0a091 100644
@@ -94,7 +94,6 @@ menu "CS35L56 driver options"
 
  config SND_HDA_SCODEC_CS35L56_CAL_DEBUGFS
  	bool "CS35L56 create debugfs for factory calibration"
-	default N
  	depends on DEBUG_FS
  	select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
  	help
#2 lore raw
Quoted 10 lines · Richard Fitzgerald
Quoted 5 lines · Andy Shevchenko

First of all, it has to be 'default n' (small letter n), otherwise it looks for CONFIG_N which is absent and in case of appearance will enable something unrelated. Second and most important is that 'n' *is* the default 'default' already. Hence just drop malformed line.

The redundant default was added intentionally to be explicit that the default really must be "no". But if that sort of thing is forbidden you can drop the line.

Torvalds gave his opinion on the Subject a few years ago, here is what he would do.

0192f17529fa ("clean up x86 platform driver default values")

Quoted 2 lines

I apologize for the typo, but that is why you shouldn't use case difference as language syntax.

It's not me whom you should ask for that :-)

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Richard Fitzgerald
Quoted 5 lines · Andy Shevchenko

First of all, it has to be 'default n' (small letter n), otherwise it looks for CONFIG_N which is absent and in case of appearance will enable something unrelated. Second and most important is that 'n' *is* the default 'default' already. Hence just drop malformed line.

Quoted 8 lines
Quoted 3 lines

The redundant default was added intentionally to be explicit that the default really must be "no". But if that sort of thing is forbidden you can drop the line.

Torvalds gave his opinion on the Subject a few years ago, here is what he would do.

0192f17529fa ("clean up x86 platform driver default values")

Based on that, can you give your tag, please? (Also for ASoC case.)

Signature · 2 lines
With Best Regards,
Andy Shevchenko
Reviewed-by on v1 1/1
#4 lore raw
In reply to Andy Shevchenko
Quoted 16 lines · Andy Shevchenko

First of all, it has to be 'default n' (small letter n), otherwise it looks for CONFIG_N which is absent and in case of appearance will enable something unrelated. Second and most important is that 'n' *is* the default 'default' already. Hence just drop malformed line.

---
  sound/hda/codecs/side-codecs/Kconfig | 1 -
  1 file changed, 1 deletion(-)
sound/hda/codecs/side-codecs/Kconfig +0 -0
index fc5651e555e3..e51964c0a091 100644

sound/hda/codecs/side-codecs/Kconfig menu "CS35L56 driver options" · line 99

Quoted 7 lines
sound/hda/codecs/side-codecs/Kconfig +0 -1
@@ -94,7 +94,6 @@ menu "CS35L56 driver options"
 
  config SND_HDA_SCODEC_CS35L56_CAL_DEBUGFS
  	bool "CS35L56 create debugfs for factory calibration"
-	default N
  	depends on DEBUG_FS
  	select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
  	help
#6 lore raw
In reply to Andy Shevchenko
Quoted 8 lines · Andy Shevchenko

First of all, it has to be 'default n' (small letter n), otherwise it looks for CONFIG_N which is absent and in case of appearance will enable something unrelated. Second and most important is that 'n' *is* the default 'default' already. Hence just drop malformed line.

Applied now. Thanks.

Takashi