ASoC: tac5xx2-sdw: Use new SoundWire enumeration helper
PATCH 1/1 ASoC: tac5xx2-sdw: Use new SoundWire enumeration helper
Update the driver to use the new core helper that waits for the device to enumerate on SoundWire and be initialised by the SoundWire core.
---
Add the missing update that was pointed out by Niranjan.
Thanks,
Charles
sound/soc/codecs/tac5xx2-sdw.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-)
sound/soc/codecs/tac5xx2-sdw.c +3 -13
@@ -1437,7 +1437,6 @@ static s32 tac5xx2_sdca_dev_resume(struct device *dev) {struct tac5xx2_prv *tac_dev =dev_get_drvdata (dev);struct sdw_slave *slave =dev_to_sdw_dev (dev); -unsigned long t;int ret;if (!tac_dev->first_hw_init_done) {
@@ -1445,19 +1444,10 @@ static s32 tac5xx2_sdca_dev_resume(struct device *dev)return 0 ; } -if (!slave->unattach_request) - goto regmap_sync; - - t =wait_for_completion_timeout (&slave->initialization_complete, -msecs_to_jiffies (TAC5XX2_PROBE_TIMEOUT_MS )); -if (!t) { -dev_err (&slave->dev,"resume: initialization timed out\n" ); -sdw_show_ping_status (slave->bus, true); -return -ETIMEDOUT ; - } - slave->unattach_request =0 ; + ret =sdw_slave_wait_for_init (slave,TAC5XX2_PROBE_TIMEOUT_MS ); +if (ret) +return ret; -regmap_sync:regcache_cache_only (tac_dev->regmap, false);regcache_mark_dirty (tac_dev->regmap); ret =regcache_sync (tac_dev->regmap);
Signature · 1 line
2.47.3
Quoted 12 lines · Charles Keepax
Subject: [PATCH] ASoC: tac5xx2-sdw: Use new SoundWire enumeration helper
Update the driver to use the new core helper that waits for the device to enumerate on SoundWire and be initialised by the SoundWire core.
Suggested-by Niranjan H Y <[email protected]>Signed-off-by Charles Keepax <[email protected]>---
Add the missing update that was pointed out by Niranjan.
Thanks Charles! I've tested this version. Works as expected.
Mark Brown
maintainerQuoted 1 line · Charles Keepax
ASoC: tac5xx2-sdw: Use new SoundWire enumeration helper
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.2
Thanks!
[1/1] ASoC: tac5xx2-sdw: Use new SoundWire enumeration helper
https://git.kernel.org/broonie/sound/c/ab50528ab5b5
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark