FAILED: patch "[PATCH] spi: octeon: fix controller deregistration" failed to apply to 5.10-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 5.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y
git checkout FETCH_HEAD
git cherry-pick -x 3c49a4d8799bee423a80f392ba95b26af8e9ab91
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026051537-passcode-tiptop-8ff1@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^..
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 3c49a4d8799bee423a80f392ba95b26af8e9ab91 Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Thu, 9 Apr 2026 14:04:07 +0200
Subject: [PATCH] spi: octeon: fix controller deregistration
Make sure to deregister the controller before disabling it to avoid hanging or leaking resources associated with the queue when the queue is non-empty.
drivers/spi/spi-cavium-octeon.c +7 -1
@@ -54,7 +54,7 @@ static int octeon_spi_probe(struct platform_device *pdev) host->bits_per_word_mask =SPI_BPW_MASK (8 ); host->max_speed_hz =OCTEON_SPI_MAX_CLOCK_HZ ; - err =devm_spi_register_controller (&pdev->dev, host); + err =spi_register_controller (host);if (err) {dev_err (&pdev->dev,"register host failed: %d\n" , err); goto fail;
@@ -73,8 +73,14 @@ static void octeon_spi_remove(struct platform_device *pdev)struct spi_controller *host =platform_get_drvdata (pdev);struct octeon_spi *p =spi_controller_get_devdata (host); +spi_controller_get (host); + +spi_unregister_controller (host); +/* Clear the CSENA* and put everything in a known state. */ writeq (0 , p->register_base +OCTEON_SPI_CFG (p)); + +spi_controller_put (host); }static const struct of_device_id octeon_spi_match[] = {