FAILED: patch "[PATCH] spi: sh-msiof: fix controller deregistration" failed to apply to 5.10-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 5.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y
git checkout FETCH_HEAD
git cherry-pick -x 45170f67a08b912ead6ccc387ba06954d1d4e53a
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026051556-immortal-tapering-798b@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^..
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 45170f67a08b912ead6ccc387ba06954d1d4e53a Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Fri, 10 Apr 2026 10:17:43 +0200
Subject: [PATCH] spi: sh-msiof: fix controller deregistration
Make sure to deregister the controller before releasing underlying resources like DMA during driver unbind.
drivers/spi/spi-sh-msiof.c +8 -2
@@ -1289,9 +1289,9 @@ static int sh_msiof_spi_probe(struct platform_device *pdev)if (ret <0 )dev_warn (dev,"DMA not available, using PIO\n" ); - ret =devm_spi_register_controller (dev, ctlr); + ret =spi_register_controller (ctlr);if (ret <0 ) { -dev_err (dev,"devm_spi_register_controller error.\n" ); +dev_err (dev,"failed to register controller\n" ); goto err2; }
@@ -1309,8 +1309,14 @@ static void sh_msiof_spi_remove(struct platform_device *pdev) {struct sh_msiof_spi_priv *p =platform_get_drvdata (pdev); +spi_controller_get (p->ctlr); + +spi_unregister_controller (p->ctlr); +sh_msiof_release_dma (p);pm_runtime_disable (&pdev->dev); + +spi_controller_put (p->ctlr); }static const struct platform_device_id spi_driver_ids[] = {