Skip to contentSkip to conversation

kbuild: deb-pkg: propagate hook script failures in builddeb

PATCH Jill Ravaliya 2 participants 2 messages May 16 – May 17 Kbuild

lore
Share & tools
lore
#0 lore raw

Hi Nathan, Nicolas,

You are correct. I tested locally and confirmed that set -e in the generated postinst does catch run-parts failures even in the && expression — execution does not reach exit 0 when run-parts fails.

My patch is therefore redundant. I am withdrawing it.

The root cause remains 55-initrd.install silently returning exit 0 when initrd is missing (LP#2141741), which run-parts sees as success. That is where the fix belongs.

This was my first patch to the kernel mailing list. I apologize for the noise and thank you both for taking the time to review it carefully.

Jill Ravaliya

#1 lore raw

Hi Jill,

Quoted 7 lines · Jill Ravaliya

Hi Nathan, Nicolas,

You are correct. I tested locally and confirmed that set -e in the generated postinst does catch run-parts failures even in the && expression — execution does not reach exit 0 when run-parts fails.

Quoted 6 lines

My patch is therefore redundant. I am withdrawing it.

The root cause remains 55-initrd.install silently returning exit 0 when initrd is missing (LP#2141741), which run-parts sees as success. That is where the fix belongs.

Thanks for confirming!

Quoted 3 lines

This was my first patch to the kernel mailing list. I apologize for the noise and thank you both for taking the time to review it carefully.

No apologies necessary, it is all part of learning :) thanks for attempting to improve the usability of the Debian packaging.

Signature · 2 lines
Cheers,
Nathan