Skip to contentSkip to conversation

dos2unix: pass BUILD_LDFLAGS to native build

PATCH In review Ming Liu 2 participants 2 messages May 17 – May 21

lore
Share & tools
lore

Ming Liu

author
#0 lore raw

PATCH 1/1 dos2unix: pass BUILD_LDFLAGS to native build

BUILD_LDFLAGS is missing for native build, add it in.

---
 meta/recipes-support/dos2unix/dos2unix_7.5.5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/dos2unix/dos2unix_7.5.5.bb +1 -1
index aa078ed200..cb7102942d 100644
@@ -25,7 +25,7 @@ PACKAGECONFIG ??= ""
 PACKAGECONFIG[nls] = "ENABLE_NLS=1,ENABLE_NLS=,po4a-native"
 
 EXTRA_OEMAKE = "${PACKAGECONFIG_CONFARGS} LDFLAGS_USER='${LDFLAGS}'"
-EXTRA_OEMAKE:class-native = "ENABLE_NLS="
+EXTRA_OEMAKE:class-native = "ENABLE_NLS= LDFLAGS_USER='${BUILD_LDFLAGS}'"
 
 do_install () {
 	oe_runmake DESTDIR="${D}${base_prefix}" install
Signature · 1 line
2.43.0
#1 lore raw
Quoted 16 lines · Ming Liu via lists.openembedded.org

BUILD_LDFLAGS is missing for native build, add it in.

---
meta/recipes-support/dos2unix/dos2unix_7.5.5.bb | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/dos2unix/dos2unix_7.5.5.bb +0 -0
index aa078ed200..cb7102942d 100644
@@ -25,7 +25,7 @@ PACKAGECONFIG ??= ""

PACKAGECONFIG[nls] = "ENABLE_NLS=1,ENABLE_NLS=,po4a-native"

EXTRA_OEMAKE = "${PACKAGECONFIG_CONFARGS} LDFLAGS_USER='${LDFLAGS}'"

meta/recipes-support/dos2unix/dos2unix_7.5.5.bb

Quoted 2 lines
meta/recipes-support/dos2unix/dos2unix_7.5.5.bb +1 -1
-EXTRA_OEMAKE:class-native = "ENABLE_NLS="
+EXTRA_OEMAKE:class-native = "ENABLE_NLS= LDFLAGS_USER='${BUILD_LDFLAGS}’"

This is only needed as the native override above replaces the line above that, which does set LDFLAGS correctly.

I suggest deleting the "EXTRA_OEMAKE:class-native” line entirely instead, the PACKAGECONFIG isn’t enabled by default anyway.

Ross