Skip to contentSkip to conversation

iio: adc: ad7768-1: Select GPIOLIB

PATCH In review Jonathan Cameron 3 participants 4 messages Jan 11 – May 17 IIO

lore
Share & tools
lore

Jonathan Cameron

author maintainer
#0 lore raw

PATCH 1/1 iio: adc: ad7768-1: Select GPIOLIB

From: Jonathan Cameron <[email protected]>

This driver provides a gpio chip a some related functions are not stubbed if GPIOLIB is not built.

hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_get':

Quoted 1 line
Quoted 1 line

drivers/iio/adc/ad7768-1.c:420: undefined reference to `gpiochip_get_data'

hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_set':
drivers/iio/adc/ad7768-1.c:453: undefined reference to `gpiochip_get_data'
hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_init':

Quoted 1 line
Quoted 1 line

drivers/iio/adc/ad7768-1.c:498: undefined reference to `devm_gpiochip_add_data_with_key'

hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_direction_input':
drivers/iio/adc/ad7768-1.c:387: undefined reference to `gpiochip_get_data'
hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_direction_output':
drivers/iio/adc/ad7768-1.c:404: undefined reference to `gpiochip_get_data'

Fixes ("d569ae0f052e iio: adc: ad7768-1: Add GPIO controller support")
---
 drivers/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/adc/Kconfig +1 -0
index b4295aa415bf..e37569f65524 100644
@@ -409,6 +409,7 @@ config AD7766
 config AD7768_1
 	tristate "Analog Devices AD7768-1 ADC driver"
 	depends on SPI
+	select GPIOLIB
 	select REGULATOR
 	select REGMAP_SPI
 	select IIO_BUFFER
Signature · 1 line
2.52.0
#1 lore raw

On Sun, Jan 11, 2026 at 04:55:28PM +0000, Jonathan Cameron wrote:

Thanks for fixing this, my comment below.

Quoted 5 lines

This driver provides a gpio chip a some related functions are not stubbed if GPIOLIB is not built.

   hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_get':
Quoted 1 line
Quoted 1 line

drivers/iio/adc/ad7768-1.c:420: undefined reference to `gpiochip_get_data'

Quoted 8 lines

hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_set':

   drivers/iio/adc/ad7768-1.c:453: undefined reference to `gpiochip_get_data'
   hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_init':
Quoted 1 line
Quoted 1 line

drivers/iio/adc/ad7768-1.c:498: undefined reference to `devm_gpiochip_add_data_with_key'

hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_direction_input':

   drivers/iio/adc/ad7768-1.c:387: undefined reference to `gpiochip_get_data'
   hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_direction_output':
   drivers/iio/adc/ad7768-1.c:404: undefined reference to `gpiochip_get_data'

We don't need these many strings, the important ones only would be enough, like

ad7768-1.c:420: undefined reference to gpiochip_get_data' ad7768-1.c:498: undefined reference to devm_gpiochip_add_data_with_key'

(and also no need to have a full path in this case, we can always read an email
from the LKP below).

Quoted 4 lines
Fixes ("d569ae0f052e iio: adc: ad7768-1: Add GPIO controller support")
Signature · 2 lines
With Best Regards,
Andy Shevchenko
author maintainer
#2 lore raw
Quoted 18 lines · On Mon, 12 Jan 2026 09:23:14 +0200 Andy Shevchenko…

On Sun, Jan 11, 2026 at 04:55:28PM +0000, Jonathan Cameron wrote:

Thanks for fixing this, my comment below.

Quoted 5 lines

This driver provides a gpio chip a some related functions are not stubbed if GPIOLIB is not built.

   hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_get':  
Quoted 1 line
Quoted 1 line

drivers/iio/adc/ad7768-1.c:420: undefined reference to `gpiochip_get_data'

Quoted 8 lines

hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_set':

   drivers/iio/adc/ad7768-1.c:453: undefined reference to `gpiochip_get_data'
   hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_init':  
Quoted 1 line
Quoted 1 line

drivers/iio/adc/ad7768-1.c:498: undefined reference to `devm_gpiochip_add_data_with_key'

hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_direction_input':

   drivers/iio/adc/ad7768-1.c:387: undefined reference to `gpiochip_get_data'
   hppa-linux-ld: drivers/iio/adc/ad7768-1.o: in function `ad7768_gpio_direction_output':
   drivers/iio/adc/ad7768-1.c:404: undefined reference to `gpiochip_get_data'  
Quoted 13 lines

We don't need these many strings, the important ones only would be enough, like

ad7768-1.c:420: undefined reference to gpiochip_get_data' ad7768-1.c:498: undefined reference to devm_gpiochip_add_data_with_key'

(and also no need to have a full path in this case, we can always read an email
from the LKP below).

Quoted 4 lines
Fixes ("d569ae0f052e iio: adc: ad7768-1: Add GPIO controller support")

I'd forgotten about this one until i checked patchwork

Tweaked and applied. With silly situation that it has two different sign-offs from me, but that correctly reflects the path so I'll leave them.