Skip to contentSkip to conversation

Add support for Baijie Helper A133 board

PATCH Superseded Alexander Sverdlin 4 participants 11 messages May 17 – May 24

Subsystems (2)

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v3 cover Add support for Baijie Helper A133 board

Baijie Helper A133 board is a development board around Baijie A133 Core SBC. Features:

- 1/2/4GiB LPDDR4 DRAM
- 8/16/32GiB eMMC
- AXP707 PMIC
- USB-C OTG port in peripheral mode (via onboard hub)
- 2 USB 2.0 ports
- MicroSD slot and on-board eMMC module
- Gigabit Ethernet
- Bluetooth
- WiFi

Add initial support for both the Helper and Core boards, including UART, PMU, eMMC, USB, Ethernet, LRADC-connected buttons.

UART1 can only be used for Bluetooth module, but BT-WiFi combo Allwinner AW869A chip has not mainline driver currently.

Changelog:
v3:
- added lradc node to sun50i-a100.dtsi
- enabled LRADC driver in arm64 defconfig
- added my copyrights into the newly introduced DTs
- all DT nodes sorted alphabetically
- all always-on regulators commented/propetly named
- all regulators got proper voltages (not default ranges)
- ADC-sensed buttons K1..K5 added
- re-labelled "eth_phy" -> "rgmii_phy"
- usbphy 0 switched from host into peripheral mode (downstream from an onboard hub)
- typo sun50i-a133-baije-core.dtsi -> sun50i-a133-baijie-core.dtsi
v2:
- introduced baijie,helper-a133-core compatible for the Core (SoM) board
- https://lore.kernel.org/all/[email protected]/
v1:
- https://lore.kernel.org/all/[email protected]/

Alexander Sverdlin (5):
dt-bindings: vendor-prefixes: Add Shenzhen Baijie Technology Co., Ltd.
dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible
arm64: dts: allwinner: a100: Add LRADC node
arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
arm64: defconfig: Enable Allwinner LRADC input driver

 .../devicetree/bindings/arm/sunxi.yaml        |   6 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm64/boot/dts/allwinner/Makefile        |   1 +
 .../arm64/boot/dts/allwinner/sun50i-a100.dtsi |   9 +
 .../allwinner/sun50i-a133-baijie-core.dtsi    | 190 ++++++++++++++++++
 .../allwinner/sun50i-a133-baijie-helper.dts   | 133 ++++++++++++
 arch/arm64/configs/defconfig                  |   1 +
 7 files changed, 342 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-core.dtsi
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts
Signature · 1 line
2.54.0
#1 lore raw

PATCH v3 1/5 dt-bindings: vendor-prefixes: Add Shenzhen Baijie Technology Co., Ltd.

Shenzhen Baijie Technology Co., Ltd. focuses on R&D and production of embedded products as well as customization of embedded solutions.

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 28784d66ae7b..095cf654787f 100644
@@ -229,6 +229,8 @@ patternProperties:
     description: Azoteq (Pty) Ltd
   "^azw,.*":
     description: Shenzhen AZW Technology Co., Ltd.
+  "^baijie,.*":
+    description: Shenzhen Baijie Technology Co., Ltd.
   "^baikal,.*":
     description: BAIKAL ELECTRONICS, JSC
   "^bananapi,.*":
Signature · 1 line
2.54.0
#2 lore raw

PATCH v3 2/5 dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible

In reply to Alexander Sverdlin

Baijie HelperBoard A133 is a development board around their A133 Core board. Introduce a compatible for both the Core and the development boards.

---
Changelog:
v3:
- no separate section for "core" .dtsi
v2:
- introduced baijie,helper-a133-core compatible for the Core (SoM) board

 Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/sunxi.yaml +6 -0
index e6443c266fa1..f65bf1a549d4 100644
@@ -96,6 +96,12 @@ properties:
           - const: allwinner,ba10-tvbox
           - const: allwinner,sun4i-a10
 
+      - description: Baijie Helper A133
+        items:
+          - const: baijie,helper-a133
+          - const: baijie,helper-a133-core
+          - const: allwinner,sun50i-a100
+
       - description: BananaPi
         items:
           - const: lemaker,bananapi
Signature · 1 line
2.54.0
#3 lore raw

Re: [PATCH v3 2/5] dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Missing standalone compatible entry for the Core board. --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing standalone compatible entry for the Core board.
--

commit 76fcabeafe7a55386e6089c83f652ab14cf4b7ec
Author: Alexander Sverdlin <[email protected]>

dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible

Baijie HelperBoard A133 is a development board around their A133 Core board. Introduce a compatible for both the Core and the development boards.

Quoted 5 lines
Documentation/devicetree/bindings/arm/sunxi.yaml +0 -0
index 9e4627f97d7e3..845b5a93686e7 100644
@@ -96,6 +96,12 @@ properties:

[ ... ]

Documentation/devicetree/bindings/arm/sunxi.yaml properties: · line 104

Quoted 6 lines
Documentation/devicetree/bindings/arm/sunxi.yaml +6 -0
+      - description: Baijie Helper A133
+        items:
+          - const: baijie,helper-a133
+          - const: baijie,helper-a133-core
+          - const: allwinner,sun50i-a100
+

The commit message states the intent to "Introduce a compatible for both the Core and the development boards."

Since this items list requires exactly three elements, it correctly validates the development board, but it appears a device tree written solely for the standalone Core board would be rejected.

If the Core board were used with a different custom carrier board in the future, would it need its own standalone compatible entry?

For example:

- description: Baijie Helper A133 Core
items:
- const: baijie,helper-a133-core
- const: allwinner,sun50i-a100

Does omitting a standalone entry for the Core board limit flexibility for future designs based on it?

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
#4 lore raw

Re: [PATCH v3 2/5] dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible

Quoted 36 lines · On Sun, May 17, 2026 at 11:50:06PM +0000, [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing standalone compatible entry for the Core board.
--

commit 76fcabeafe7a55386e6089c83f652ab14cf4b7ec
Author: Alexander Sverdlin <[email protected]>

dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible

Baijie HelperBoard A133 is a development board around their A133 Core board. Introduce a compatible for both the Core and the development boards.

Quoted 5 lines
Documentation/devicetree/bindings/arm/sunxi.yaml +0 -0
index 9e4627f97d7e3..845b5a93686e7 100644
@@ -96,6 +96,12 @@ properties:

[ ... ]

Documentation/devicetree/bindings/arm/sunxi.yaml properties: · line 104

Quoted 6 lines
Documentation/devicetree/bindings/arm/sunxi.yaml +6 -0
+      - description: Baijie Helper A133
+        items:
+          - const: baijie,helper-a133
+          - const: baijie,helper-a133-core
+          - const: allwinner,sun50i-a100
+

The commit message states the intent to "Introduce a compatible for both the Core and the development boards."

Since this items list requires exactly three elements, it correctly validates the development board, but it appears a device tree written solely for the standalone Core board would be rejected.

If the Core board were used with a different custom carrier board in the future, would it need its own standalone compatible entry?

Quoted 6 lines

For example:

- description: Baijie Helper A133 Core
items:
- const: baijie,helper-a133-core
- const: allwinner,sun50i-a100

This example is complete crap, compared to the point that is apparently being made about different carriers.

Quoted 2 lines

Does omitting a standalone entry for the Core board limit flexibility for future designs based on it?

Obviously not.

#5 lore raw

PATCH v3 3/5 arm64: dts: allwinner: a100: Add LRADC node

In reply to Alexander Sverdlin

A100/A133 SoCs feature a Low Rate ADC (LRADC) for Key application.

Specs:
- Power supply voltage: 1.8 V
- Reference voltage: 1.35 V
- Interrupt support
- Support Hold Key and General Key
- Support normal, continue and single work mode
- 6-bits resolution, sample rate up to 2 kHz
- Voltage input range between 0 and 1.35 V

---
 arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi +9 -0
index b3fb1e0ee796..2bba13c5d25c 100644
@@ -466,6 +466,15 @@ ths: thermal-sensor@5070400 {
 			#thermal-sensor-cells = <1>;
 		};
 
+		lradc: lradc@5070800 {
+			compatible = "allwinner,sun50i-r329-lradc";
+			reg = <0x05070800 0x400>;
+			interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&ccu CLK_BUS_LRADC>;
+			resets = <&ccu RST_BUS_LRADC>;
+			status = "disabled";
+		};
+
 		usb_otg: usb@5100000 {
 			compatible = "allwinner,sun50i-a100-musb",
 				     "allwinner,sun8i-a33-musb";
Signature · 1 line
2.54.0
#6 lore raw

Re: [PATCH v3 3/5] arm64: dts: allwinner: a100: Add LRADC node

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] Missing SoC-specific compatible string for the LRADC device tree node. - [Low] Non-standard…

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing SoC-specific compatible string for the LRADC device tree node.
- [Low] Non-standard device tree node name 'lradc'.
--

commit 2888476527aa17fae679cf9ed23a85ccc8db7463
Author: Alexander Sverdlin <[email protected]>

arm64: dts: allwinner: a100: Add LRADC node

This commit adds the Low Rate ADC (LRADC) device tree node for the Allwinner A100/A133 SoCs. The IP block is primarily used for key applications and supports various operating modes.

arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi ths: thermal-sensor@5070400 { · line 469

Quoted 9 lines
arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi +1 -0
index b3fb1e0ee796b..2bba13c5d25cd 100644
@@ -466,6 +466,15 @@ ths: thermal-sensor@5070400 {
 			#thermal-sensor-cells = <1>;
 		};
 
+		lradc: lradc@5070800 {

Could this node use a more generic name like adc@5070800 or keys@5070800?

Other device nodes in this file adhere to the generic naming convention recommended by the Devicetree Specification.

arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi ths: thermal-sensor@5070400 { · line 470

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi +1 -0
+			compatible = "allwinner,sun50i-r329-lradc";

Is the A100-specific compatible string missing from this node?

Other recent Allwinner SoCs utilizing this IP define their own specific compatible alongside the fallback.

Would including an A100-specific string like "allwinner,sun50i-a100-lradc" allow handling potential quirks without breaking backward compatibility?

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi +1 -0
+			reg = <0x05070800 0x400>;

[ ... ]

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
maintainer
#7 lore raw

Re: [PATCH v3 3/5] arm64: dts: allwinner: a100: Add LRADC node

Hi Alexander,

Quoted 23 lines · On Mon, May 18, 2026 at 2:02 AM <[email protected]> wrote:

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing SoC-specific compatible string for the LRADC device tree node.
- [Low] Non-standard device tree node name 'lradc'.
--

commit 2888476527aa17fae679cf9ed23a85ccc8db7463
Author: Alexander Sverdlin <[email protected]>

arm64: dts: allwinner: a100: Add LRADC node

This commit adds the Low Rate ADC (LRADC) device tree node for the Allwinner A100/A133 SoCs. The IP block is primarily used for key applications and supports various operating modes.

Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi +0 -0
index b3fb1e0ee796b..2bba13c5d25cd 100644
@@ -466,6 +466,15 @@ ths: thermal-sensor@5070400 {
                      #thermal-sensor-cells = <1>;
              };
 
Quoted 6 lines

arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi ths: thermal-sensor@5070400 { · line 469

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi +1 -0
+             lradc: lradc@5070800 {

Could this node use a more generic name like adc@5070800 or keys@5070800?

Other device nodes in this file adhere to the generic naming convention recommended by the Devicetree Specification.

Please ignore this comment.

Quoted 9 lines

arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi ths: thermal-sensor@5070400 { · line 470

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi +1 -0
+                     compatible = "allwinner,sun50i-r329-lradc";

Is the A100-specific compatible string missing from this node?

Other recent Allwinner SoCs utilizing this IP define their own specific compatible alongside the fallback.

Would including an A100-specific string like "allwinner,sun50i-a100-lradc" allow handling potential quirks without breaking backward compatibility?

Yes, we always add SoC-specific compatibles, unless they are just the same die in different packages. Please add another patch to add the compatible, then use it in this patch. See this series for the H616 [1] as an example.

Thanks
ChenYu

[1] https://lore.kernel.org/all/[email protected]/

Quoted 6 lines

arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi ths: thermal-sensor@5070400 { · line 471

Quoted 1 line
arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi +1 -0
+                     reg = <0x05070800 0x400>;

[ ... ]

--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3

#8 lore raw

PATCH v3 4/5 arm64: dts: allwinner: A133: add support for Baijie Helper A133 board

In reply to Alexander Sverdlin

Baijie Helper A133 board is a development board around Baijie A133 Core SBC. Features:

- 1/2/4GiB LPDDR4 DRAM
- 8/16/32GiB eMMC
- AXP707 PMIC
- USB-C OTG port in peripheral mode (via onboard hub)
- 2 USB 2.0 ports
- MicroSD slot and on-board eMMC module
- Gigabit Ethernet
- Bluetooth
- WiFi

Add initial support for both the Helper and Core boards, including UART, PMU, eMMC, USB, Ethernet, LRADC-connected buttons.

UART1 can only be used for Bluetooth module, but BT-WiFi combo Allwinner AW869A chip has not mainline driver currently.

---
Changelog:
v3:
- added my copyrights into the newly introduced DTs
- all DT nodes sorted alphabetically
- all always-on regulators commented/propetly named
- all regulators got proper voltages (not default ranges)
- ADC-sensed buttons K1..K5 added
- re-labelled "eth_phy" -> "rgmii_phy"
- usbphy 0 switched from host into peripheral mode (downstream from an onboard hub)
- typo sun50i-a133-baije-core.dtsi -> sun50i-a133-baijie-core.dtsi v2:
- introduced baijie,helper-a133-core compatible for the Core (SoM) board

 arch/arm64/boot/dts/allwinner/Makefile        |   1 +
 .../allwinner/sun50i-a133-baijie-core.dtsi    | 190 ++++++++++++++++++
 .../allwinner/sun50i-a133-baijie-helper.dts   | 133 ++++++++++++
 3 files changed, 324 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-core.dtsi
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts
arch/arm64/boot/dts/allwinner/Makefile +1 -0
index d116864b6c2b..926dfa851100 100644
@@ -18,6 +18,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h64-remix-mini-pc.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a133-baijie-helper.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a133-liontron-h-a133l.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus-v1.2.dtb
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-core.dtsi new file +190 -0

190 lines not on this page · raw message

arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-helper.dts new file +133 -0

133 lines not on this page · raw message

Signature · 1 line
2.54.0
#9 lore raw

Re: [PATCH v3 4/5] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Low] Misplaced `vcc-pl-supply` property and incorrect architectural attribution in comments. - [Low]…

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Misplaced vcc-pl-supply property and incorrect architectural attribution in comments.
- [Low] Commit message contradiction regarding USB topology.
--

commit d668428c158ab5f1654141d1c2e6dd96b970af49
Author: Alexander Sverdlin <[email protected]>

arm64: dts: allwinner: A133: add support for Baijie Helper A133 board

Add initial support for both the Helper and Core boards, including UART, PMU, eMMC, USB, Ethernet, and LRADC-connected buttons.

Quoted 7 lines

Baijie Helper A133 board is a development board around Baijie A133 Core SBC. Features:

- 1/2/4GiB LPDDR4 DRAM
- 8/16/32GiB eMMC
- AXP707 PMIC
- USB-C OTG port in peripheral mode (via onboard hub)

This isn't a bug, but is the description of the USB topology accurate?

A USB port operating in peripheral mode cannot be routed through a standard downstream USB hub to act as a device, as USB hubs are strictly host-to-device interfaces.

Does the onboard hub instead connect to the ehci1/ohci1 host port to provide the 2 USB 2.0 ports, while the usb_otg port is directly connected to the USB-C port?

[ ... ]

Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-core.dtsi new file +0 -0
new file mode 100644
index 0000000000000..7a09a5181c03b

[ ... ]

Quoted 4 lines

+&pio {

arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-core.dtsi new file +3 -0
+	vcc-pb-supply = <&reg_dcdc1>;
+	vcc-pc-supply = <&reg_eldo1>;
+	vcc-pd-supply = <&reg_dcdc1>;

arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-core.dtsi line 53

Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-core.dtsi new file +10 -0
+	vcc-pe-supply = <&reg_dldo2>;
+	vcc-pf-supply = <&reg_dcdc1>;
+	vcc-pg-supply = <&reg_dldo1>;
+	vcc-ph-supply = <&reg_dcdc1>;
+	/*
+	 * PL0/PL1 are the I2C connection to PMIC, but it would create a
+	 * circular dependency:
+	 * vcc-pl-supply = <&reg_aldo3>;
+	 */
+};

Does this comment accurately reflect the hardware architecture?

In Allwinner A100/A133 SoCs, the main pio pin controller manages banks PB through PH, while Port L (PL) pins are managed by a separate r_pio controller in the PRCM domain.

If vcc-pl-supply were uncommented here, wouldn't it simply be ignored by the pio node rather than creating a circular dependency? Should this property and comment instead be associated with the r_pio node?

[ ... ]

arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-core.dtsi line 94

Quoted 7 lines

+&reg_aldo3 {

arch/arm64/boot/dts/allwinner/sun50i-a133-baijie-core.dtsi new file +6 -0
+	/*
+	 * Port L, but linking it to &pio node would create a circular
+	 * dependency because of PL0/PL1 I2C connection to PMIC
+	 */
+	regulator-always-on;
+	regulator-min-microvolt = <1800000>;

Similarly here, should this comment refer to the r_pio node instead of the pio node?

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
#10 lore raw

PATCH v3 5/5 arm64: defconfig: Enable Allwinner LRADC input driver

In reply to Alexander Sverdlin

Enable Allwinner LRADC input driver as module to support buttons on Baijie HelperBoard A133.

---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
index 094bb9cd8764..570e84674029 100644
@@ -524,6 +524,7 @@ CONFIG_KEYBOARD_GPIO=y
 CONFIG_KEYBOARD_GPIO_POLLED=m
 CONFIG_KEYBOARD_SNVS_PWRKEY=m
 CONFIG_KEYBOARD_IMX_SC_KEY=m
+CONFIG_KEYBOARD_SUN4I_LRADC=m
 CONFIG_KEYBOARD_CROS_EC=y
 CONFIG_KEYBOARD_MTK_PMIC=m
 CONFIG_MOUSE_ELAN_I2C=m
Signature · 1 line
2.54.0