hwmon: (lm75) Add explicit header include
PATCH v2 1/1 hwmon: (lm75) Add explicit header include
Since device_property_read_string() is used in the probe function add explicit include for linux/mod_devicetable.h and linux/property.h rather than having implicit inclusions. Header linux/of.h can be removed and also of_match_ptr() improving non-Device Tree compatibility of the driver. Remove __maybe_unuse because it is not needed anymore.
---
Changes in v2:
- Remove __maybe_unuse and reduce line breaks suggested by Guenter Roeck.
- Link to v1: https://lore.kernel.org/all/[email protected]/
drivers/hwmon/lm75.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/hwmon/lm75.c +4 -3
@@ -14,7 +14,8 @@#include <linux/i3c/device.h> #include <linux/hwmon.h> #include <linux/err.h> -#include <linux/of.h> +#include <linux/mod_devicetable.h> +#include <linux/property.h> #include <linux/regmap.h> #include <linux/util_macros.h> #include <linux/regulator/consumer.h>
@@ -899,7 +900,7 @@ static int lm75_i3c_probe(struct i3c_device *i3cdev)return lm75_generic_probe (dev, id_data->name, id_data->type,0 , regmap); } -static const struct of_device_id __maybe_unused lm75_of_match[] = { +static const struct of_device_id lm75_of_match[] = { { .compatible ="adi,adt75" , .data = (void *)adt75
@@ -1152,7 +1153,7 @@ static struct i2c_driver lm75_i2c_driver = { .class = I2C_CLASS_HWMON, .driver = { .name = "lm75", - .of_match_table = of_match_ptr(lm75_of_match), + .of_match_table = lm75_of_match, .pm = LM75_DEV_PM_OPS, }, .probe = lm75_i2c_probe,
Signature · 1 line
2.34.1
Quoted 7 lines · Flaviu Nistor
Since
device_property_read_string()is used in the probe function add explicit include forlinux/mod_devicetable.handlinux/property.hrather than having implicit inclusions. Headerlinux/of.hcan be removed and alsoof_match_ptr()improving non-Device Tree compatibility of the driver. Remove__maybe_unusebecause it is not needed anymore.Signed-off-by Flaviu Nistor <[email protected]>
Applied.
Thanks,
Guenter