usb: typec: add Qualcomm PMI8998 USB Type-C role-switch support

The Qualcomm PMI8998 PMIC integrates a USB OTG VBUS boost converter inside its SMB2 charger block at offset 0x1100. The OTG control register layout (CMD_OTG at +0x40, OTG_CURRENT_LIMIT_CFG at +0x52, OTG_CFG at +0x53) matches the PM8150B SMB5 block, so the existing qcom_usb_vbus-regulator driver can drive it without code changes via compatible cascade.

Verified by inspecting the downstream qpnp-smb2 driver and reading live register values on a OnePlus 6T (sdm845-oneplus-fajita) running mainline Linux.

Signed-off-by taygoth <[email protected]>

---
  .../devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml   | 1 +
  1 file changed, 1 insertion(+)

Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml +0 -0

index fcefc722ee2a..9e2e2c8f9539 100644

The Qualcomm PMI8998 PMIC integrates a USB OTG VBUS boost converter inside its SMB2 charger block at offset 0x1100. The OTG control register layout (CMD_OTG at +0x40, OTG_CURRENT_LIMIT_CFG at +0x52, OTG_CFG at +0x53) matches the PM8150B SMB5 block, so the existing qcom_usb_vbus-regulator driver can drive it without code changes via compatible cascade.

Verified by inspecting the downstream qpnp-smb2 driver and reading live register values on a OnePlus 6T (sdm845-oneplus-fajita) running mainline Linux.

Signed-off-by taygoth <[email protected]>

The PMI8998 PMIC integrates a USB Type-C detection block in its SMB2 charger USBIN region at offset 0x1300. The block performs CC sensing, debounce and Rp/Rd resolution in hardware and reports role changes through a single consolidated "type-c-change" interrupt.

This is architecturally distinct from the qcom,pmic-typec binding (PM8150B / PMI632 family) which exposes a granular 8-16 IRQ topology fanned out per Type-C event for a software TCPM state machine. PMI8998 has neither the per-event IRQs nor a register layout compatible with the TCPM code path, so this binding describes a separate hardware- managed role-switch controller.

Signed-off-by taygoth <[email protected]>

---
 .../bindings/usb/qcom,pmi8998-typec.yaml      | 97 +++++++++++++++++++
 1 file changed, 97 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/qcom,pmi8998-typec.yaml

Documentation/devicetree/bindings/usb/qcom,pmi8998-typec.yaml new file +33 -0

new file mode 100644
index 000000000000..f2814f5ce3de
@@ -0,0 +1,97 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/qcom,pmi8998-typec.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm PMI8998 USB Type-C role-switch controller
+
+maintainers:
+  - Maxim Furman <[email protected]>
+
+description:
+  The PMI8998 PMIC integrates a USB Type-C detection block inside its SMB2
+  charger USBIN region at offset 0x1300. CC sensing, debounce and Rp/Rd
+  resolution are performed in hardware, and the negotiated role is reported
+  through a single consolidated "type-c-change" interrupt.
+
+  This block is distinct from the TCPM-based qcom,pmic-typec controllers
+  (PM8150B, PMI632, etc.) — PMI8998 lacks the granular per-event interrupt
+  topology those parts expose and the driver therefore translates the
+  hardware-decided role directly into a usb_role_switch_set_role() call
+  rather than running a software TCPM state machine. Power Delivery is not
+  supported by this binding.
+
+properties:
+  compatible:
+    const: qcom,pmi8998-typec
+
+  reg:
+    maxItems: 1
+    description: Type-C SPMI register base offset (typically 0x1300).
+
+  interrupts:

Documentation/devicetree/bindings/usb/qcom,pmi8998-typec.yaml new file +54 -0

+
+  connector:
+    type: object
+    $ref: /schemas/connector/usb-connector.yaml#
+    unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-names
+  - connector
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    pmic {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        typec@1300 {
+            compatible = "qcom,pmi8998-typec";
+            reg = <0x1300>;
+
+            interrupts = <0x2 0x13 0x7 IRQ_TYPE_EDGE_BOTH>;
+            interrupt-names = "type-c-change";
+
+            vdd-vbus-supply = <&pmi8998_vbus>;
+
+            connector {
+                compatible = "usb-c-connector";
+                label = "USB-C";
+                power-role = "dual";
+                data-role = "dual";
+                try-power-role = "sink";
+
+                ports {
+                    #address-cells = <1>;
+                    #size-cells = <0>;
+
+                    port@0 {
+                        reg = <0>;
+                        pmi8998_hs_in: endpoint {
+                            remote-endpoint = <&usb_1_dwc3_hs>;
+                        };
+                    };
+                };
+            };
+        };
+    };
+...

Signature · 1 line

2.47.3

The Qualcomm PMI8998 PMIC integrates a USB Type-C detection block in its SMB2 charger USBIN region at offset 0x1300. The block performs CC sensing, debounce and Rp/Rd resolution in silicon and reports role changes through a single consolidated "type-c-change" interrupt.

This driver reads TYPE_C_STATUS_4 on probe and on every interrupt, decodes the hardware-detected role (host / device / none) and pushes it to a usb_role_switch consumer (typically dwc3) so the controller can flip between peripheral and host on cable orientation change. An optional VBUS supply regulator is toggled on USB_ROLE_HOST transitions so bus-powered downstream peripherals can be powered.

No software TCPM state machine is used because the hardware handles the Type-C protocol natively, and the PMI8998 interrupt topology does not expose the granular per-event signals the TCPM code path expects. Power Delivery is not implemented in this driver; the PMI8998 PDPHY block at offset 0x1700 (register-identical to PM8150B) can be wired up by a separate driver later if PD negotiation is required.

This enables USB host mode on the OnePlus 6 (enchilada), OnePlus 6T (fajita), Xiaomi Poco F1 (beryllium), SHIFT 6mq (axolotl) and other SDM845-based phones that use the PMI8998 as their second PMIC.

Signed-off-by taygoth <[email protected]>

---
 drivers/usb/typec/Kconfig              |  17 ++
 drivers/usb/typec/Makefile             |   1 +
 drivers/usb/typec/qcom_pmi8998_typec.c | 213 +++++++++++++++++++++++++
 3 files changed, 231 insertions(+)
 create mode 100644 drivers/usb/typec/qcom_pmi8998_typec.c

Quoted 6 lines

No software TCPM state machine is used because the hardware handles the Type-C protocol natively, and the PMI8998 interrupt topology does not expose the granular per-event signals the TCPM code path expects. Power Delivery is not implemented in this driver; the PMI8998 PDPHY block at offset 0x1700 (register-identical to PM8150B) can be wired up by a separate driver later if PD negotiation is required.

I think TCPM / PD-PHY is (more or less) a sensible requirement. Without it you can't negotiate higher power modes or AltModes support (which means no DP).

along side the pmi8998 logic.

The Qualcomm PMI8998 PMIC integrates a USB Type-C detection block in its SMB2 charger USBIN region at offset 0x1300. The block performs CC sensing, debounce and Rp/Rd resolution in silicon and reports role changes through a single consolidated "type-c-change" interrupt.

This driver reads TYPE_C_STATUS_4 on probe and on every interrupt, decodes the hardware-detected role (host / device / none) and pushes it to a usb_role_switch consumer (typically dwc3) so the controller can flip between peripheral and host on cable orientation change. An optional VBUS supply regulator is toggled on USB_ROLE_HOST transitions so bus-powered downstream peripherals can be powered.

No software TCPM state machine is used because the hardware handles the Type-C protocol natively, and the PMI8998 interrupt topology does not expose the granular per-event signals the TCPM code path expects. Power Delivery is not implemented in this driver; the PMI8998 PDPHY block at offset 0x1700 (register-identical to PM8150B) can be wired up by a separate driver later if PD negotiation is required.

This enables USB host mode on the OnePlus 6 (enchilada), OnePlus 6T (fajita), Xiaomi Poco F1 (beryllium), SHIFT 6mq (axolotl) and other SDM845-based phones that use the PMI8998 as their second PMIC.

Signed-off-by taygoth <[email protected]>

---
 drivers/usb/typec/Kconfig              |  17 ++
 drivers/usb/typec/Makefile             |   1 +
 drivers/usb/typec/qcom_pmi8998_typec.c | 213 +++++++++++++++++++++++++
 3 files changed, 231 insertions(+)
 create mode 100644 drivers/usb/typec/qcom_pmi8998_typec.c

Power Delivery is not implemented. The PMI8998 PDPHY block at offset 0x1700 is register-identical to PM8150B and could be wired through the existing drivers/usb/typec/tcpm/qcom code in a follow-up if PD negotiation becomes a requirement.

Three shapes for adding a second port handler to the existing driver:
  (a) extracted ops -- pmic_typec_port_ops with chip-specific get_cc / get_vbus / set_mode / set_vconn / start_toggling, refactor PM8150B code into the ops, add parallel PMI8998 implementation
  (b) parallel port file -- keep PM8150B code untouched, add a sibling source file with the same tcpc_dev callback surface
  (c) per-chip register table + per-chip decode helpers in the same file

Bryan, do you have a preference? I'd rather match your taste than guess, since you'll be maintaining the merged result.

Quoted 6 lines · Максим Фурман

Three shapes for adding a second port handler to the existing driver:
  (a) extracted ops -- pmic_typec_port_ops with chip-specific get_cc / get_vbus / set_mode / set_vconn / start_toggling, refactor PM8150B code into the ops, add parallel PMI8998 implementation
  (b) parallel port file -- keep PM8150B code untouched, add a sibling source file with the same tcpc_dev callback surface

Quoted 4 lines

  (c) per-chip register table + per-chip decode helpers in the same file

Bryan, do you have a preference? I'd rather match your taste than guess, since you'll be maintaining the merged result.

Taste - loaded with honey, chilli and salt please chef and add the whole clove of garlic....

My feeling is sibling file but please use your own taste/discretion.

---
bod

This series adds USB Type-C role-switch support for the PMI8998 PMIC used on SDM845 phones (OnePlus 6/6T, Xiaomi Poco F1, SHIFT 6mq), which have been locked to USB peripheral mode under mainline kernels until now.

The PMI8998 SMB2 charger block integrates a Type-C detection unit at SPMI offset 0x1300 that performs CC sensing, debounce and Rp/Rd resolution entirely in hardware. The state is exposed through the TYPE_C_STATUS_4 register and reported via a single consolidated "type-c-change" interrupt. The new driver reads that status on every interrupt and pushes the negotiated role to a usb_role_switch consumer (dwc3), enabling automatic peripheral/host switching on cable change. Because the hardware handles the Type-C state machine natively, no software TCPM port manager is required.

The Type-C block shares the SMB2 USBIN region with the already mainlined qcom_pmi8998-charger driver. The two coexist on the shared SPMI regmap without write conflict: the typec driver only reads TYPE_C_STATUS_* and touches the IRQ enable bits at offsets 0x130b-0x130f and 0x1367-0x1368.

The PMI8998 USB OTG VBUS boost converter at offset 0x1100 has the same CMD_OTG / OTG_CFG / OTG_CURRENT_LIMIT register layout as PM8150B, so the existing drivers/regulator/qcom_usb_vbus-regulator can drive it through a compatible cascade -- only the DT binding needs the new compatible string added.

Power Delivery is not implemented. The PMI8998 PDPHY block at offset 0x1700 is register-identical to PM8150B and could be wired through the existing drivers/usb/typec/tcpm/qcom code in a follow-up if PD negotiation becomes a requirement.

Tested-on: OnePlus 6T (sdm845-oneplus-fajita) running Mobian 6.12-sdm845.

This series adds USB Type-C role-switch support for the PMI8998 PMIC used on SDM845 phones (OnePlus 6/6T, Xiaomi Poco F1, SHIFT 6mq), which have been locked to USB peripheral mode under mainline kernels until now.

The PMI8998 SMB2 charger block integrates a Type-C detection unit at SPMI offset 0x1300 that performs CC sensing, debounce and Rp/Rd resolution entirely in hardware. The state is exposed through the TYPE_C_STATUS_4 register and reported via a single consolidated "type-c-change" interrupt. The new driver reads that status on every interrupt and pushes the negotiated role to a usb_role_switch consumer (dwc3), enabling automatic peripheral/host switching on cable change. Because the hardware handles the Type-C state machine natively, no software TCPM port manager is required.

The Type-C block shares the SMB2 USBIN region with the already mainlined qcom_pmi8998-charger driver. The two coexist on the shared SPMI regmap without write conflict: the typec driver only reads TYPE_C_STATUS_* and touches the IRQ enable bits at offsets 0x130b-0x130f and 0x1367-0x1368.

The PMI8998 USB OTG VBUS boost converter at offset 0x1100 has the same CMD_OTG / OTG_CFG / OTG_CURRENT_LIMIT register layout as PM8150B, so the existing drivers/regulator/qcom_usb_vbus-regulator can drive it through a compatible cascade -- only the DT binding needs the new compatible string added.

Power Delivery is not implemented. The PMI8998 PDPHY block at offset 0x1700 is register-identical to PM8150B and could be wired through the existing drivers/usb/typec/tcpm/qcom code in a follow-up if PD negotiation becomes a requirement.

Tested-on: OnePlus 6T (sdm845-oneplus-fajita) running Mobian 6.12-sdm845. A USB flash drive, USB ethernet adapter, USB WiFi adapter (TP-Link Archer T2) and a self-powered USB-C dock with downstream ethernet all enumerate through xHCI after the role transitions from peripheral to host. Repeat plug/unplug cycles drive the role through device -> none -> host -> none -> device cleanly with no IRQ stalls or stale role-switch state.