Skip to contentSkip to conversation

spi: cadence-xspi: Add COMPILE_TEST support

PATCH In review Rosen Penev 2 participants 2 messages May 19 – May 22 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: cadence-xspi: Add COMPILE_TEST support

The Cadence XSPI driver uses readq() and writeq(), which are not provided directly by all 32-bit architectures. Include the generic non-atomic 64-bit I/O accessor fallback for non-64-bit builds so the driver can build there.

Drop the 64BIT dependency at the same time. The driver only needs MMIO and the SPI memory interface at build time, and the fallback accessors cover the 32-bit compile-test case.

Assisted-by Codex:GPT-5.5
---
 drivers/spi/Kconfig            | 3 ++-
 drivers/spi/spi-cadence-xspi.c | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)
drivers/spi/Kconfig +2 -1
index 8782514bb89b..957c3e065b83 100644
@@ -321,7 +321,8 @@ config SPI_CADENCE_QUADSPI
 
 config SPI_CADENCE_XSPI
 	tristate "Cadence XSPI controller"
-	depends on OF && HAS_IOMEM && 64BIT
+	depends on HAS_IOMEM || COMPILE_TEST
+	depends on OF
 	depends on SPI_MEM
 	help
 	  Enable support for the Cadence XSPI Flash controller.
drivers/spi/spi-cadence-xspi.c +4 -0
index 32fa19ebf7a9..c45b29c043bf 100644
@@ -22,6 +22,10 @@
 #include <linux/bitrev.h>
 #include <linux/util_macros.h>
 
+#ifndef CONFIG_64BIT
+#include <linux/io-64-nonatomic-lo-hi.h>
+#endif
+
 #define CDNS_XSPI_MAGIC_NUM_VALUE	0x6522
 #define CDNS_XSPI_MAX_BANKS		8
 #define CDNS_XSPI_NAME			"cadence-xspi"
Signature · 1 line
2.54.0
maintainer
#1 lore raw
Quoted 1 line · Rosen Penev

spi: cadence-xspi: Add COMPILE_TEST support

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-7.2

Thanks!

[1/1] spi: cadence-xspi: Add COMPILE_TEST support

      https://git.kernel.org/broonie/spi/c/0c5b5c40dc31

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark