futex: Add error coverage tests for wait, wake and cmp_requeue
v5 cover futex: Add error coverage tests for wait, wake and cmp_requeue
Improve error handling coverage for futex syscalls by adding tests for missing error conditions that were previously untested.
v5:
- Use compile-time testcase arrays with double pointers instead of runtime initialization in setup()
- Fix sparse warnings: add (void *) cast in SAFE_MUNMAP calls
- Remove unnecessary braces in single-statement if blocks
v4:
- Use TST_EXP_FAIL instead of manual error checks
- Add kernel version check for EACCES in futex_cmp_requeue03
- Restructure testcases to use direct pointers instead of flag fields
- Replace raw mmap() with SAFE_MMAP() in futex_wait06
- Remove manual SAFE_WAITPID, let library collect child
- Remove obvious comments in futex_wait07
v3:
- Fix copyright year 2024 -> 2026
- Use /*\ comment format for test catalog
- Add Signed-off-by
Michael Menasherov (4):
futex_wait06: Add EFAULT error coverage test
futex_wait07: Add EINTR error coverage test
futex_wake05: Add EFAULT error coverage test
futex_cmp_requeue03: Add EFAULT error coverage test
runtest/syscalls | 4 + testcases/kernel/syscalls/futex/.gitignore | 4 + .../syscalls/futex/futex_cmp_requeue03.c | 100 ++++++++++++++++++ .../kernel/syscalls/futex/futex_wait06.c | 75 +++++++++++++ .../kernel/syscalls/futex/futex_wait07.c | 87 +++++++++++++++ .../kernel/syscalls/futex/futex_wake05.c | 86 +++++++++++++++ 6 files changed, 356 insertions(+) create mode 100644 testcases/kernel/syscalls/futex/futex_cmp_requeue03.c create mode 100644 testcases/kernel/syscalls/futex/futex_wait06.c create mode 100644 testcases/kernel/syscalls/futex/futex_wait07.c create mode 100644 testcases/kernel/syscalls/futex/futex_wake05.c
Signature · 5 lines
2.54.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v5 1/4 futex_wait06: Add EFAULT error coverage test
futex(FUTEX_WAIT) has no existing test for EFAULT. Add coverage for the cases where uaddr points to unmapped memory and where the timeout pointer is invalid.
--- runtest/syscalls | 1 + testcases/kernel/syscalls/futex/.gitignore | 1 + .../kernel/syscalls/futex/futex_wait06.c | 75 +++++++++++++++++++ 3 files changed, 77 insertions(+) create mode 100644 testcases/kernel/syscalls/futex/futex_wait06.c
runtest/syscalls +1 -0
@@ -1907,3 +1907,4 @@ io_uring03 io_uring03 # Tests below may cause kernel memory leak perf_event_open03 perf_event_open03 +futex_wait06 futex_wait06
testcases/kernel/syscalls/futex/.gitignore +1 -0
@@ -13,3 +13,4 @@ /futex_waitv01 /futex_waitv02 /futex_waitv03 +/futex_wait06
testcases/kernel/syscalls/futex/futex_wait06.c new file +75 -0
75 lines not on this page · raw message
Signature · 5 lines
2.54.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] futex_wait06: Add EFAULT error coverage test
Hi Michael,
--- [PATCH 4/4] ---
Quoted 9 lines · Michael Menasherov
futex_cmp_requeue03: Add EFAULT error coverage test+/*\
+ * Check thatfutex(FUTEX_CMP_REQUEUE)returns EFAULT when uaddr or
+ * uaddr2 points to unmapped memory, or when uaddr points to memory
+ * without read permission (PROT_NONE).
+ *
+ * The EACCES behavior forPROT_NONEwas introduced in kernel 5.9.
+ */
The doc comment says "returns EFAULT ... when uaddr points to memory without read permission (PROT_NONE)", but the test correctly expects EACCES for that case on kernels >= 5.9. Please update the comment to reflect both outcomes, e.g.:
"returns EFAULT when uaddr or uaddr2 points to unmapped memory, or
EACCES (EFAULT on kernels < 5.9) when uaddr points to PROT_NONE memory."
Patches 1–3 look good.
---
Note:
Our agent completed the review of the patch. The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v5 2/4 futex_wait07: Add EINTR error coverage test
In reply to Michael Menasherov via ltpfutex(FUTEX_WAIT) has no existing test for EINTR. Add coverage for the case where the wait is interrupted by a signal before the futex word changes.
--- runtest/syscalls | 1 + testcases/kernel/syscalls/futex/.gitignore | 1 + .../kernel/syscalls/futex/futex_wait07.c | 87 +++++++++++++++++++ 3 files changed, 89 insertions(+) create mode 100644 testcases/kernel/syscalls/futex/futex_wait07.c
runtest/syscalls +1 -0
@@ -1908,3 +1908,4 @@ io_uring03 io_uring03 # Tests below may cause kernel memory leak perf_event_open03 perf_event_open03 futex_wait06 futex_wait06 +futex_wait07 futex_wait07
testcases/kernel/syscalls/futex/.gitignore +1 -0
@@ -14,3 +14,4 @@ /futex_waitv02 /futex_waitv03 /futex_wait06 +/futex_wait07
testcases/kernel/syscalls/futex/futex_wait07.c new file +87 -0
87 lines not on this page · raw message
Signature · 5 lines
2.54.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v5 3/4 futex_wake05: Add EFAULT error coverage test
In reply to Michael Menasherov via ltpfutex(FUTEX_WAKE) has no existing test for EFAULT. Add coverage for the cases where uaddr points to unmapped or PROT_NONE memory.
--- runtest/syscalls | 1 + testcases/kernel/syscalls/futex/.gitignore | 1 + .../kernel/syscalls/futex/futex_wake05.c | 86 +++++++++++++++++++ 3 files changed, 88 insertions(+) create mode 100644 testcases/kernel/syscalls/futex/futex_wake05.c
runtest/syscalls +1 -0
@@ -1909,3 +1909,4 @@ io_uring03 io_uring03 perf_event_open03 perf_event_open03 futex_wait06 futex_wait06 futex_wait07 futex_wait07 +futex_wake05 futex_wake05
testcases/kernel/syscalls/futex/.gitignore +1 -0
@@ -15,3 +15,4 @@ /futex_waitv03 /futex_wait06 /futex_wait07 +/futex_wake05
testcases/kernel/syscalls/futex/futex_wake05.c new file +86 -0
86 lines not on this page · raw message
Signature · 5 lines
2.54.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v5 4/4 futex_cmp_requeue03: Add EFAULT error coverage test
In reply to Michael Menasherov via ltpfutex(FUTEX_CMP_REQUEUE) has no existing test for EFAULT. Add coverage for the cases where uaddr or uaddr2 points to unmapped or inaccessible (PROT_NONE) memory.
--- runtest/syscalls | 1 + testcases/kernel/syscalls/futex/.gitignore | 1 + .../syscalls/futex/futex_cmp_requeue03.c | 100 ++++++++++++++++++ 3 files changed, 102 insertions(+) create mode 100644 testcases/kernel/syscalls/futex/futex_cmp_requeue03.c
runtest/syscalls +1 -0
@@ -1910,3 +1910,4 @@ perf_event_open03 perf_event_open03 futex_wait06 futex_wait06 futex_wait07 futex_wait07 futex_wake05 futex_wake05 +futex_cmp_requeue03 futex_cmp_requeue03
testcases/kernel/syscalls/futex/.gitignore +1 -0
@@ -16,3 +16,4 @@ /futex_wait06 /futex_wait07 /futex_wake05 +/futex_cmp_requeue03
testcases/kernel/syscalls/futex/futex_cmp_requeue03.c new file +100 -0
100 lines not on this page · raw message
Signature · 5 lines
2.54.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp