nilfs2: Fix return in nilfs_mkdir
Ryusuke Konishi
maintainerPATCH 1/1 nilfs2: Fix return in nilfs_mkdir
From: Hongling Zeng <[email protected]>
Return NULL instead of passing zero to ERR_PTR.
Fixes smatch warning:
- fs/nilfs2/namei.c:261 nilfs_mkdir() warn: passing zero to 'ERR_PTR'
---
Hi Viacheslav,
Please add this to the queue for the next cycle.
This is one of the fixes by Hongling Zeng, a patch that individually corrects a semantic issue (which is harmless in execution) related to the use of the ERR_PTR macro that arose from a recent VFS change.
Thanks,
Ryusuke Konishi
fs/nilfs2/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nilfs2/namei.c +1 -1
@@ -258,7 +258,7 @@ static struct dentry *nilfs_mkdir(struct mnt_idmap *idmap, struct inode *dir,else nilfs_transaction_abort (dir->i_sb); -return ERR_PTR (err); +return err ?ERR_PTR (err) :NULL ; out_fail:drop_nlink (inode);
Signature · 1 line
2.43.0
Viacheslav Dubeyko
AppliedQuoted 29 lines · Ryusuke Konishi
From: Hongling Zeng <[email protected]>
Return NULL instead of passing zero to
ERR_PTR.
Fixes smatch warning:
-fs/nilfs2/namei.c:261nilfs_mkdir()warn: passing zero to 'ERR_PTR'Fixes 88d5baf69082 ("Change inode_operations.mkdir to return struct dentry *")Signed-off-by Hongling Zeng <[email protected]>Signed-off-by Ryusuke Konishi <[email protected]>---
Hi Viacheslav,Please add this to the queue for the next cycle.
This is one of the fixes by Hongling Zeng, a patch that individually corrects a semantic issue (which is harmless in execution) related to the use of the
ERR_PTRmacro that arose from a recent VFS change.Thanks,
Ryusuke Konishifs/nilfs2/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/nilfs2/namei.c +0
-0
fs/nilfs2/namei.c static struct dentry *nilfs_mkdir(struct mnt_idmap *idmap, struct inode *dir, · line 264
Quoted 8 lines
fs/nilfs2/namei.c +1
-1@@ -258,7 +258,7 @@ static struct dentry *nilfs_mkdir(struct mnt_idmap *idmap, struct inode *dir,else nilfs_transaction_abort (dir->i_sb); -return ERR_PTR (err); +return err ?ERR_PTR (err) :NULL ; out_fail:drop_nlink (inode);
Applied.
Thanks,
Slava.