Skip to contentSkip to conversation

iio: imu: bno055: terminate dev_err() strings with a newline

PATCH Applied Stepan Ionichev 4 participants 5 messages May 20 – Jun 2 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: imu: bno055: terminate dev_err() strings with a newline

Two dev_err() calls in bno055_ser_write_reg() and bno055_ser_read_reg() are missing the trailing newline, so the kernel log buffer continues the next message on the same line.

Add the missing \n.

---
 drivers/iio/imu/bno055/bno055_ser_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/imu/bno055/bno055_ser_core.c +2 -2
index 48669dabb..733f9112d 100644
@@ -288,7 +288,7 @@ static int bno055_ser_write_reg(void *context, const void *_data, size_t count)
 	struct bno055_ser_priv *priv = context;
 
 	if (count < 2) {
-		dev_err(&priv->serdev->dev, "Invalid write count %zu", count);
+		dev_err(&priv->serdev->dev, "Invalid write count %zu\n", count);
 		return -EINVAL;
 	}
 
@@ -306,7 +306,7 @@ static int bno055_ser_read_reg(void *context,
 	struct bno055_ser_priv *priv = context;
 
 	if (val_size > 128) {
-		dev_err(&priv->serdev->dev, "Invalid read valsize %zu", val_size);
+		dev_err(&priv->serdev->dev, "Invalid read valsize %zu\n", val_size);
 		return -EINVAL;
 	}
 
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 26 lines · Stepan Ionichev

Two dev_err() calls in bno055_ser_write_reg() and bno055_ser_read_reg() are missing the trailing newline, so the kernel log buffer continues the next message on the same line.

Add the missing \n.

---
 drivers/iio/imu/bno055/bno055_ser_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/imu/bno055/bno055_ser_core.c +1 -1
index 48669dabb..733f9112d 100644
@@ -288,7 +288,7 @@ static int bno055_ser_write_reg(void *context, const void *_data, size_t count)
        struct bno055_ser_priv *priv = context;
 
        if (count < 2) {
-               dev_err(&priv->serdev->dev, "Invalid write count %zu", count);
+               dev_err(&priv->serdev->dev, "Invalid write count %zu\n", count);
                return -EINVAL;
        }
 

drivers/iio/imu/bno055/bno055_ser_core.c static int bno055_ser_read_reg(void *context, · line 312

Quoted 8 lines
drivers/iio/imu/bno055/bno055_ser_core.c +1 -1
@@ -306,7 +306,7 @@ static int bno055_ser_read_reg(void *context,
        struct bno055_ser_priv *priv = context;
 
        if (val_size > 128) {
-               dev_err(&priv->serdev->dev, "Invalid read valsize %zu", val_size);
+               dev_err(&priv->serdev->dev, "Invalid read valsize %zu\n", val_size);
                return -EINVAL;
        }
 

Sashiko seems fine with it. Also did a quick visual check and looks fine (not compiled, but I wouldn't count this as a functional change).

best regards,
max

Quoted 4 lines

--
2.43.0

maintainer Applied
#2 lore raw
Quoted 39 lines · On Wed, 20 May 2026 15:13:41 -0500 Maxwell Doose <[email protected]> wrote:
Quoted 26 lines · Stepan Ionichev

Two dev_err() calls in bno055_ser_write_reg() and bno055_ser_read_reg() are missing the trailing newline, so the kernel log buffer continues the next message on the same line.

Add the missing \n.

---
 drivers/iio/imu/bno055/bno055_ser_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/imu/bno055/bno055_ser_core.c +1 -1
index 48669dabb..733f9112d 100644
@@ -288,7 +288,7 @@ static int bno055_ser_write_reg(void *context, const void *_data, size_t count)
        struct bno055_ser_priv *priv = context;
 
        if (count < 2) {
-               dev_err(&priv->serdev->dev, "Invalid write count %zu", count);
+               dev_err(&priv->serdev->dev, "Invalid write count %zu\n", count);
                return -EINVAL;
        }
 

drivers/iio/imu/bno055/bno055_ser_core.c static int bno055_ser_read_reg(void *context, · line 312

Quoted 8 lines
drivers/iio/imu/bno055/bno055_ser_core.c +1 -1
@@ -306,7 +306,7 @@ static int bno055_ser_read_reg(void *context,
        struct bno055_ser_priv *priv = context;
 
        if (val_size > 128) {
-               dev_err(&priv->serdev->dev, "Invalid read valsize %zu", val_size);
+               dev_err(&priv->serdev->dev, "Invalid read valsize %zu\n", val_size);
                return -EINVAL;
        }
 

Sashiko seems fine with it. Also did a quick visual check and looks fine (not compiled, but I wouldn't count this as a functional change).

Quoted 1 line

Applied.
Thanks,

J

Quoted 10 lines

best regards,
max

Quoted 4 lines

--
2.43.0

#3 lore raw
Quoted 2 lines · Jonathan Cameron

On Wed, 20 May 2026 15:13:41 -0500
Maxwell Doose <[email protected]> wrote:

...

Quoted 1 line

Applied.

Hmm... It's probably too late to tweak the commit message, okay, not a big deal here.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
In reply to Stepan Ionichev
Quoted 5 lines · Stepan Ionichev

Two dev_err() calls in bno055_ser_write_reg() and bno055_ser_read_reg() are missing the trailing newline, so the kernel log buffer continues the next message on the same line.

Add the missing \n.

Surprisingly the kernel log buffer will be fine even without this patch. So the commit message should say something about consistency of the style and theoretical problems in the future in case one switches back from dev_err() to pr_err().

You can dig into sources to understand why your patch changes nothing in the behaviour.

Signature · 2 lines
With Best Regards,
Andy Shevchenko