init: do_mounts: use kmalloc() for allocations of temporary buffers
Subsystems (2)
PATCH 1/1 init: do_mounts: use kmalloc() for allocations of temporary buffers
Several places in init/do_mounts.c allocate temporary buffers for filesystem names or options using __get_free_page() or alloc_page().
Usage of alloc_page() APIs is not required there and only creates unnecessary noise with castings or conversion from struct page to void *.
kmalloc() is a better API for these uses and it also provides better scalability and more debugging possibilities.
Replace use of __get_free_page() and alloc_page() with kmalloc().
While on it, add a check for -ENOMEM condition in mount_root_generic().
---
This is a (tiny) part of larger work of replacing page allocator calls with kmalloc:
Also in git:
https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git gfp-to-kmalloc/init
--- init/do_mounts.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-)
init/do_mounts.c +10 -11
@@ -143,16 +143,14 @@ static int __init do_mount_root(const char *name, const char *fs, const int flags, const void *data) { struct super_block *s; -struct page *p =NULL ;char *data_page =NULL ;int ret;if (data) {/* init_mount() requires a full page as fifth argument */ - p =alloc_page (GFP_KERNEL ); -if (!p) + data_page =kmalloc (PAGE_SIZE ,GFP_KERNEL ); +if (!data_page)return -ENOMEM ; - data_page =page_address (p);strscpy_pad (data_page, data,PAGE_SIZE ); }
@@ -170,19 +168,20 @@ static int __init do_mount_root(const char *name, const char *fs, MAJOR(ROOT_DEV), MINOR(ROOT_DEV)); out: -if (p) -put_page (p); +kfree (data_page);return ret; }void __init mount_root_generic (char *name,char *pretty_name,int flags) { -struct page *page =alloc_page (GFP_KERNEL ); -char *fs_names =page_address (page); +char *fs_names =kmalloc (PAGE_SIZE ,GFP_KERNEL );char *p;char b[BDEVNAME_SIZE ];int num_fs, i; +if (!fs_names) +panic ("VFS: Unable to mount root fs: not enough memory" ); +scnprintf (b,BDEVNAME_SIZE ,"unknown-block(%u,%u)" ,MAJOR (ROOT_DEV ),MINOR (ROOT_DEV ));if (root_fs_names)
@@ -242,7 +241,7 @@ void __init mount_root_generic(char *name, char *pretty_name, int flags)printk ("\n" );panic ("VFS: Unable to mount root fs on \"%s\" or %s" , pretty_name, b); out: -put_page (page); +kfree (fs_names); }#ifdef CONFIG_ROOT_NFS
@@ -343,7 +342,7 @@ static int __init mount_nodev_root(char *root_device_name)int err = -EINVAL ;int num_fs, i; - fs_names = (void *)__get_free_page (GFP_KERNEL ); + fs_names =kmalloc (PAGE_SIZE ,GFP_KERNEL );if (!fs_names)return -EINVAL ; num_fs =split_fs_names (fs_names,PAGE_SIZE );
@@ -360,7 +359,7 @@ static int __init mount_nodev_root(char *root_device_name)break ; } -free_page ((unsigned long )fs_names); +kfree (fs_names);return err; }
---
base-commit: 5d6919055dec134de3c40167a490f33c74c12581
change-id: 20260520-init-152a94946e25
Best regards,
Signature · 2 lines
Sincerely yours, Mike.
Quoted 9 lines · Mike Rapoport (Microsoft)
Several places in
init/do_mounts.callocate temporary buffers for filesystem names or options using__get_free_page()oralloc_page().Usage of
alloc_page()APIs is not required there and only creates unnecessary noise with castings or conversion from struct page to void *.
kmalloc()is a better API for these uses and it also provides better scalability and more debugging possibilities.
Quoted 6 lines
Replace use of
__get_free_page()andalloc_page()withkmalloc().While on it, add a check for
-ENOMEMcondition inmount_root_generic().
Looks fine...
kernel test robot
build botkernel test robot noticed the following build warnings:
Hi Mike,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 5d6919055dec134de3c40167a490f33c74c12581]
url: https://github.com/intel-lab-lkp/linux/commits/Mike-Rapoport-Microsoft/init-do_mounts-use-kmalloc-for-allocations-of-temporary-buffers/20260520-164927 base: 5d6919055dec134de3c40167a490f33c74c12581 patch link: https://lore.kernel.org/r/20260520-init-v1-1-aaf2ebac5ad9%40kernel.org patch subject: [PATCH] init: do_mounts: use kmalloc() for allocations of temporary buffers config: xtensa-allnoconfig (https://download.01.org/0day-ci/archive/20260520/[email protected]/config) compiler: xtensa-linux-gcc (GCC) 15.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260520/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> WARNING: modpost: vmlinux: section mismatch in reference: try_to_run_init_process+0x24 (section: .text.unlikely) -> initcall_level_names (section: .init.data)
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Quoted 10 lines · On Wed, 20 May 2026 11:16:51 +0300 "Mike Rapoport (Microsoft)"…
Several places in
init/do_mounts.callocate temporary buffers for filesystem names or options using__get_free_page()oralloc_page().Usage of
alloc_page()APIs is not required there and only creates unnecessary noise with castings or conversion from struct page to void *.
kmalloc()is a better API for these uses and it also provides better scalability and more debugging possibilities.Replace use of
__get_free_page()andalloc_page()withkmalloc().
Makes sense. I once wondered if kmalloc_objs() fits here, but kmalloc() also looks good to me.
Quoted 5 lines
While on it, add a check for
-ENOMEMcondition inmount_root_generic().
Thanks,
SJ
[...]
Quoted 10 lines · Mike Rapoport (Microsoft)
Several places in
init/do_mounts.callocate temporary buffers for filesystem names or options using__get_free_page()oralloc_page().Usage of
alloc_page()APIs is not required there and only creates unnecessary noise with castings or conversion from struct page to void *.
kmalloc()is a better API for these uses and it also provides better scalability and more debugging possibilities.[...]
Applied to the vfs-7.2.misc branch of the vfs/vfs.git tree. Patches in the vfs-7.2.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs-7.2.misc
[1/1] init: do_mounts: use kmalloc() for allocations of temporary buffers
https://git.kernel.org/vfs/vfs/c/3fb2d124b647