staging: rtl8723bs: efuse signature cleanup
v6 cover staging: rtl8723bs: efuse signature cleanup
This series reformats the multi-line function signatures in rtw_efuse.c to single lines to fix checkpatch.pl warnings. Patch 1 also fixes missing braces on the else clause in rtw_efuse_read_1_byte(). Both patches have been compile-tested.
Changes from v5 to v6:
1) Reduced series from 3 patches to 2 by combining the signature reformat and brace fix for rtw_efuse_read_1_byte() — splitting them caused a build failure between patches.
2) Compile-tested each patch individually before sending.
Moksh Panicker (2):
staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature
staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature
drivers/staging/rtl8723bs/core/rtw_efuse.c | 15 +++++----------- 1 file changed, 4 insertions(+), 11 deletions(-)
--
2.34.1
PATCH v6 1/2 staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature
Reformat multi-line function signature to a single line to fix line length and coding style warnings from checkpatch.pl.
Also fix the missing brace/comment spacing in rtw_efuse_read_1_byte().
Note: CamelCase identifiers (Adapter, Address) are pre-existing in this function and not introduced by this patch.
--- drivers/staging/rtl8723bs/core/rtw_efuse.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/staging/rtl8723bs/core/rtw_efuse.c +3 -6
@@ -41,10 +41,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)* 09/23/2008 MHC Copy from WMAC. * */ -u8 -rtw_efuse_read_1_byte ( -struct adapter *Adapter, -u16 Address) +u8 rtw_efuse_read_1_byte (struct adapter *Adapter,u16 Address) {u8 Bytetemp = {0x00 };u8 temp = {0x00 };
@@ -76,9 +73,9 @@ u16 Address)break ; }return rtw_read8 (Adapter,EFUSE_CTRL ); - }else + }else {return 0xFF ; - + } }/* rtw_efuse_read_1_byte */ /* 11/16/2008 MH Read one byte from real Efuse. */
Signature · 1 line
2.34.1
Greg KH
maintainerRe: [PATCH v6 1/2] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature
Quoted 44 lines · Moksh Panicker
Reformat multi-line function signature to a single line to fix line length and coding style warnings from checkpatch.pl.
Also fix the missing brace/comment spacing in
rtw_efuse_read_1_byte().Note: CamelCase identifiers (Adapter, Address) are pre-existing in this function and not introduced by this patch.
Signed-off-by Moksh Panicker <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_efuse.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)drivers/staging/rtl8723bs/core/rtw_efuse.c +3
-6@@ -41,10 +41,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)* 09/23/2008 MHC Copy from WMAC. * */ -u8 -rtw_efuse_read_1_byte ( -struct adapter *Adapter, -u16 Address) +u8 rtw_efuse_read_1_byte (struct adapter *Adapter,u16 Address) {u8 Bytetemp = {0x00 };u8 temp = {0x00 };@@ -76,9 +73,9 @@ u16 Address)break ; }return rtw_read8 (Adapter,EFUSE_CTRL ); - }else + }else {return 0xFF ; - + } }/* rtw_efuse_read_1_byte */ /* 11/16/2008 MH Read one byte from real Efuse. */ Signature · 1 line
2.34.1
Does not apply to the tree :(
PATCH v6 2/2 staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature
In reply to Moksh PanickerReformat multi-line function signature to a single line to fix line length and coding style warnings from checkpatch.pl.
--- drivers/staging/rtl8723bs/core/rtw_efuse.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/staging/rtl8723bs/core/rtw_efuse.c +1 -5
@@ -79,11 +79,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address) }/* rtw_efuse_read_1_byte */ /* 11/16/2008 MH Read one byte from real Efuse. */ -u8 -rtw_efuse_one_byte_read ( -struct adapter *padapter, -u16 addr, -u8 *data) +u8 rtw_efuse_one_byte_read (struct adapter *padapter,u16 addr,u8 *data) {u32 tmpidx =0 ;u8 bResult;
Signature · 1 line
2.34.1