mm/cma_sysfs: Skip inactive CMA areas in sysfs
Subsystems (2)
PATCH 1/1 mm/cma_sysfs: Skip inactive CMA areas in sysfs
From: Kaitao Cheng <[email protected]>
cma_activate_area() can fail after a CMA area has already been added to cma_areas[]. In that case the area is left in the global array, but it does not reach the point where CMA_ACTIVATED is set.
cma_sysfs_init() currently walks all cma_area_count entries and creates sysfs files for every area, including ones that failed activation. These areas are not usable CMA areas and should not be exposed to userspace as valid CMA regions.
Skip CMA areas that did not reach CMA_ACTIVATED when creating the sysfs objects. Since inactive entries can now be skipped, make the error unwind tolerate entries that never had cma_kobj initialized.
--- mm/cma_sysfs.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
mm/cma_sysfs.c +6 -2
@@ -117,13 +117,16 @@ static int __init cma_sysfs_init(void)return -ENOMEM ;for (i =0 ; i < cma_area_count; i++) { + cma = &cma_areas[i]; +if (!test_bit (CMA_ACTIVATED , &cma->flags)) +continue ; + cma_kobj =kzalloc_obj (*cma_kobj);if (!cma_kobj) { err = -ENOMEM ; goto out; } - cma = &cma_areas[i]; cma->cma_kobj = cma_kobj; cma_kobj->cma = cma; err = kobject_init_and_add(&cma_kobj->kobj, &cma_ktype,
@@ -138,7 +141,8 @@ static int __init cma_sysfs_init(void) out:while (--i >=0 ) { cma = &cma_areas[i]; -kobject_put (&cma->cma_kobj->kobj); +if (cma->cma_kobj) +kobject_put (&cma->cma_kobj->kobj); }kobject_put (cma_kobj_root);
Signature · 1 line
2.50.1 (Apple Git-155)
Quoted 12 lines · Kaitao Cheng
From: Kaitao Cheng <[email protected]>
cma_activate_area()can fail after a CMA area has already been added to cma_areas[]. In that case the area is left in the global array, but it does not reach the point whereCMA_ACTIVATEDis set.
cma_sysfs_init()currently walks allcma_area_countentries and creates sysfs files for every area, including ones that failed activation. These areas are not usable CMA areas and should not be exposed to userspace as valid CMA regions.
Quoted 5 lines
Skip CMA areas that did not reach
CMA_ACTIVATEDwhen creating the sysfs objects. Since inactive entries can now be skipped, make the error unwind tolerate entries that never hadcma_kobjinitialized.Fixes 43ca106fa8ec ("mm: cma: support sysfs")
Actually, this is not a fix since there is no serious issue when accessing those sysfs files. I think it is an improvement.
Quoted 4 lines
Reported-by David Hildenbrand (Arm) <[email protected]>Reported-by Muchun Song <[email protected]>Signed-off-by Kaitao Cheng <[email protected]>
Thanks.
Andrew Morton
maintainerQuoted 13 lines · On Fri, 22 May 2026 21:26:59 +0800 Muchun Song <[email protected]> wrote:
Quoted 12 lines · Kaitao Cheng
From: Kaitao Cheng <[email protected]>
cma_activate_area()can fail after a CMA area has already been added to cma_areas[]. In that case the area is left in the global array, but it does not reach the point whereCMA_ACTIVATEDis set.
cma_sysfs_init()currently walks allcma_area_countentries and creates sysfs files for every area, including ones that failed activation. These areas are not usable CMA areas and should not be exposed to userspace as valid CMA regions.
Quoted 8 lines
Quoted 5 lines
Skip CMA areas that did not reach
CMA_ACTIVATEDwhen creating the sysfs objects. Since inactive entries can now be skipped, make the error unwind tolerate entries that never hadcma_kobjinitialized.Fixes 43ca106fa8ec ("mm: cma: support sysfs")Actually, this is not a fix since there is no serious issue when accessing those sysfs files. I think it is an improvement.
I find it hard to say because the changelog doesn't have a clear description of the userspace-visible impact of the bug.
Quoted 3 lines
Quoted 3 lines
That says "Reading the bitmap file can make debugfs walk a freed range
bitmap and trigger an invalid memory access". Maybe it oopses?
So Kaitao, can you please send us a clear and complete description of how this bug affects downstream users?
Quoted 28 lines · Andrew Morton
Quoted 13 lines · On Fri, 22 May 2026 21:26:59 +0800 Muchun Song <[email protected]> wrote:
Quoted 12 lines · Kaitao Cheng
From: Kaitao Cheng <[email protected]>
cma_activate_area()can fail after a CMA area has already been added to cma_areas[]. In that case the area is left in the global array, but it does not reach the point whereCMA_ACTIVATEDis set.
cma_sysfs_init()currently walks allcma_area_countentries and creates sysfs files for every area, including ones that failed activation. These areas are not usable CMA areas and should not be exposed to userspace as valid CMA regions.Quoted 8 lines
Quoted 5 lines
Skip CMA areas that did not reach
CMA_ACTIVATEDwhen creating the sysfs objects. Since inactive entries can now be skipped, make the error unwind tolerate entries that never hadcma_kobjinitialized.Fixes 43ca106fa8ec ("mm: cma: support sysfs")Actually, this is not a fix since there is no serious issue when accessing those sysfs files. I think it is an improvement.
I find it hard to say because the changelog doesn't have a clear description of the userspace-visible impact of the bug.
Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
That says "Reading the bitmap file can make debugfs walk a freed range
bitmap and trigger an invalid memory access". Maybe it oopses?
I think the Closes tag should not be added here since the commit in the link actually fixes
a bug when accessing debugfs files. But this commit tried to hide inactive CMA from sysfs
files. It is a suggestion from David in the linked commit.
Quoted 3 lines
So Kaitao, can you please send us a clear and complete description of how this bug affects downstream users?
It will be clearer if Kaitao could resend a new version with a clear commit message.
Muchun,
Thanks.