scsi: scsi_devinfo: blacklist HPE/DISK-SUBSYSTEM
PATCH RESEND 1/1 scsi: scsi_devinfo: blacklist HPE/DISK-SUBSYSTEM
DISK-SUBSYSTEM is a special model name returned by "OPEN-" arrays when LUs are not installed. This requires BLIST_REPORTLUN2 to prevent issues during device scanning.
Full info: https://lore.kernel.org/linux-scsi/[email protected]
While this entry was originally covered by:
{"HP", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
After commit b8018b973c7c (scsi: scsi_devinfo: fixup string compare), vendor string matching must be exact. Devices reporting the vendor as "HPE" are no longer matched by the "HP" entry.
Add an explicit entry for "HPE" to restore the intended scanning behavior for these devices.
--- drivers/scsi/scsi_devinfo.c | 1 + 1 file changed, 1 insertion(+)
drivers/scsi/scsi_devinfo.c +1 -0
@@ -183,6 +183,7 @@ static struct { {"HP", "C5713A", NULL, BLIST_NOREPORTLUN}, {"HP", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2}, {"HPE", "OPEN-", "*", BLIST_REPORTLUN2 | BLIST_TRY_VPD_PAGES}, + {"HPE", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2}, {"IBM", "AuSaV1S2", NULL, BLIST_FORCELUN}, {"IBM", "ProFibre 4000R", "*", BLIST_SPARSELUN | BLIST_LARGELUN}, {"IBM", "2076", NULL, BLIST_NO_VPD_SIZE},
Signature · 1 line
2.54.0
Quoted 33 lines · Xose Vazquez Perez
DISK-SUBSYSTEM is a special model name returned by "OPEN-" arrays when LUs are not installed. This requires
BLIST_REPORTLUN2to prevent issues during device scanning.
Full info: https://lore.kernel.org/linux-scsi/[email protected]While this entry was originally covered by:
{"HP", "DISK-SUBSYSTEM", "*",BLIST_REPORTLUN2},After commit
b8018b973c7c(scsi:scsi_devinfo: fixup string compare), vendor string matching must be exact. Devices reporting the vendor as "HPE" are no longer matched by the "HP" entry.Add an explicit entry for "HPE" to restore the intended scanning behavior for these devices.
Cc Ewan D. Milne <[email protected]>Cc Anthony Cheung <[email protected]>Cc Takahiro Yasui <[email protected]>Cc Matthias Rudolph <[email protected]>Cc Christoph Hellwig <[email protected]>Cc James E.J. Bottomley <[email protected]>Cc Martin K. Petersen <[email protected]>Cc SCSI-ML <[email protected]>Signed-off-by Xose Vazquez Perez <[email protected]>--- drivers/scsi/scsi_devinfo.c | 1 + 1 file changed, 1 insertion(+)drivers/scsi/scsi_devinfo.c +0
-0
drivers/scsi/scsi_devinfo.c static struct { · line 189
Quoted 7 lines
drivers/scsi/scsi_devinfo.c +1
-0@@ -183,6 +183,7 @@ static struct { {"HP", "C5713A", NULL, BLIST_NOREPORTLUN}, {"HP", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2}, {"HPE", "OPEN-", "*", BLIST_REPORTLUN2 | BLIST_TRY_VPD_PAGES}, + {"HPE", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2}, {"IBM", "AuSaV1S2", NULL, BLIST_FORCELUN}, {"IBM", "ProFibre 4000R", "*", BLIST_SPARSELUN | BLIST_LARGELUN}, {"IBM", "2076", NULL, BLIST_NO_VPD_SIZE},
A brief observation: when performing a manual injection via /proc/scsi/device_info, the kernel automatically pads the entries with whitespace. This contrasts with how the kernel displays its internal values,
# echo "HPE:DISK-SUBSYSTEM:0x20000" >> /proc/scsi/device_info
# grep DISK-SUBSYSTEM /proc/scsi/device_info 'HPE ' 'DISK-SUBSYSTEM ' 0x20000 'HITACHI' 'DISK-SUBSYSTEM' 0x20000 'HP' 'DISK-SUBSYSTEM' 0x20000