getpid: Link manpage in docparse comments
PATCH v2 1/2 getpid: Link manpage in docparse comments
---
Changes in v2:
- Split indentation changes into a separate commit
- Link to v1: https://lore.kernel.org/ltp/[email protected]
--- testcases/kernel/syscalls/getpid/getpid01.c | 3 ++- testcases/kernel/syscalls/getpid/getpid02.c | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-)
testcases/kernel/syscalls/getpid/getpid01.c +2 -1
@@ -4,7 +4,8 @@*/ /*\ -* Verify that getpid() system call returns process ID in range <2, PID_MAX>. +* Verify that :manpage:`getpid(2)` system call returns process ID in range +* <2, PID_MAX>. */ #include <stdlib.h>
testcases/kernel/syscalls/getpid/getpid02.c +4 -2
@@ -6,8 +6,10 @@/*\ * Check that: * -* - fork() in parent returns the same pid as getpid() in child -* - getppid() in child returns the same pid as getpid() in parent +* - :manpage:`fork(2)` in parent returns the same pid as +* :manpage:`getpid(2)` in child +* - :manpage:`getppid(2)` in child returns the same pid as +* :manpage:`getpid(2)` in parent */ #include <errno.h>
--
2.43.0
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v2 2/2 getpid02: Remove unused header and fix minor style issue
Remove the unused <errno.h> header.
Use tabs for indentation.
--- testcases/kernel/syscalls/getpid/getpid02.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
testcases/kernel/syscalls/getpid/getpid02.c +1 -3
@@ -12,8 +12,6 @@* :manpage:`getpid(2)` in parent */ -#include <errno.h> -#include "tst_test.h" static pid_t *child_pid;
@@ -53,7 +51,7 @@ static void verify_getpid(void)static void setup (void ) { child_pid =SAFE_MMAP (NULL ,sizeof (pid_t),PROT_READ |PROT_WRITE , -MAP_ANONYMOUS |MAP_SHARED ,-1 ,0 ); +MAP_ANONYMOUS |MAP_SHARED ,-1 ,0 ); }static void cleanup (void )
--
2.43.0
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v2 2/2] getpid02: Remove unused header and fix minor style issue
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Jinseok,
Review
Quoted 5 lines · Jinseok Kim
getpid: Link manpage in docparse comments
(quoted diff) +0
-2-#include <errno.h> - #include "tst_test.h"
Both patches look good. The :manpage: directives are correct Sphinx docparse syntax, the unused <errno.h> removal is clean, and the SAFE_MMAP continuation line is now properly tab-indented.
---
Note:
Our agent completed the review of the patch. The full review can be found at: https://github.com/linux-test-project/ltp-agent/actions/runs/26367328648
The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Andrea Cervesato via ltp
Reviewed-by Andrea Cervesato--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Andrea Cervesato via ltp
AppliedMerged, Thanks!
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp