Skip to contentSkip to conversation

staging: rtl8723bs: rename camelcase variable bDumpRxPkt

PATCH In review Anirban Bose 2 participants 3 messages May 25 – Jul 10 Staging

lore
Share & tools
lore

Anirban Bose

author
#0 lore raw

PATCH 1/1 staging: rtl8723bs: rename camelcase variable bDumpRxPkt

Rename the local variable 'bDumpRxPkt' to 'dump_rx_pkt' in validate_recv_frame() to resolve a checkpatch.pl CamelCase warning.

Signed-off-by Anirban Bose <[email protected]>
---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_recv.c +2 -2
index 86c5e2c4e7dd..808f67b61f77 100644
@@ -1447,7 +1447,7 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
 	u8 type;
 	u8 subtype;
 	signed int retval = _SUCCESS;
-	u8 bDumpRxPkt;
+	u8 dump_rx_pkt;
 
 	struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib;
 

@@ -1473,7 +1473,7 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
 	pattrib->mdata = GetMData(ptr);
 	pattrib->privacy = GetPrivacy(ptr);
 	pattrib->order = GetOrder(ptr);
-	rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(bDumpRxPkt));
+	rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(dump_rx_pkt));
 
 	switch (type) {
 	case WIFI_MGT_TYPE: /* mgnt */
Signature · 1 line
2.54.0
maintainer
#1 lore raw
Quoted 22 lines · Anirban Bose

Rename the local variable 'bDumpRxPkt' to 'dump_rx_pkt' in validate_recv_frame() to resolve a checkpatch.pl CamelCase warning.

Signed-off-by Anirban Bose <[email protected]>
---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_recv.c +1 -1
index 86c5e2c4e7dd..808f67b61f77 100644
@@ -1447,7 +1447,7 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
 	u8 type;
 	u8 subtype;
 	signed int retval = _SUCCESS;
-	u8 bDumpRxPkt;
+	u8 dump_rx_pkt;
 
 	struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib;

drivers/staging/rtl8723bs/core/rtw_recv.c static signed int validate_recv_frame(struct adapter *adapter, union recv_frame · line 1476

Quoted 5 lines
drivers/staging/rtl8723bs/core/rtw_recv.c +1 -1
@@ -1473,7 +1473,7 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
 	pattrib->mdata = GetMData(ptr);
 	pattrib->privacy = GetPrivacy(ptr);
 	pattrib->order = GetOrder(ptr);
-	rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(bDumpRxPkt));
+	rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(dump_rx_pkt));

If this is never used, why is it set at all?

thanks,

greg k-h

author
#2 lore raw

PATCH v2 1/1 staging: rtl8723bs: remove unused variable bDumpRxPkt

In reply to Anirban Bose

The 'bDumpRxPkt' variable is declared validate_recv_frame() function and some debug information is written into it by rtw_hal_get_def_var() but as I have checked it, it is not used anywhere else in the function so its basically a useless variable now.

I have remove the variable and its assignment in the function.

Signed-off-by Anirban Bose <[email protected]>

---
v2:
- I removed it after checking it as pointed out by greg, instead of renaming it

---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_recv.c +0 -2
index 6bb119a83036..2f6c9967805c 100644
@@ -1447,7 +1447,6 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
 	u8 type;
 	u8 subtype;
 	signed int retval = _SUCCESS;
-	u8 bDumpRxPkt;
 
 	struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib;
 

@@ -1473,7 +1472,6 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
 	pattrib->mdata = GetMData(ptr);
 	pattrib->privacy = GetPrivacy(ptr);
 	pattrib->order = GetOrder(ptr);
-	rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(bDumpRxPkt));
 
 	switch (type) {
 	case WIFI_MGT_TYPE: /* mgnt */
Signature · 1 line
2.53.0