PCI: hotplug: compaq: fix X86 dependency
PATCH v2 1/1 PCI: hotplug: compaq: fix X86 dependency
This driver needs X86_32, not X86. It does not compile on x86_64 because of invalid assembly there.
---
v2: use X86_32
drivers/pci/hotplug/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/hotplug/Kconfig +1 -1
@@ -20,7 +20,7 @@ if HOTPLUG_PCI config HOTPLUG_PCI_COMPAQ tristate "Compaq PCI Hotplug driver" - depends on X86 && PCI_BIOS + depends on X86_32 && PCI_BIOS help Say Y here if you have a motherboard with a Compaq PCI Hotplug controller.
Signature · 1 line
2.54.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The commit introduces a redundant X86_32 dependency and the commit message falsely claims it…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit introduces a redundant X86_32 dependency and the commit message falsely claims it fixes an x86_64 compilation failure. --
commit 2f32c0aa3739414d8be655780c2734e155b45ea8
Author: Rosen Penev <[email protected]>
PCI: hotplug: compaq: fix X86 dependency
This commit restricts the HOTPLUG_PCI_COMPAQ Kconfig dependency from X86 to X86_32. The commit message indicates this is to prevent x86_64 build failures caused by invalid assembly.
Quoted 2 lines
This driver needs
X86_32, not X86. It does not compile onx86_64because of invalid assembly there.
[Severity: Medium]
Is this description accurate?
HOTPLUG_PCI_COMPAQ already depends on PCI_BIOS. In arch/x86/Kconfig, config PCI_BIOS is defined with depends on X86_32.
Because of this dependency, the driver could not be selected or compiled on x86_64 even before this patch. Could the commit message be updated to reflect this?
drivers/pci/hotplug/Kconfig if HOTPLUG_PCI · line 23
Quoted 10 lines
drivers/pci/hotplug/Kconfig +1
-1@@ -20,7 +20,7 @@ if HOTPLUG_PCI config HOTPLUG_PCI_COMPAQ tristate "Compaq PCI Hotplug driver" - depends on X86 && PCI_BIOS + depends on X86_32 && PCI_BIOS
[Severity: Medium]
Does this introduce a redundant check?
Since PCI_BIOS already restricts the build to X86_32, changing X86 to X86_32 appears to provide no functional difference.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 3 lines · On Mon, May 25, 2026 at 9:41 PM <[email protected]> wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit introduces a redundantX86_32dependency and the commit message falsely claims it fixes anx86_64compilation failure.
Which is accurate. This should not build on x86_64.
Quoted 42 lines
--
commit
2f32c0aa3739414d8be655780c2734e155b45ea8
Author: Rosen Penev <[email protected]>
PCI: hotplug: compaq: fix X86 dependencyThis commit restricts the
HOTPLUG_PCI_COMPAQKconfigdependency from X86 toX86_32. The commit message indicates this is to preventx86_64build failures caused by invalid assembly.Quoted 2 lines
This driver needs
X86_32, not X86. It does not compile onx86_64because of invalid assembly there.[Severity: Medium]
Is this description accurate?
HOTPLUG_PCI_COMPAQalready depends onPCI_BIOS. Inarch/x86/Kconfig, configPCI_BIOSis defined with depends onX86_32.Because of this dependency, the driver could not be selected or compiled on
x86_64even before this patch. Could the commit message be updated to reflect this?drivers/pci/hotplug/Kconfig if HOTPLUG_PCI · line 23
Quoted 10 lines
drivers/pci/hotplug/Kconfig +1
-1@@ -20,7 +20,7 @@ if HOTPLUG_PCI config HOTPLUG_PCI_COMPAQ tristate "Compaq PCI Hotplug driver" - depends on X86 && PCI_BIOS + depends on X86_32 && PCI_BIOS[Severity: Medium]
Does this introduce a redundant check?Since
PCI_BIOSalready restricts the build toX86_32, changing X86 toX86_32appears to provide no functional difference.--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1