reset: ast: Use dev_read_addr_ptr()
PATCH 1/1 reset: ast: Use dev_read_addr_ptr()
From: Peng Fan <[email protected]>
Use dev_read_addr_ptr() which supports both live device tree and flat DT backends, avoiding direct dependency on devfdt_* helpers.
While at here, correct error return value, when priv->scu is NULL, PTR_ERR(priv->scu) is 0 which implies success. Change to return '-EINVAL'.
No functional changes.
Signed-off-by Peng Fan <[email protected]>
--- drivers/reset/reset-ast2500.c | 4 ++-- drivers/reset/reset-ast2600.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/reset/reset-ast2500.c +2 -2
@@ -77,10 +77,10 @@ static int ast2500_reset_probe(struct udevice *dev)return rc; } - priv->scu =devfdt_get_addr_ptr (scu_dev); + priv->scu =dev_read_addr_ptr (scu_dev);if (IS_ERR_OR_NULL (priv->scu)) {debug ("%s: invalid SCU base pointer\n" , __func__); -return PTR_ERR (priv->scu); +return -EINVAL ; }return 0 ;
drivers/reset/reset-ast2600.c +2 -2
@@ -76,10 +76,10 @@ static int ast2600_reset_probe(struct udevice *dev)return rc; } - priv->scu =devfdt_get_addr_ptr (scu_dev); + priv->scu =dev_read_addr_ptr (scu_dev);if (IS_ERR_OR_NULL (priv->scu)) {debug ("%s: invalid SCU base pointer\n" , __func__); -return PTR_ERR (priv->scu); +return -EINVAL ; }return 0 ;
Signature · 1 line
2.51.0
Quoted 9 lines · On Tue, 26 May 2026 14:48:01 +0800, [email protected] wrote:
Use
dev_read_addr_ptr()which supports both live device tree and flat DT backends, avoiding direct dependency on devfdt_* helpers.While at here, correct error return value, when
priv->scuis NULL,PTR_ERR(priv->scu)is 0 which implies success. Change to return '-EINVAL'.No functional changes.
[...]
Applied to u-boot/next, thanks!
[1/1] reset: ast: Use dev_read_addr_ptr()
commit: 305c014fdb7208ced179e47dc3634e7faa6a2502
Signature · 1 line
Tom