Skip to contentSkip to conversation

leds: fix CONFIG_OF dependency for LEDS_LP5860_CORE

PATCH Applied Arnd Bergmann 2 participants 2 messages May 26 – Jun 4

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 leds: fix CONFIG_OF dependency for LEDS_LP5860_CORE

From: Arnd Bergmann <[email protected]>

Building LEDS_LP5860_SPI wihtout CONFIG_OF leads to a build time warning:

WARNING: unmet direct dependencies detected for LEDS_LP5860_CORE
Depends on [n]: NEW_LEDS [=y] && LEDS_CLASS_MULTICOLOR [=y] && LEDS_CLASS [=y] && OF [=n] Selected by [y]:
- LEDS_LP5860_SPI [=y] && NEW_LEDS [=y] && LEDS_CLASS_MULTICOLOR [=y] && SPI [=y]

Address this by adding the same dependency here as well.

Fixes 3daf2c4ef82b ("leds: Add support for TI LP5860 LED driver chip")

---
Another option would be to change the 'select LEDS_LP5860_CORE' to a 'depends on'.

---
 drivers/leds/rgb/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/leds/rgb/Kconfig +1 -0
index 9a4ba6531cf8..b582ba2363af 100644
@@ -56,6 +56,7 @@ config LEDS_LP5860_CORE
 config LEDS_LP5860_SPI
 	tristate "LED Support for TI LP5860 SPI LED driver chip"
 	depends on SPI
+	depends on OF
 	select LEDS_LP5860_CORE
 	help
 	  If you say yes here you get support for the Texas Instruments
Signature · 1 line
2.39.5
maintainer Applied
#1 lore raw

Re: (subset) [PATCH] leds: fix CONFIG_OF dependency for LEDS_LP5860_CORE

Quoted 8 lines · Arnd Bergmann

Building LEDS_LP5860_SPI wihtout CONFIG_OF leads to a build time warning:

WARNING: unmet direct dependencies detected for LEDS_LP5860_CORE
Depends on [n]: NEW_LEDS [=y] && LEDS_CLASS_MULTICOLOR [=y] && LEDS_CLASS [=y] && OF [=n] Selected by [y]:
- LEDS_LP5860_SPI [=y] && NEW_LEDS [=y] && LEDS_CLASS_MULTICOLOR [=y] && SPI [=y]

[...]

Applied, thanks!

[1/1] leds: fix CONFIG_OF dependency for LEDS_LP5860_CORE

      commit: a2263676302a4eec40af93b3829f1d3d5aade93c

--
Lee Jones [李琼斯]