MIPS: ath79: pci: remove
PATCH 1/1 MIPS: ath79: pci: remove
Commit 85b9686dae30 ("MIPS: ath79: drop platform device registration code") removed the ability for anything to bind to these drivers and use them. Meaning as is, these drivers cannot be used.
Downstream OpenWrt has hack patches that add the missing OF stuff but those are not suitable for upstream.
The current plan is to rewrite these drivers using newer APIs and have them live under drivers/pci/controller. But as for these, axe them.
--- arch/mips/ath79/Kconfig | 7 - arch/mips/pci/Makefile | 2 - arch/mips/pci/pci-ar71xx.c | 401 --------------------------------- arch/mips/pci/pci-ar724x.c | 447 ------------------------------------- 4 files changed, 857 deletions(-) delete mode 100644 arch/mips/pci/pci-ar71xx.c delete mode 100644 arch/mips/pci/pci-ar724x.c
arch/mips/ath79/Kconfig +0 -7
@@ -7,7 +7,6 @@ config SOC_AR71XX config SOC_AR724X select HAVE_PCI - select PCI_AR724X if PCI def_bool n config SOC_AR913X
@@ -18,15 +17,9 @@ config SOC_AR933X config SOC_AR934X select HAVE_PCI - select PCI_AR724X if PCI def_bool n config SOC_QCA955X select HAVE_PCI - select PCI_AR724X if PCI def_bool n - -config PCI_AR724X - def_bool n - endif
arch/mips/pci/Makefile +0 -2
@@ -19,8 +19,6 @@ obj-$(CONFIG_BCM63XX) += pci-bcm63xx.o fixup-bcm63xx.o \ ops-bcm63xx.o obj-$(CONFIG_MIPS_ALCHEMY) += pci-alchemy.o obj-$(CONFIG_PCI_AR2315) += pci-ar2315.o -obj-$(CONFIG_SOC_AR71XX) += pci-ar71xx.o -obj-$(CONFIG_PCI_AR724X) += pci-ar724x.o obj-$(CONFIG_PCI_XTALK_BRIDGE) += pci-xtalk-bridge.o # # These are still pretty much in the old state, watch, go blind.
arch/mips/pci/pci-ar71xx.c deleted +0 -401
401 lines not on this page · raw message
arch/mips/pci/pci-ar724x.c deleted +0 -447
447 lines not on this page · raw message
Signature · 1 line
2.54.0
Thomas Bogendoerfer
maintainerQuoted 1 line · Rosen Penev
Commit
85b9686dae30("MIPS: ath79: drop platform device registration code")
this commit doesn't do anything with pci at all. Do you mean commit 73d8e6aa7d20 ("MIPS: ath79: drop legacy pci code") ?
Quoted 8 lines
removed the ability for anything to bind to these drivers and use them. Meaning as is, these drivers cannot be used.
Downstream OpenWrt has hack patches that add the missing OF stuff but those are not suitable for upstream.
The current plan is to rewrite these drivers using newer APIs and have them live under
drivers/pci/controller. But as for these, axe them.
wouldn't it make more sense to revert the commit above and remove it after the change to a new pci implementation is really done ?
Thomas.
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
Quoted 6 lines · Thomas Bogendoerfer
Quoted 1 line · Rosen Penev
Commit
85b9686dae30("MIPS: ath79: drop platform device registration code")this commit doesn't do anything with pci at all. Do you mean commit
73d8e6aa7d20("MIPS: ath79: drop legacy pci code") ?
Yes
Quoted 4 lines
Quoted 4 lines
removed the ability for anything to bind to these drivers and use them. Meaning as is, these drivers cannot be used.
Quoted 8 lines
Quoted 5 lines
Downstream OpenWrt has hack patches that add the missing OF stuff but those are not suitable for upstream.
The current plan is to rewrite these drivers using newer APIs and have them live under
drivers/pci/controller. But as for these, axe them.wouldn't it make more sense to revert the commit above and remove it after the change to a new pci implementation is really done ?
Why revert then remove? Even if that commit was reverted it's still unusable. ath79 is OF only now.
Quoted 6 lines
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]