Skip to contentSkip to conversation

pinctrl: tegra238: remove unused entries

PATCH In review Arnd Bergmann 2 participants 2 messages May 29

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: tegra238: remove unused entries

From: Arnd Bergmann <[email protected]>

The -Wunused-const-variable check points out a number of added entries that are currently not referenced:

drivers/pinctrl/tegra/pinctrl-tegra238.c:1169:27: error: 'soc_gpio86_phh3_pins' defined but not used [-Werror=unused-const-variable=]

 1169 | static const unsigned int soc_gpio86_phh3_pins[] = {
      |                           ^~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra238.c:1165:27: error: 'uart5_cts_phh2_pins' defined but not used [-Werror=unused-const-variable=]
 1165 | static const unsigned int uart5_cts_phh2_pins[] = {
      |                           ^~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra238.c:1161:27: error: 'uart5_rts_phh1_pins' defined but not used [-Werror=unused-const-variable=]
 1161 | static const unsigned int uart5_rts_phh1_pins[] = {
      |                           ^~~~~~~~~~~~~~~~~~~

Remove them for now, they can just be added back if they get used in the future.

Fixes 25cac7292d49 ("pinctrl: tegra: Add Tegra238 pinmux driver")
---
 drivers/pinctrl/tegra/pinctrl-tegra238.c | 96 ------------------------
 1 file changed, 96 deletions(-)
drivers/pinctrl/tegra/pinctrl-tegra238.c +0 -96
index 421da334151c..c765b6b880e5 100644
@@ -1074,102 +1074,6 @@ static const unsigned int pwm7_pee1_pins[] = {
 	TEGRA_PIN_PWM7_PEE1,
 };
 
-static const unsigned int soc_gpio49_pee2_pins[] = {
-	TEGRA_PIN_SOC_GPIO49_PEE2,
-};
-
-static const unsigned int soc_gpio82_pee3_pins[] = {
-	TEGRA_PIN_SOC_GPIO82_PEE3,
-};
-
-static const unsigned int soc_gpio50_pee4_pins[] = {
-	TEGRA_PIN_SOC_GPIO50_PEE4,
-};
-
-static const unsigned int soc_gpio83_pee5_pins[] = {
-	TEGRA_PIN_SOC_GPIO83_PEE5,
-};
-
-static const unsigned int soc_gpio69_pff0_pins[] = {
-	TEGRA_PIN_SOC_GPIO69_PFF0,
-};
-
-static const unsigned int soc_gpio70_pff1_pins[] = {
-	TEGRA_PIN_SOC_GPIO70_PFF1,
-};
-
-static const unsigned int soc_gpio71_pff2_pins[] = {
-	TEGRA_PIN_SOC_GPIO71_PFF2,
-};
-
-static const unsigned int soc_gpio72_pff3_pins[] = {
-	TEGRA_PIN_SOC_GPIO72_PFF3,
-};
-
-static const unsigned int soc_gpio73_pff4_pins[] = {
-	TEGRA_PIN_SOC_GPIO73_PFF4,
-};
-
-static const unsigned int soc_gpio74_pff5_pins[] = {
-	TEGRA_PIN_SOC_GPIO74_PFF5,
-};
-
-static const unsigned int soc_gpio80_pff6_pins[] = {
-	TEGRA_PIN_SOC_GPIO80_PFF6,
-};
-
-static const unsigned int soc_gpio76_pff7_pins[] = {
-	TEGRA_PIN_SOC_GPIO76_PFF7,
-};
-
-static const unsigned int soc_gpio77_pgg0_pins[] = {
-	TEGRA_PIN_SOC_GPIO77_PGG0,
-};
-
-static const unsigned int soc_gpio84_pgg1_pins[] = {
-	TEGRA_PIN_SOC_GPIO84_PGG1,
-};
-
-static const unsigned int uart2_tx_pgg2_pins[] = {
-	TEGRA_PIN_UART2_TX_PGG2,
-};
-
-static const unsigned int uart2_rx_pgg3_pins[] = {
-	TEGRA_PIN_UART2_RX_PGG3,
-};
-
-static const unsigned int uart2_rts_pgg4_pins[] = {
-	TEGRA_PIN_UART2_RTS_PGG4,
-};
-
-static const unsigned int uart2_cts_pgg5_pins[] = {
-	TEGRA_PIN_UART2_CTS_PGG5,
-};
-
-static const unsigned int soc_gpio85_pgg6_pins[] = {
-	TEGRA_PIN_SOC_GPIO85_PGG6,
-};
-
-static const unsigned int uart5_tx_pgg7_pins[] = {
-	TEGRA_PIN_UART5_TX_PGG7,
-};
-
-static const unsigned int uart5_rx_phh0_pins[] = {
-	TEGRA_PIN_UART5_RX_PHH0,
-};
-
-static const unsigned int uart5_rts_phh1_pins[] = {
-	TEGRA_PIN_UART5_RTS_PHH1,
-};
-
-static const unsigned int uart5_cts_phh2_pins[] = {
-	TEGRA_PIN_UART5_CTS_PHH2,
-};
-
-static const unsigned int soc_gpio86_phh3_pins[] = {
-	TEGRA_PIN_SOC_GPIO86_PHH3,
-};
-
 static const unsigned int sdmmc1_comp_pins[] = {
 	TEGRA_PIN_SDMMC1_COMP,
 };
Signature · 1 line
2.39.5
maintainer
#1 lore raw
Quoted 4 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The -Wunused-const-variable check points out a number of added entries that are currently not referenced:

Patch applied.

I guess these entries actually exist in the hardware though, they have just not been attached to groups.

But it's easy to just restore this when needed so no big deal.

Yours,
Linus Walleij