Skip to contentSkip to conversation

usb: xhci: Improve Soft Retries after short transfers

PATCH In review Michal Pecio 2 participants 2 messages May 29 – Jun 1

Subsystems (2)
USB USB xHCI driver
lore
Share & tools
lore

Michal Pecio

author
#0 lore raw

PATCH 1/1 usb: xhci: Improve Soft Retries after short transfers

A short transfer is a successful one, so reset the error count. Otherwise, endpoints which always complete short are limited to three retries per endpoint life rather than per URB.

Signed-off-by Michal Pecio <[email protected]>
---
 drivers/usb/host/xhci-ring.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/host/xhci-ring.c +1 -0
index f0f66e18f174..a067e56d720d 100644
@@ -2544,6 +2544,7 @@ static void process_bulk_intr_td(struct xhci_hcd *xhci, struct xhci_virt_ep *ep,
 		td->status = 0;
 		break;
 	case COMP_SHORT_PACKET:
+		ep->err_count = 0;
 		td->status = 0;
 		break;
 	case COMP_STOPPED_SHORT_PACKET:
Signature · 1 line
2.48.1
#1 lore raw
Quoted 5 lines · Michal Pecio

A short transfer is a successful one, so reset the error count. Otherwise, endpoints which always complete short are limited to three retries per endpoint life rather than per URB.

Signed-off-by Michal Pecio <[email protected]>

Added, Thanks

-Mathias