geneve: fix length used in GRO hint UDP checksum adjustment
Subsystems (2)
PATCH 1/1 geneve: fix length used in GRO hint UDP checksum adjustment
In geneve_post_decap_hint the length used for adjusting the UDP checksum should be 'skb->len - gro_hint->nested_tp_offset' (UDP length) instead of 'skb->len - gro_hint->nested_nh_offset' (IP length).
--- drivers/net/geneve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/geneve.c +1 -1
@@ -632,7 +632,7 @@ static int geneve_post_decap_hint(const struct sock *sk, struct sk_buff *skb, uh =udp_hdr (skb); uh->len =htons (skb->len - gro_hint->nested_tp_offset);if (uh->check) { - len = skb->len - gro_hint->nested_nh_offset; + len = skb->len - gro_hint->nested_tp_offset;skb_shinfo (skb)->gso_type |=SKB_GSO_UDP_TUNNEL_CSUM ;if (gro_hint->nested_is_v6) uh->check = ~udp_v6_check(len, &ipv6h->saddr,
Signature · 1 line
2.54.0
Quoted 9 lines · Antoine Tenart
In
geneve_post_decap_hintthe length used for adjusting the UDP checksum should be 'skb->len-gro_hint->nested_tp_offset' (UDP length) instead of 'skb->len-gro_hint->nested_nh_offset' (IP length).Fixes fd0dd796576e ("geneve: use GRO hint option in the RX path")Cc Paolo Abeni <[email protected]>Reported-by Sashiko <[email protected]>Signed-off-by Antoine Tenart <[email protected]>
FTR, an AI-generated review of this patch is available on sashiko.dev. I do not believe that needs to be addressed in the context of this patch.
This patch was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <[email protected]>:
Quoted 11 lines · On Fri, 29 May 2026 16:47:00 +0200 you wrote:
In
geneve_post_decap_hintthe length used for adjusting the UDP checksum should be 'skb->len-gro_hint->nested_tp_offset' (UDP length) instead of 'skb->len-gro_hint->nested_nh_offset' (IP length).Fixes fd0dd796576e ("geneve: use GRO hint option in the RX path")Cc Paolo Abeni <[email protected]>Reported-by Sashiko <[email protected]>Signed-off-by Antoine Tenart <[email protected]>[...]
Here is the summary with links:
- [net] geneve: fix length used in GRO hint UDP checksum adjustment
https://git.kernel.org/netdev/net/c/1231623fd3b5
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html