Skip to contentSkip to conversation

kbuild: clean `*.long-type-*.txt` files

PATCH In review Joel Kamminga 2 participants 2 messages May 29 – May 30

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 kbuild: clean `*.long-type-*.txt` files

This cleans up files generated by rustc compiler in the case of an error containing an excessively long type name that doesn't fit in a single line. Such types appear relatively frequently so the risk of generating these files certainly exists. These files are purely compiler artifacts and are not created intentionally by the build system. They should be added to the clean target to stop from cluttering up the source tree.

---
 Makefile | 1 +
 1 file changed, 1 insertion(+)
Makefile +1 -0
index 9f59598d3a08..3a265e7e3347 100644
@@ -2164,6 +2164,7 @@ clean: $(clean-dirs)
 		-o -name '*.c.[012]*.*' \
 		-o -name '*.ll' \
 		-o -name '*.gcno' \
+		-o -name '*.long-type-*.txt' \
 		\) -type f -print \
 		-o -name '.tmp_*' -print \
 		| xargs rm -rf
Signature · 1 line
2.54.0
#1 lore raw
Quoted 8 lines · Joel Kamminga

This cleans up files generated by rustc compiler in the case of an error containing an excessively long type name that doesn't fit in a single line. Such types appear relatively frequently so the risk of generating these files certainly exists. These files are purely compiler artifacts and are not created intentionally by the build system. They should be added to the clean target to stop from cluttering up the source tree.

Normally, we try to use the imperative for the actual change in commit messages, i.e. "as if you are giving orders to the codebase to change its behaviour":

https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

I would also probably add "rust: " after "kbuild: " in the title to scope it a bit more, since these files are rustc's ones.

Otherwise, it looks good, thanks! :)

I can take this through Rust since I have Manos' there too, unless others prefer otherwise.

Cheers,
Miguel