dt-bindings: usb: convert PXA USB bindings to YAML

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The marvell,pxa-ohci.yaml schema omits the vbus1-supply, vbus2-supply, and vbus3-supply properties but enforces unevaluatedProperties: false, which will cause valid device trees to fail schema validation. --

commit 78f580ae03eab5d588221a2a8289471c77c1c517
Author: Jeremiah Bishop <[email protected]>

dt-bindings: usb: convert PXA USB bindings to YAML

This commit converts the legacy pxa-usb.txt binding documentation to YAML schemas. It splits the documentation into marvell,pxa-ohci.yaml and marvell,pxa270-udc.yaml to provide machine-readable validation for both the host and device controllers.

Quoted 5 lines

Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml new file +0 -0

new file mode 100644
index 0000000000000..3f7935384b9f5

[ ... ]

Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml line 80

Quoted 7 lines

Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml new file +7 -0

+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+
+unevaluatedProperties: false

[Severity: Medium]
Will this strict validation reject valid device trees that provide vbus regulators?

The PXA OHCI driver in drivers/usb/host/ohci-pxa27x.c explicitly calls devm_regulator_get() for "vbus1", "vbus2", and "vbus3" for enabled ports. These requests resolve to the vbus1-supply, vbus2-supply, and vbus3-supply properties in the device tree.

Because these properties are not defined in this schema or inherited from usb-hcd.yaml, and unevaluatedProperties is set to false, it appears that any device tree describing the vbus supplies will falsely fail the dt_binding_check validation.

Could these supply properties be added to the schema to prevent validation errors for existing users?

Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml line 83

Quoted 3 lines

Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml new file +3 -0

+
+examples:
+  - |

[ ... ]

--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1

Convert the legacy pxa-usb.txt binding documentation to YAML schemas.

The original text binding documented two distinct devices: the PXA OHCI USB host controller and the PXA270 USB device controller. Split the documentation into separate schemas, marvell,pxa-ohci.yaml and marvell,pxa270-udc.yaml, and remove the obsolete text binding.

The schemas preserve the existing compatible strings and properties used by current in-tree users while adding machine-readable validation and examples.

Signed-off-by Jeremiah Bishop <[email protected]>

---
Changes in v2:
- Add vbus1-supply, vbus2-supply, and vbus3-supply properties to the PXA OHCI schema.

 .../bindings/usb/marvell,pxa-ohci.yaml        | 100 ++++++++++++++++++
 .../bindings/usb/marvell,pxa270-udc.yaml      |  50 +++++++++
 .../devicetree/bindings/usb/pxa-usb.txt       |  53 ----------
 3 files changed, 150 insertions(+), 53 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml
 create mode 100644 Documentation/devicetree/bindings/usb/marvell,pxa270-udc.yaml
 delete mode 100644 Documentation/devicetree/bindings/usb/pxa-usb.txt

Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml new file +1 -0

new file mode 100644
index 000000000000..5d660b92d3cb
@@ -0,0 +1,100 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml new file +35 -0

+
+allOf:
+  - $ref: usb-hcd.yaml#
+
+properties:
+  compatible:
+    const: marvell,pxa-ohci
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  marvell,enable-port1:
+    type: boolean
+    description: Enable USB port 1 if present.
+
+  marvell,enable-port2:
+    type: boolean
+    description: Enable USB port 2 if present.
+
+  marvell,enable-port3:
+    type: boolean
+    description: Enable USB port 3 if present.> +
+  marvell,port-sense-low:
+    type: boolean
+    description: Port sense pin in low-active.
+
+  marvell,power-control-low:
+    type: boolean
+    description: Power control pin is low-active.

Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml new file +5 -0

+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: Power On to Power Good time in milliseconds.
+
+  marvell,port-mode:
+    $ref: /schemas/types.yaml#/definitions/uint32

Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml new file +13 -0

+
+unevaluatedProperties: false
+
+examples:
+  - |
+    usb@4c000000 {
+        compatible = "marvell,pxa-ohci";
+        reg = <0x4c000000 0x100000>;
+        interrupts = <3>;
+        clocks = <&clks 11>;
+        marvell,enable-port1;
+        marvell,port-mode = <2>; /* PMM_GLOBAL_MODE */
+    };

Documentation/devicetree/bindings/usb/marvell,pxa270-udc.yaml new file +0 -0

new file mode 100644
index 000000000000..0be51e0db80b

Documentation/devicetree/bindings/usb/marvell,pxa270-udc.yaml new file +10 -0

+
+properties:
+  compatible:
+    const: marvell,pxa270-udc
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1