dmaengine: dmatest: split struct dmatest_info from variable declaration
PATCH 1/1 dmaengine: dmatest: split struct dmatest_info from variable declaration
Combining the struct definition with its variable initializer confuses the kernel-doc parser because __MUTEX_INITIALIZER() expands to contain braces, breaking brace counting and causing:
Warning: drivers/dma/dmatest.c:152 struct member '' not described in 'dmatest_info'
Split into separate struct definition and variable declaration, which is the standard kernel pattern.
--- drivers/dma/dmatest.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/dma/dmatest.c +4 -2
@@ -137,7 +137,7 @@ struct dmatest_params {* @did_init: module has been initialized completely * @last_error: test has faced configuration issues */ -static struct dmatest_info { +struct dmatest_info {/* Test parameters */ struct dmatest_params params;
@@ -147,7 +147,9 @@ static struct dmatest_info {int last_error;struct mutex lock;bool did_init; -} test_info = { +}; + +static struct dmatest_info test_info = { .channels =LIST_HEAD_INIT (test_info.channels), .lock =__MUTEX_INITIALIZER (test_info.lock), };
--
2.54.0
Quoted 10 lines · Rosen Penev
Combining the struct definition with its variable initializer confuses the kernel-doc parser because
__MUTEX_INITIALIZER()expands to contain braces, breaking brace counting and causing:Warning:
drivers/dma/dmatest.c:152struct member '' not described in 'dmatest_info'Split into separate struct definition and variable declaration, which is the standard kernel pattern.
[...]
Applied, thanks!
[1/1] dmaengine: dmatest: split struct dmatest_info from variable declaration
commit: 87aab0781cb35baa2214d0a95ff01e786e428226
Best regards,
Signature · 1 line
~Vinod