Skip to contentSkip to conversation

Documentation: ABI: remove outdated USB power/level removal notice

PATCH In review Sardaruddin Syed 3 participants 4 messages May 30 – Jun 4 1 message not in the archive USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: ABI: remove outdated USB power/level removal notice

The sysfs power/level interface is still implemented and documented despite the removal notice stating it would be removed after 2010.

Remove the outdated removal timeline while keeping the deprecation notice and recommendation to use power/control instead.

---
 Documentation/ABI/obsolete/sysfs-bus-usb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/ABI/obsolete/sysfs-bus-usb +1 -1
index bd096d33fbc7..067016e62e11 100644
@@ -26,6 +26,6 @@ Description:
 		initializes all non-hub devices in the "on" level.  Some
 		drivers may change this setting when they are bound.
 
-		This file is deprecated and will be removed after 2010.
+		This file is deprecated.
 		Use the power/control file instead; it does exactly the
 		same thing.
Signature · 1 line
2.43.0
#1 lore raw
Quoted 16 lines · Sardaruddin Syed

The sysfs power/level interface is still implemented and documented despite the removal notice stating it would be removed after 2010.

Remove the outdated removal timeline while keeping the deprecation notice and recommendation to use power/control instead.

---
 Documentation/ABI/obsolete/sysfs-bus-usb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/ABI/obsolete/sysfs-bus-usb +0 -0
index bd096d33fbc7..067016e62e11 100644

Documentation/ABI/obsolete/sysfs-bus-usb Description: · line 31

Quoted 7 lines
Documentation/ABI/obsolete/sysfs-bus-usb +1 -1
@@ -26,6 +26,6 @@ Description:
 		initializes all non-hub devices in the "on" level.  Some
 		drivers may change this setting when they are bound.
 
-		This file is deprecated and will be removed after 2010.
+		This file is deprecated.
 		Use the power/control file instead; it does exactly the
 		same thing.

Why not just remove it instead?

thanks,

greg k-h

A message that is not in the archive (sent off-list or not yet received): CAEUfWQg7msH_qsER7nL5_855puJYsj4ztT+DrRThfbih8TObnw@mail.gmail.com

#3 lore raw

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

Quoted 4 lines · SARDARUDDIN SYED

Hi Greg,

I looked into the history and current implementation of power/level.

Quoted 8 lines

The attribute is still implemented in drivers/usb/core/sysfs.c and is still documented as a deprecated interface. The obsolete ABI entry was added when power/level was deprecated in favor of power/control, but the interface itself remains present.

I wasn't sure whether you meant removing the obsolete documentation entry or removing the deprecated interface itself, so I wanted to clarify before sending a v2.

Why not remove both?

thanks,

greg k-h

#4 lore raw
Quoted 7 lines · Greg KH
Quoted 7 lines

I looked into the history and current implementation of power/level.

The attribute is still implemented in drivers/usb/core/sysfs.c and is still documented as a deprecated interface. The obsolete ABI entry was added when power/level was deprecated in favor of power/control, but the interface itself remains present.

Quoted 5 lines
Quoted 3 lines

I wasn't sure whether you meant removing the obsolete documentation entry or removing the deprecated interface itself, so I wanted to clarify before sending a v2.

Why not remove both?

Won't that break stuff for anyone still using the power/level attribute? Time has proved that no one cares about deprecation warnings.

Why not implement Alans original wish in commit a90309860b09 ("USB:
deprecate the power/level sysfs attribute") instead:

It would be nice to replace power/level with a symlink to power/control, but at the moment sysfs doesn't offer any way to do so.

I believe this has been possible since commit 9255782f7061 ("sysfs: Wrap __compat_only_sysfs_link_entry_to_kobj function to change the symlink name")

Bjørn