Bluetooth: fix memory leak in error path of hci_alloc_dev()
Subsystems (2)
PATCH v3 1/1 Bluetooth: fix memory leak in error path of hci_alloc_dev()
Early failures in Bluetooth HCI UART configuration leak SRCU percpu memory.
When device initialization fails before hci_register_dev() completes, the HCI_UNREGISTER flag is never set. As a result, when the device reference count reaches zero, bt_host_release() evaluates this flag as false and falls back to a direct kfree(hdev).
Because hci_release_dev() is bypassed, the SRCU struct initialized early in hci_alloc_dev() is never cleaned up, resulting in a leak of percpu memory.
Fix the leak by explicitly calling cleanup_srcu_struct() in the fallback (unregistered) branch of bt_host_release() before freeing the device.
Reported-by [email protected]
Tested-by [email protected]
Fixes 1d6123102e9f ("Bluetooth: hci_core: Fix use-after-free in vhci_flush()")
Signed-off-by Bharath Reddy <[email protected]>
--- net/bluetooth/hci_sysfs.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
net/bluetooth/hci_sysfs.c +4 -2
@@ -83,10 +83,12 @@ static void bt_host_release(struct device *dev) {struct hci_dev *hdev =to_hci_dev (dev); -if (hci_dev_test_flag (hdev,HCI_UNREGISTER )) +if (hci_dev_test_flag (hdev,HCI_UNREGISTER )) {hci_release_dev (hdev); -else + }else { +cleanup_srcu_struct (&hdev->srcu);kfree (hdev); + }module_put (THIS_MODULE ); }
Signature · 1 line
2.34.1