ata: pata_ep93xx: add missing "cc" clobber to inline asm
PATCH 1/1 ata: pata_ep93xx: add missing "cc" clobber to inline asm
The inline assembly in ep93xx_pata_delay() uses a "subs" instruction which modifies the ARM condition code flags. Add a "cc" clobber so the compiler knows the flags are altered. Without it, the compiler may reorder flag-dependent instructions across the asm block when the function is inlined, potentially causing incorrect control flow.
--- drivers/ata/pata_ep93xx.c | 1 + 1 file changed, 1 insertion(+)
drivers/ata/pata_ep93xx.c +1 -0
@@ -211,6 +211,7 @@ static void ep93xx_pata_delay(unsigned long count) "bge 0b\n" : "=r" (count) : "0" (count) + : "cc" ); }
Signature · 1 line
2.54.0
Quoted 9 lines · Rosen Penev
The inline assembly in
ep93xx_pata_delay()uses a "subs" instruction which modifies the ARM condition code flags. Add a "cc" clobber so the compiler knows the flags are altered. Without it, the compiler may reorder flag-dependent instructions across the asm block when the function is inlined, potentially causing incorrect control flow.Assisted-by Opencode:Big-PickleSigned-off-by Rosen Penev <[email protected]>
should I resend?
Quoted 19 lines
--- drivers/ata/pata_ep93xx.c | 1 + 1 file changed, 1 insertion(+)drivers/ata/pata_ep93xx.c +1
-1@@ -211,6 +211,7 @@ static void ep93xx_pata_delay(unsigned long count) "bge 0b\n" : "=r" (count) : "0" (count) + : "cc" ); } --2.54.0
Damien Le Moal
maintainerQuoted 11 lines · Rosen Penev
Quoted 9 lines · Rosen Penev
The inline assembly in
ep93xx_pata_delay()uses a "subs" instruction which modifies the ARM condition code flags. Add a "cc" clobber so the compiler knows the flags are altered. Without it, the compiler may reorder flag-dependent instructions across the asm block when the function is inlined, potentially causing incorrect control flow.Assisted-by Opencode:Big-PickleSigned-off-by Rosen Penev <[email protected]>should I resend?
Oops. This fell through the cracks. Yes, please resend and add a fixes tag as well.
Signature · 2 lines
Damien Le Moal Western Digital Research