fuse: convert page array allocation to kcalloc()
Subsystems (2)
PATCH 1/1 fuse: convert page array allocation to kcalloc()
fuse_get_user_pages() allocates the temporary pages[] array used by iov_iter_extract_pages() with the open-coded kzalloc(n * sizeof(*p), ...) form. max_pages is derived from the inbound iov_iter and is not bounded at compile time, so the multiplication can overflow on sufficiently large iter counts; the resulting too-small allocation would then be written past by iov_iter_extract_pages().
Switch to kcalloc(), which carries the same zero-on-allocation semantics and adds the standard size_mul overflow check. No functional change for non-overflow inputs.
--- fs/fuse/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/fuse/file.c +1 -1
@@ -1586,7 +1586,7 @@ static int fuse_get_user_pages(struct fuse_args_pages *ap, struct iov_iter *ii,* manually extract pages using iov_iter_extract_pages() and then * copy that to a folios array. */ -struct page **pages =kzalloc (max_pages *sizeof (struct page *), +struct page **pages =kcalloc (max_pages,sizeof (struct page *),GFP_KERNEL );if (!pages) { ret = -ENOMEM ;
Signature · 1 line
2.54.0
Quoted 8 lines · William Theesfeld
fuse_get_user_pages()allocates the temporary pages[] array used byiov_iter_extract_pages()with the open-codedkzalloc(n * sizeof(*p), ...)form.max_pagesis derived from the inboundiov_iterand is not bounded at compile time, so the multiplication can overflow on sufficiently large iter counts; the resulting too-small allocation would then be written past byiov_iter_extract_pages().
Quoted 5 lines
Switch to
kcalloc(), which carries the same zero-on-allocation semantics and adds the standardsize_muloverflow check. No functional change for non-overflow inputs.Signed-off-by William Theesfeld <[email protected]>
Applied, thanks.
Miklos