Skip to contentSkip to conversation

fbdev: grvga: Fix CLUT register address offset in comment

PATCH Applied Eduardo Silva 2 participants 2 messages Jun 1 – Jun 4 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fbdev: grvga: Fix CLUT register address offset in comment

The comment does not match the actual address offset. According to the GRLIB IP Library Reference Manual (p. 2119), the CLUT register is at offset 0x28, not the value stated in the comment.

---
 drivers/video/fbdev/grvga.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/grvga.c +1 -1
index de8ab817d406..a6594bcd74e8 100644
@@ -33,7 +33,7 @@ struct grvga_regs {
 	u32 line_length;	/* 0x10 */
 	u32 fb_pos;		/* 0x14 */
 	u32 clk_vector[4];	/* 0x18 */
-	u32 clut;	        /* 0x20 */
+	u32 clut;	        /* 0x28 */
 };
 
 struct grvga_par {
Signature · 1 line
2.54.0
maintainer Applied
#1 lore raw
Quoted 8 lines · Eduardo Silva

The comment does not match the actual address offset. According to the GRLIB IP Library Reference Manual (p. 2119), the CLUT register is at offset 0x28, not the value stated in the comment.

---
  drivers/video/fbdev/grvga.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

applied.

Thanks!
Helge