fpga: dfl: dfl-fme-perf: check devm_kasprintf() return value
Subsystems (2)
PATCH 1/1 fpga: dfl: dfl-fme-perf: check devm_kasprintf() return value
fme_perf_pmu_register() passes the result of devm_kasprintf() straight into perf_pmu_register() as the PMU name without checking for NULL. devm_kasprintf() returns NULL on allocation failure; perf_pmu_register() then stores that NULL as pmu->name, and later sysfs path construction under /sys/bus/event_source/devices/ dereferences it.
Return -ENOMEM on devm_kasprintf() failure, matching the pattern used by other PMU drivers such as qcom_l3_pmu.c.
Signed-off-by William Theesfeld <[email protected]>
--- drivers/fpga/dfl-fme-perf.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/fpga/dfl-fme-perf.c +2 -0
@@ -925,6 +925,8 @@ static int fme_perf_pmu_register(struct platform_device *pdev,PERF_PMU_CAP_NO_EXCLUDE ; name =devm_kasprintf (priv->dev,GFP_KERNEL ,"dfl_fme%d" , pdev->id); +if (!name) +return -ENOMEM ; ret =perf_pmu_register (pmu, name,-1 );if (ret)
Signature · 1 line
2.54.0