Skip to contentSkip to conversation

fs/namei: fix UAF in pick_link() by unlazying before atime check

PATCH In review Deepanshu Kartikey 2 participants 3 messages Jun 2 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/namei: fix UAF in pick_link() by unlazying before atime check

In pick_link(), atime_needs_update() is called while the path walk may still be in RCU mode (LOOKUP_RCU set), meaning no reference is held on the inode. A concurrent iput() from another task can free the inode while atime_needs_update() reads inode->i_opflags (offset +2) inside current_time() -> is_mgtime(), causing a use-after-free.

KASAN reports:

  BUG: KASAN: slab-use-after-free in is_mgtime include/linux/fs.h:2313
  Read of size 2 at addr ffff8880407e4282 (offset +2 = i_opflags)

The race:

  Task A (pick_link)             Task B (unlinkat)
  ------------------             -----------------
  atime_needs_update(inode)      iput(inode)
    current_time(inode)            evict()
      is_mgtime(inode)               destroy_inode()
        inode->i_opflags  UAF          inode FREED

Fix: call try_to_unlazy() before atime_needs_update() so that a proper inode reference is held before any inode fields are read. If try_to_unlazy() detects the inode is already gone, it returns false and we exit safely with -ECHILD without touching freed memory.

Fixes e45960c279b098ebc0c2 ("fs: unconditionally use atime_needs_update() in pick_link()")
Reported-by [email protected]
---
 fs/namei.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
fs/namei.c +4 -4
index c7fac83c9a85..eac0ec35be37 100644
@@ -2037,11 +2037,11 @@ static noinline const char *pick_link(struct nameidata *nd, struct path *link,
 			unlikely(link->mnt->mnt_flags & MNT_NOSYMFOLLOW))
 		return ERR_PTR(-ELOOP);
 
+	if (nd->flags & LOOKUP_RCU) {
+		if (!try_to_unlazy(nd))
+			return ERR_PTR(-ECHILD);
+	}
 	if (unlikely(atime_needs_update(&last->link, inode))) {
-		if (nd->flags & LOOKUP_RCU) {
-			if (!try_to_unlazy(nd))
-				return ERR_PTR(-ECHILD);
-		}
 		touch_atime(&last->link);
 		cond_resched();
 	}
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 18 lines · Deepanshu Kartikey

In pick_link(), atime_needs_update() is called while the path walk may still be in RCU mode (LOOKUP_RCU set), meaning no reference is held on the inode. A concurrent iput() from another task can free the inode while atime_needs_update() reads inode->i_opflags (offset +2) inside current_time() -> is_mgtime(), causing a use-after-free.

KASAN reports:

  BUG: KASAN: slab-use-after-free in is_mgtime include/linux/fs.h:2313
  Read of size 2 at addr ffff8880407e4282 (offset +2 = i_opflags)

The race:

  Task A (pick_link)             Task B (unlinkat)
  ------------------             -----------------
  atime_needs_update(inode)      iput(inode)
    current_time(inode)            evict()
      is_mgtime(inode)               destroy_inode()
        inode->i_opflags  UAF          inode FREED
Quoted 4 lines

Fix: call try_to_unlazy() before atime_needs_update() so that a proper inode reference is held before any inode fields are read. If try_to_unlazy() detects the inode is already gone, it returns false and we exit safely with -ECHILD without touching freed memory.

NAK. This is *not* fixing the real problem; it's papering over the real breakage. At a guess - in bpffs, if that's the same thing as in https://lore.kernel.org/all/20260423043906.GN3518998@ZenIV/

Prompt freeing of inode is allowed *ONLY* if inode is never exposed to lazy pathwalk. It's OK for pipes, but this is not a pipe.

#2 lore raw
Quoted 7 lines · Al Viro

NAK. This is *not* fixing the real problem; it's papering over the real breakage. At a guess - in bpffs, if that's the same thing as in https://lore.kernel.org/all/20260423043906.GN3518998@ZenIV/

Prompt freeing of inode is allowed *ONLY* if inode is never exposed to lazy pathwalk. It's OK for pipes, but this is not a pipe.

Thanks for the suggestion. I will send patch v2 with the required changes.

Thanks
Deepanshu