iio: adc: ad7380: select REGMAP
PATCH 1/1 iio: adc: ad7380: select REGMAP
From: Samuel Moelius <[email protected]>
The AD7380 driver uses generic regmap types and APIs. However, its Kconfig entry does not select REGMAP.
As a result, AD7380 can be enabled from an allnoconfig-derived config with SPI_MASTER=y while REGMAP remains unset, causing ad7380.o to fail to build.
--- drivers/iio/adc/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/iio/adc/Kconfig +1 -0
@@ -311,6 +311,7 @@ config AD7298 config AD7380 tristate "Analog Devices AD7380 ADC driver" depends on SPI_MASTER + select REGMAP select SPI_OFFLOAD select IIO_BUFFER select IIO_BUFFER_DMAENGINE
Signature · 1 line
2.43.0
Quoted 6 lines · Sam Moelius
From: Samuel Moelius <[email protected]>
The AD7380 driver uses generic regmap types and APIs. However, its
Kconfigentry does not select REGMAP.As a result, AD7380 can be enabled from an allnoconfig-derived config with SPI_MASTER=y while REGMAP remains unset, causing ad7380.o to fail to build.
Seems like not wrapped on ~72 characters.
Quoted 3 lines
Fixes b095217c104b ("iio: adc: ad7380: new driver for AD7380 ADCs")
No blank line(s) in tag block.
Quoted 2 lines
Signed-off-by Samuel Moelius <[email protected]>---
Config change wise LGTM.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 5 lines · Sam Moelius
From: Samuel Moelius <[email protected]>
The AD7380 driver uses generic regmap types and APIs. However, its
Kconfigentry does not select REGMAP.
Quoted 7 lines
As a result, AD7380 can be enabled from an allnoconfig-derived config with SPI_MASTER=y while REGMAP remains unset, causing ad7380.o to fail to build.
Fixes b095217c104b ("iio: adc: ad7380: new driver for AD7380 ADCs")Signed-off-by Samuel Moelius <[email protected]>---
Change looks good but it seems the commit message will fail checkpatch. With that:
Quoted 15 lines
drivers/iio/adc/Kconfig | 1 +
1 file changed, 1 insertion(+)drivers/iio/adc/Kconfig +0
-0@@ -311,6 +311,7 @@ config AD7298config AD7380
tristate "Analog Devices AD7380 ADC driver" depends onSPI_MASTERdrivers/iio/adc/Kconfig +1
-0+ select REGMAPselect
SPI_OFFLOAD
selectIIO_BUFFER
selectIIO_BUFFER_DMAENGINE
Jonathan Cameron
maintainerQuoted 21 lines · On Tue, 02 Jun 2026 17:28:35 +0100 Nuno Sá <[email protected]> wrote:
Quoted 5 lines · Sam Moelius
From: Samuel Moelius <[email protected]>
The AD7380 driver uses generic regmap types and APIs. However, its
Kconfigentry does not select REGMAP.Quoted 7 lines
As a result, AD7380 can be enabled from an allnoconfig-derived config with SPI_MASTER=y while REGMAP remains unset, causing ad7380.o to fail to build.
Fixes b095217c104b ("iio: adc: ad7380: new driver for AD7380 ADCs")Signed-off-by Samuel Moelius <[email protected]>---
Change looks good but it seems the commit message will fail checkpatch. With that:
Reviewed-by Nuno Sá <[email protected]>Quoted 3 lines
drivers/iio/adc/Kconfig | 1 +
1 file changed, 1 insertion(+)
Quoted 9 lines
drivers/iio/adc/Kconfig config AD7298 · line 314
Quoted 9 lines
drivers/iio/adc/Kconfig +0
-0@@ -311,6 +311,7 @@ config AD7298config AD7380
tristate "Analog Devices AD7380 ADC driver" depends onSPI_MASTERdrivers/iio/adc/Kconfig +1
-0+ select REGMAP
Would REGMAP_SPI be the better choice? I assume either works from build point of view, but nicer to select all the support this actually needs.
Quoted 3 lines
Quoted 3 lines
select
SPI_OFFLOAD
selectIIO_BUFFER
selectIIO_BUFFER_DMAENGINE
Quoted 3 lines · Jonathan Cameron
Quoted 1 line · On Tue, 02 Jun 2026 17:28:35 +0100 Nuno Sá <[email protected]> wrote:
On Tue, 2026-06-02 at 15:39 +0000, Sam Moelius wrote:
...
Quoted 4 lines
Quoted 1 line
drivers/iio/adc/Kconfig config AD7298 · line 314
Quoted 1 line
drivers/iio/adc/Kconfig +1
-0+ select REGMAPWould
REGMAP_SPIbe the better choice? I assume either works from build point of view, but nicer to select all the support this actually needs.
Nope, it's custom regmap. The patch is good as is.
Signature · 2 lines
With Best Regards, Andy Shevchenko