Skip to contentSkip to conversation

mm-vma-remove-mmap_action-success_hook.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Jun 2

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled

     Subject: mm/vma: remove mmap_action->success_hook

has been removed from the -mm tree. Its filename was
mm-vma-remove-mmap_action-success_hook.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Lorenzo Stoakes <[email protected]>
Subject: mm/vma: remove mmap_action->success_hook
Date: Tue, 2 Jun 2026 12:06:26 +0100

This hook was introduced to work around code that seemed to absolutely require access to a VMA pointer upon mmap().

However, providing this hook leaves a backdoor to drivers getting access to the very thing mmap_prepare eliminates - a pointer to the VMA.

Let's solve this contradiction by removing it. The key intended user was hugetlb, however it seems that the best course now is to avoid allowing all drivers the ability to work around mmap_prepare, and find a different solution there.

---

 include/linux/mm_types.h        |   10 ----------
 mm/util.c                       |    2 --
 tools/testing/vma/include/dup.h |   10 ----------
 3 files changed, 22 deletions(-)
include/linux/mm_types.h renamed from include/linux/mm_types.h~mm-vma-remove-mmap_action-success_hook +0 -10
@@ -844,16 +844,6 @@ struct mmap_action {
 	enum mmap_action_type type;
 
 	/*
-	 * If specified, this hook is invoked after the selected action has been
-	 * successfully completed. Note that the VMA write lock still held.
-	 *
-	 * The absolute minimum ought to be done here.
-	 *
-	 * Returns 0 on success, or an error code.
-	 */
-	int (*success_hook)(const struct vm_area_struct *vma);
-
-	/*
 	 * If specified, this hook is invoked when an error occurred when
 	 * attempting the selected action.
 	 *
mm/util.c renamed from mm/util.c~mm-vma-remove-mmap_action-success_hook +0 -2
@@ -1397,8 +1397,6 @@ static int mmap_action_finish(struct vm_
 
 	if (!err)
 		err = call_vma_mapped(vma);
-	if (!err && action->success_hook)
-		err = action->success_hook(vma);
 
 	/* do_munmap() might take rmap lock, so release if held. */
 	maybe_rmap_unlock_action(vma, action);
tools/testing/vma/include/dup.h renamed from tools/testing/vma/include/dup.h~mm-vma-remove-mmap_action-success_hook +0 -10
@@ -483,16 +483,6 @@ struct mmap_action {
 	enum mmap_action_type type;
 
 	/*
-	 * If specified, this hook is invoked after the selected action has been
-	 * successfully completed. Note that the VMA write lock still held.
-	 *
-	 * The absolute minimum ought to be done here.
-	 *
-	 * Returns 0 on success, or an error code.
-	 */
-	int (*success_hook)(const struct vm_area_struct *vma);
-
-	/*
 	 * If specified, this hook is invoked when an error occurred when
 	 * attempting the selection action.
 	 *

_

Patches currently in -mm which might be from [email protected] are

mm-huge_memory-use-correct-flags-for-device-private-pmd-entry.patch