dt-bindings: hwmon: isl68137: Add RAA228234 compatible
Subsystems (2)
PATCH 1/2 dt-bindings: hwmon: isl68137: Add RAA228234 compatible
From: Patrick Rudolph <[email protected]>
Add the compatible string for the Renesas RAA228234 8-phase PWM controller, which shares the same PMBus interface as the RAA228228.
--- Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml +1 -0
@@ -55,6 +55,7 @@ properties: - renesas,raa228004 - renesas,raa228006 - renesas,raa228228 + - renesas,raa228234 - renesas,raa228244 - renesas,raa228246 - renesas,raa229001
Signature · 1 line
2.43.0
PATCH 2/2 hwmon: pmbus: isl68137: Add support for RAA228234
From: Patrick Rudolph <[email protected]>
The RAA228234 is an 8-phase PWM controller from Renesas. It uses the same DMPVR2 PMBus interface as the RAA228228 (a dual-output 20-phase controller), so it can share the raa_dmpvr2_2rail_nontc configuration.
Add the device to the I2C and OF device ID tables.
Tested on RAA228234 hardware; confirmed all sensor readings are correct.
--- drivers/hwmon/pmbus/isl68137.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/hwmon/pmbus/isl68137.c +2 -0
@@ -448,6 +448,7 @@ static const struct i2c_device_id raa_dmpvr_id[] = { {"raa228004", raa_dmpvr2_hv}, {"raa228006", raa_dmpvr2_hv}, {"raa228228", raa_dmpvr2_2rail_nontc}, + {"raa228234", raa_dmpvr2_2rail_nontc}, {"raa228244", raa_dmpvr2_2rail_nontc}, {"raa228246", raa_dmpvr2_2rail_nontc}, {"raa228942", raa_dmpvr2_2rail_nontc},
@@ -501,6 +502,7 @@ static const struct of_device_id isl68137_of_match[] = { { .compatible = "renesas,raa228004", .data = (void *)raa_dmpvr2_hv }, { .compatible = "renesas,raa228006", .data = (void *)raa_dmpvr2_hv }, { .compatible = "renesas,raa228228", .data = (void *)raa_dmpvr2_2rail_nontc }, + { .compatible = "renesas,raa228234", .data = (void *)raa_dmpvr2_2rail_nontc }, { .compatible = "renesas,raa228244", .data = (void *)raa_dmpvr2_2rail_nontc }, { .compatible = "renesas,raa228246", .data = (void *)raa_dmpvr2_2rail_nontc }, { .compatible = "renesas,raa229001", .data = (void *)raa_dmpvr2_2rail },
Signature · 1 line
2.43.0
[email protected]
AI reviewRe: [PATCH 2/2] hwmon: pmbus: isl68137: Add support for RAA228234
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 6 lines
From: Patrick Rudolph <[email protected]>
The RAA228234 is an 8-phase PWM controller from Renesas. It uses the same DMPVR2 PMBus interface as the RAA228228 (a dual-output 20-phase controller), so it can share the
raa_dmpvr2_2rail_nontcconfiguration.
Quoted 6 lines
Add the device to the I2C and OF device ID tables.
Tested on RAA228234 hardware; confirmed all sensor readings are correct.
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Naresh Solanki <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
[email protected]
AI reviewSashiko has reviewed this patch and found no issues. It looks great!
Quoted 7 lines
From: Patrick Rudolph <[email protected]>
Add the compatible string for the Renesas RAA228234 8-phase PWM controller, which shares the same PMBus interface as the RAA228228.
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Naresh Solanki <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 4 lines · Naresh Solanki
From: Patrick Rudolph <[email protected]>
Add the compatible string for the Renesas RAA228234 8-phase PWM controller, which shares the same PMBus interface as the RAA228228.
Given this, and what the driver change looks like, why is a fallback compatible not used?
Quoted 22 lines
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Naresh Solanki <[email protected]>--- Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml +1
-0@@ -55,6 +55,7 @@ properties: - renesas,raa228004 - renesas,raa228006 - renesas,raa228228 + - renesas,raa228234 - renesas,raa228244 - renesas,raa228246 - renesas,raa229001Signature · 1 line
2.43.0
Hi
Quoted 9 lines · Conor Dooley
Quoted 4 lines · Naresh Solanki
From: Patrick Rudolph <[email protected]>
Add the compatible string for the Renesas RAA228234 8-phase PWM controller, which shares the same PMBus interface as the RAA228228.
Given this, and what the driver change looks like, why is a fallback compatible not used?
Are you suggesting that the binding should use renesas,raa228228 as a fallback compatible, similar to how renesas,raa228942 and renesas,raa228943 fall back to renesas,raa228244? Or is there a specific reason you'd expect it not to be used here?
Regards,
Naresh
Quoted 23 lines
Quoted 23 lines
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Naresh Solanki <[email protected]>--- Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml +1
-1@@ -55,6 +55,7 @@ properties: - renesas,raa228004 - renesas,raa228006 - renesas,raa228228 + - renesas,raa228234 - renesas,raa228244 - renesas,raa228246 - renesas,raa229001 --2.43.0
Quoted 8 lines · Naresh Solanki
Hi
Quoted 4 lines · Conor Dooley
Quoted 2 lines · Naresh Solanki
From: Patrick Rudolph <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Add the compatible string for the Renesas RAA228234 8-phase PWM controller, which shares the same PMBus interface as the RAA228228.
Given this, and what the driver change looks like, why is a fallback compatible not used?
Are you suggesting that the binding should use renesas,raa228228 as a fallback compatible, similar to how renesas,raa228942 and renesas,raa228943 fall back to renesas,raa228244?
I didn't see that at the time (I commented on this diff alone), but yes.
{ .compatible = "renesas,raa228228", .data = (void *)raa_dmpvr2_2rail_nontc },
+ { .compatible = "renesas,raa228234", .data = (void *)raa_dmpvr2_2rail_nontc },
{ .compatible = "renesas,raa228244", .data = (void *)raa_dmpvr2_2rail_nontc }, { .compatible = "renesas,raa228246", .data = (void *)raa_dmpvr2_2rail_nontc },
driver change suggests you're compatible with the ..44 device.
I expect that you'll use a fallback in the next iteration then?
pw-bot: changes-requested
Cheers,
Conor.
Quoted 29 lines
Or is there a
specific reason you'd expect it not to be used here?Regards,
NareshQuoted 23 lines
Quoted 23 lines
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Naresh Solanki <[email protected]>--- Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml +1
-1@@ -55,6 +55,7 @@ properties: - renesas,raa228004 - renesas,raa228006 - renesas,raa228228 + - renesas,raa228234 - renesas,raa228244 - renesas,raa228246 - renesas,raa229001 --2.43.0