Skip to contentSkip to conversation

Add myself to two additional linux-media drivers as reviewer

PATCH Applied Bryan O'Donoghue 5 participants 12 messages Jun 2 – Jul 24 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

cover Add myself to two additional linux-media drivers as reviewer

We discussed in Nice adding reviewers to help get other's code reviewed and to help the reviewers get more relevant knowledge by formally inspecting the work of their peers. NXP and Qcom were mentioned.

Laurent suggested I can help out with these two drivers and so, I'm happy to do so.

---
Bryan O'Donoghue (2):
media: imx: imx8mq-mipi-csi2: Add myself as reviewer to imx8mq-mipi-csi2
media: rockchip: dw-mipi-csi2rx: Add myself to the reviewers list

 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

---
base-commit: 65c06d2edded3b1e1633bf75f0f7a26b609ed5ac
change-id: 20260603-dphy-params-extension-17fef5f7260d

Best regards,

Signature · 1 line
Bryan O'Donoghue <[email protected]>
#1 lore raw

PATCH 1/2 media: imx: imx8mq-mipi-csi2: Add myself as reviewer to imx8mq-mipi-csi2

At the media summit in Nice this year we discussed that cross reviewing from different people on LKML was lacking and desirable. Laurent suggested NXP/Qcom do some cross pollination.

Happy to read and review NXP stuff in that spirit.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index efbf808063e50..8436428865aac 100644
@@ -16094,6 +16094,7 @@ M:	Frank Li <[email protected]>
 M:	Martin Kepplinger-Novakovic <[email protected]>
 R:	Rui Miguel Silva <[email protected]>
 R:	Purism Kernel Team <[email protected]>
+R:	Bryan O'Donoghue <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Maintained
Signature · 1 line
2.54.0
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] media: imx: imx8mq-mipi-csi2: Add myself as reviewer to imx8mq-mipi-csi2

Quoted 8 lines · Bryan O'Donoghue

At the media summit in Nice this year we discussed that cross reviewing from different people on LKML was lacking and desirable. Laurent suggested NXP/Qcom do some cross pollination.

Happy to read and review NXP stuff in that spirit.

---

Quoted 19 lines
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -1
index efbf808063e50..8436428865aac 100644
@@ -16094,6 +16094,7 @@ M:	Frank Li <[email protected]>
 M:	Martin Kepplinger-Novakovic <[email protected]>
 R:	Rui Miguel Silva <[email protected]>
 R:	Purism Kernel Team <[email protected]>
+R:	Bryan O'Donoghue <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Maintained
 
--

2.54.0

#3 lore raw

Re: [PATCH 1/2] media: imx: imx8mq-mipi-csi2: Add myself as reviewer to imx8mq-mipi-csi2

Quoted 11 lines · Frank Li
Quoted 8 lines · Bryan O'Donoghue

At the media summit in Nice this year we discussed that cross reviewing from different people on LKML was lacking and desirable. Laurent suggested NXP/Qcom do some cross pollination.

Happy to read and review NXP stuff in that spirit.

---

Laurent and Bryan O'Donoghue,

which qcom part I can help review, I can add myself as reviewer also.

Frank

Quoted 20 lines
Quoted 20 lines
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -1
index efbf808063e50..8436428865aac 100644
@@ -16094,6 +16094,7 @@ M:	Frank Li <[email protected]>
 M:	Martin Kepplinger-Novakovic <[email protected]>
 R:	Rui Miguel Silva <[email protected]>
 R:	Purism Kernel Team <[email protected]>
+R:	Bryan O'Donoghue <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Maintained
 
--

2.54.0

#4 lore raw

Re: [PATCH 1/2] media: imx: imx8mq-mipi-csi2: Add myself as reviewer to imx8mq-mipi-csi2

Quoted 8 lines · Frank Li
Quoted 7 lines · Frank Li
Quoted 6 lines · Bryan O'Donoghue

At the media summit in Nice this year we discussed that cross reviewing from different people on LKML was lacking and desirable. Laurent suggested NXP/Qcom do some cross pollination.

Happy to read and review NXP stuff in that spirit.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

---

Laurent and Bryan O'Donoghue,

which qcom part I can help review, I can add myself as reviewer also.

Bryan, could you please reply to this ?

Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index efbf808063e50..8436428865aac 100644
@@ -16094,6 +16094,7 @@ M:	Frank Li <[email protected]>
 M:	Martin Kepplinger-Novakovic <[email protected]>
 R:	Rui Miguel Silva <[email protected]>
 R:	Purism Kernel Team <[email protected]>
+R:	Bryan O'Donoghue <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Maintained
Signature · 3 lines
Regards,

Laurent Pinchart
#5 lore raw

Re: [PATCH 1/2] media: imx: imx8mq-mipi-csi2: Add myself as reviewer to imx8mq-mipi-csi2

Quoted 9 lines · Laurent Pinchart
Quoted 8 lines · Frank Li
Quoted 7 lines · Frank Li
Quoted 6 lines · Bryan O'Donoghue

At the media summit in Nice this year we discussed that cross reviewing from different people on LKML was lacking and desirable. Laurent suggested NXP/Qcom do some cross pollination.

Happy to read and review NXP stuff in that spirit.

Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
Quoted 2 lines

---

Laurent and Bryan O'Donoghue,

which qcom part I can help review, I can add myself as reviewer also.

Bryan, could you please reply to this ?

How much work do you feel like doing ?

You can either +R camera or +R all of driver/media/platform/qcom

TBH there's a lot of work that goes on outside of camera that perhaps could do with some more love from !qcom people.

Up to yourself.

---
bod

Reviewed-by on v1 1/2
#6 lore raw

Re: [PATCH 1/2] media: imx: imx8mq-mipi-csi2: Add myself as reviewer to imx8mq-mipi-csi2

In reply to Bryan O'Donoghue

Hi Bryan,

Quoted 7 lines · Bryan O'Donoghue

At the media summit in Nice this year we discussed that cross reviewing from different people on LKML was lacking and desirable. Laurent suggested NXP/Qcom do some cross pollination.

Happy to read and review NXP stuff in that spirit.

Thank you for volunteering.

Quoted 16 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index efbf808063e50..8436428865aac 100644
@@ -16094,6 +16094,7 @@ M:	Frank Li <[email protected]>
 M:	Martin Kepplinger-Novakovic <[email protected]>
 R:	Rui Miguel Silva <[email protected]>
 R:	Purism Kernel Team <[email protected]>
+R:	Bryan O'Donoghue <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Maintained
Signature · 3 lines
Regards,

Laurent Pinchart
#7 lore raw

PATCH 2/2 media: rockchip: dw-mipi-csi2rx: Add myself to the reviewers list

In reply to Bryan O'Donoghue

As a cross pollination activity between Qcom and others add myself to the Rockchip list. We discussed @ Nice making reviews more formal because frankly we can get gummed up in not reviewing. Add myself +R here in that light.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 8436428865aac..25e3f2cfcbf2b 100644
@@ -25934,6 +25934,7 @@ F:	include/linux/soc/amd/isp4_misc.h
 
 SYNOPSYS DESIGNWARE MIPI CSI-2 RECEIVER DRIVER
 M:	Michael Riesch <[email protected]>
+R:	Bryan O'Donoghue <[email protected]>
 L:	[email protected]
 S:	Maintained
 F:	Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml
Signature · 1 line
2.54.0
Acked-by on v1 2/2
#8 lore raw

Re: [PATCH 2/2] media: rockchip: dw-mipi-csi2rx: Add myself to the reviewers list

Hi Bryan,

Quoted 4 lines · Bryan O'Donoghue

As a cross pollination activity between Qcom and others add myself to the Rockchip list. We discussed @ Nice making reviews more formal because frankly we can get gummed up in not reviewing. Add myself +R here in that light.

Cool, welcome aboard :-)

Quoted 2 lines

Best regards,
Michael

Quoted 17 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 8436428865aac..25e3f2cfcbf2b 100644
@@ -25934,6 +25934,7 @@ F:	include/linux/soc/amd/isp4_misc.h
 
 SYNOPSYS DESIGNWARE MIPI CSI-2 RECEIVER DRIVER
 M:	Michael Riesch <[email protected]>
+R:	Bryan O'Donoghue <[email protected]>
 L:	[email protected]
 S:	Maintained
 F:	Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml
Reviewed-by on v1 2/2
#9 lore raw

Re: [PATCH 2/2] media: rockchip: dw-mipi-csi2rx: Add myself to the reviewers list

In reply to Bryan O'Donoghue

Hi Bryan,

Quoted 6 lines · Bryan O'Donoghue

As a cross pollination activity between Qcom and others add myself to the Rockchip list. We discussed @ Nice making reviews more formal because frankly we can get gummed up in not reviewing. Add myself +R here in that light.

Quoted 16 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 8436428865aac..25e3f2cfcbf2b 100644
@@ -25934,6 +25934,7 @@ F:	include/linux/soc/amd/isp4_misc.h
 
 SYNOPSYS DESIGNWARE MIPI CSI-2 RECEIVER DRIVER
 M:	Michael Riesch <[email protected]>
+R:	Bryan O'Donoghue <[email protected]>
 L:	[email protected]
 S:	Maintained
 F:	Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi2.yaml
Signature · 3 lines
Regards,

Laurent Pinchart
#10 lore raw

Re: (subset) [PATCH 0/2] Add myself to two additional linux-media drivers as reviewer

In reply to Bryan O'Donoghue

From: Frank Li <[email protected]>

Quoted 8 lines · Bryan O'Donoghue

We discussed in Nice adding reviewers to help get other's code reviewed and to help the reviewers get more relevant knowledge by formally inspecting the work of their peers. NXP and Qcom were mentioned.

Laurent suggested I can help out with these two drivers and so, I'm happy to do so.

[...]

Applied, thanks!

[1/2] media: imx: imx8mq-mipi-csi2: Add myself as reviewer to imx8mq-mipi-csi2

      commit: c6193d521154e0ca86ffd389de0c2c09c2c072ef

Best regards,
--
Frank Li <[email protected]>

#11 lore raw
In reply to Bryan O'Donoghue

From: Frank Li <[email protected]>

Quoted 8 lines · Bryan O'Donoghue

We discussed in Nice adding reviewers to help get other's code reviewed and to help the reviewers get more relevant knowledge by formally inspecting the work of their peers. NXP and Qcom were mentioned.

Laurent suggested I can help out with these two drivers and so, I'm happy to do so.

[...]

Applied, thanks!

[1/2] media: imx: imx8mq-mipi-csi2: Add myself as reviewer to imx8mq-mipi-csi2

      commit: 83f0e8cf32a767357e4bab2281c46c218ea06a87
[2/2] media: rockchip: dw-mipi-csi2rx: Add myself to the reviewers list
      commit: 510b66ee871754336438e7f5d6fe205cc8c3d6de

Best regards,
--
Frank Li <[email protected]>