Skip to contentSkip to conversation

iio: todo: fix typo and refine resource management items

PATCH Superseded Sanjay Chitroda 3 participants 3 messages Jun 1 – Jun 3 IIO

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: todo: fix typo and refine resource management items

From: Sanjay Chitroda <[email protected]>

Fix a typo in the staging documentation path and adjust formatting of existing entries for readability.

Add TODO items to track conversion of selected drivers to device managed resource APIs and evaluate usage of cleanup.h helpers for simplifying resource management.

These updates aim to better reflect ongoing cleanup efforts within the IIO subsystem.

---
 drivers/iio/TODO | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/iio/TODO +7 -3
index 2ace27d1ac62..17093cc6c61b 100644
@@ -5,12 +5,16 @@ Documentation
 tree
   - Yaml conversions for abandoned drivers
   - ABI Documentation
-  - Audit driviers/iio/staging/Documentation
+  - Audit drivers/staging/iio/Documentation
 
-- Converting drivers from device tree centric to more generic
-property handlers.
+- Converting drivers from device tree centric to more generic property handlers.
 
 - Refactor old platform_data constructs from drivers and convert it
 to state struct and using property handlers and readers.
 
+- Convert selected IIO drivers to use fully device managed resource APIs.
+
+- Evaluate and adopt cleanup.h helpers (guard, __free) in drivers where
+  manual resource management is still used.
+
 Mailing list: [email protected]
Signature · 1 line
--
#1 lore raw
Quoted 9 lines · Sanjay Chitroda

Fix a typo in the staging documentation path and adjust formatting of existing entries for readability.

Add TODO items to track conversion of selected drivers to device managed resource APIs and evaluate usage of cleanup.h helpers for simplifying resource management.

These updates aim to better reflect ongoing cleanup efforts within the IIO subsystem.

...

Quoted 1 line

+- Evaluate and adopt cleanup.h helpers (guard, __free) in drivers where

(guard()(), __free(), et cetera)

Quoted 1 line

+ manual resource management is still used.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#2 lore raw
In reply to Sanjay Chitroda
Quoted 5 lines · On Tue, 2 Jun 2026 00:38:36 +0530 Sanjay Chitroda…

From: Sanjay Chitroda <[email protected]>

Fix a typo in the staging documentation path and adjust formatting of existing entries for readability.

Quoted 8 lines

Add TODO items to track conversion of selected drivers to device managed resource APIs and evaluate usage of cleanup.h helpers for simplifying resource management.

These updates aim to better reflect ongoing cleanup efforts within the IIO subsystem.

Hmm. Sometimes I regret having this TODO when too many patches are coming in. I guess it's still a useful document as otherwise we would just get the question a lot.

Quoted 9 lines
---
 drivers/iio/TODO | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/iio/TODO +0 -0
index 2ace27d1ac62..17093cc6c61b 100644

drivers/iio/TODO Documentation · line 10

Quoted 9 lines
drivers/iio/TODO +2 -3
@@ -5,12 +5,16 @@ Documentation
 tree
   - Yaml conversions for abandoned drivers
   - ABI Documentation
-  - Audit driviers/iio/staging/Documentation
+  - Audit drivers/staging/iio/Documentation
 
-- Converting drivers from device tree centric to more generic
-property handlers.
+- Converting drivers from device tree centric to more generic property handlers.

Drop the 'more'

drivers/iio/TODO Documentation · line 15

Quoted 5 lines
drivers/iio/TODO +1 -0
 - Refactor old platform_data constructs from drivers and convert it
 to state struct and using property handlers and readers.
 
+- Convert selected IIO drivers to use fully device managed resource APIs.

Mostly I'm fine with this one, but I hope adding it to the todo list doesn't get lots of new folk taking this on. It is something that requires a non trivial understanding of the driver in some cases!

drivers/iio/TODO Documentation · line 18

Quoted 3 lines
drivers/iio/TODO +3 -0
+
+- Evaluate and adopt cleanup.h helpers (guard, __free) in drivers where
+  manual resource management is still used.

Can we rephrase,

- Evaluate and possibly adopt cleanup.h helpers (guard, __free) in drivers where manual resource management is still used and there is a significant improvement to the code flow and complexity to be had.

Quoted 2 lines
drivers/iio/TODO +1 -0
+
 Mailing list: [email protected]