Skip to contentSkip to conversation

f2fs: validate inline dentry name lengths before conversion

PATCH New Samuel Moelius 1 participant 1 message Jun 3 F2FS file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 f2fs: validate inline dentry name lengths before conversion

Inline dentry conversion copies names out of the inline dentry area before checking that each recorded name length fits in the available filename slots.

A corrupted image can therefore make the conversion path read past the inline filename storage while building the regular dentry block.

Validate each inline dentry name length against the inline filename area before copying it.

Assisted-by Codex:gpt-5.5-cyber-preview
---
 fs/f2fs/inline.c | 4 ++++
 1 file changed, 4 insertions(+)
fs/f2fs/inline.c +4 -0
index 7aabfc9b43cb..4584dfbe3fb8 100644
@@ -507,6 +507,10 @@ static int f2fs_add_inline_entries(struct inode *dir, void *inline_dentry)
 			bit_pos++;
 			continue;
 		}
+		if (unlikely(le16_to_cpu(de->name_len) > F2FS_NAME_LEN ||
+			     bit_pos + GET_DENTRY_SLOTS(le16_to_cpu(de->name_len)) >
+			     d.max))
+			return -EFSCORRUPTED;
 
 		/*
 		 * We only need the disk_name and hash to move the dentry.
Signature · 1 line
2.43.0