Skip to contentSkip to conversation

docs: exclude driver and netdevsim bugs

PATCH In review Jakub Kicinski 6 participants 9 messages Jun 3 – Jun 17

Subsystems (4)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 docs: exclude driver and netdevsim bugs

Initial wave of AI-generated fixes was mostly for core and protocols we care about. But the number of irrelevant driver fixes is slowly increasing. Add a section of explicit exclusions to our maintainer profile.

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 Documentation/process/maintainer-netdev.rst | 28 +++++++++++++++++++++
 1 file changed, 28 insertions(+)
Documentation/process/maintainer-netdev.rst +28 -0
index ec7b9aa2877f..cc4b5fa3b5c1 100644
@@ -272,6 +272,34 @@ the case today. Please follow the standard stable rules in
 :ref:`Documentation/process/stable-kernel-rules.rst <stable_kernel_rules>`,
 and make sure you include appropriate Fixes tags!
 
+Bug fixes
+~~~~~~~~~
+
+Unless explicitly excluded all bug fixes should be targeting the ``net``
+tree and contain an appropriate Fixes tag.
+
+Obvious exclusions:
+
+ - fixes for bugs which only exist in ``net-next`` should target ``net-next``
+   (please still include the Fixes tag in the commit message)
+ - bugs which cannot be reached, e.g. in code paths not executed given
+   current in-tree callers
+ - fixes for compiler warnings and typos
+
+Fixes for selftests and selftest-related infrastructure (most notably
+including the ``netdevsim`` driver) are only considered ``net``-worthy
+if they substantially reduce the flakiness of the test.
+
+Additionally, netdev does not consider bugs to be ``net``-worthy
+if they fulfill **all** of the following criteria:
+ - bug is in a hardware device driver;
+ - bug is either a missing error handling or is part of the error handling flow;
+ - bug was discovered by a static analysis / AI tool;
+ - bug was triggered/observed only with kernel changes or fault injection.
+Fixes for such bugs should default to ``net-next`` and should **not** contain
+a Fixes tag. Networking or driver maintainers may redirect such fixes to ``net``
+at their discretion if they consider the condition to be relevant enough.
+
 Security fixes
 ~~~~~~~~~~~~~~
 
Signature · 1 line
2.54.0
#1 lore raw

Documentation/process/maintainer-netdev.rst the case today. Please follow the standard stable rules in · line 301

Quoted 9 lines
Documentation/process/maintainer-netdev.rst +9 -0
+Additionally, netdev does not consider bugs to be ``net``-worthy
+if they fulfill **all** of the following criteria:
+ - bug is in a hardware device driver;
+ - bug is either a missing error handling or is part of the error handling flow;
+ - bug was discovered by a static analysis / AI tool;
+ - bug was triggered/observed only with kernel changes or fault injection.
+Fixes for such bugs should default to ``net-next`` and should **not** contain
+a Fixes tag. Networking or driver maintainers may redirect such fixes to ``net``
+at their discretion if they consider the condition to be relevant enough.

I would also stress what the stable rules say:

It must either fix a real bug that bothers people or ...

Many of the bug fixes we are currently getting don't meet this criteria, so are net-next material.

Andrew

author maintainer
#2 lore raw
Quoted 12 lines · On Wed, 3 Jun 2026 21:25:02 +0200 Andrew Lunn wrote:

Documentation/process/maintainer-netdev.rst the case today. Please follow the standard stable rules in · line 301

Quoted 9 lines
Documentation/process/maintainer-netdev.rst +9 -0
+Additionally, netdev does not consider bugs to be ``net``-worthy
+if they fulfill **all** of the following criteria:
+ - bug is in a hardware device driver;
+ - bug is either a missing error handling or is part of the error handling flow;
+ - bug was discovered by a static analysis / AI tool;
+ - bug was triggered/observed only with kernel changes or fault injection.
+Fixes for such bugs should default to ``net-next`` and should **not** contain
+a Fixes tag. Networking or driver maintainers may redirect such fixes to ``net``
+at their discretion if they consider the condition to be relevant enough.  

I would also stress what the stable rules say:

Quoted 4 lines

It must either fix a real bug that bothers people or ...

Many of the bug fixes we are currently getting don't meet this criteria, so are net-next material.

I decided to leave that out in the end because it's a bit too open to interpretation for my mind.

#3 lore raw
In reply to Jakub Kicinski

Documentation/process/maintainer-netdev.rst the case today. Please follow the standard stable rules in · line 296

Quoted 5 lines · Jakub Kicinski
Documentation/process/maintainer-netdev.rst +4 -0
+Additionally, netdev does not consider bugs to be ``net``-worthy
+if they fulfill **all** of the following criteria:
+ - bug is in a hardware device driver;
+ - bug is either a missing error handling or is part of the error handling flow;

Do you really want to be this specific?

Take this fix for example that I mentioned the other day:
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

It doesn't formally fall under that definition, but I think it should, it's a silly thing to send to stable etc.

This isn't even a USB device where you could reasonably argue that someone might plug in a random one and it could be programmed to look like the device in question and misbehave. Sure, you can build PCIe hardware too that can do that, technically, and there's technically external PCIe via Thunderbolt, but it's still far harder to actually do anything with.

Quoted 1 line

+ - bug was discovered by a static analysis / AI tool;

I'm not (yet?) convinced that this bullet point is right.

It risks getting into an argument about how much the LLM did to discover it, or if the actual discovery was a manual process after the LLM pointed out issues, or whatever ...

Maybe more importantly, why should that even change the result?

It's true that today the reason to start spelling this out more clearly is AI related, but that's really because of (a) the scale, and (b) many of the people running the LLMs not being aware of (and frankly often not really caring about) the community norms. I'm not convinced that the "silliness" of a change should be measured by how it originated.

Quoted 1 line

+ - bug was triggered/observed only with kernel changes or fault injection.

Given this fourth bullet point, we'd still accept fixes for such driver problems that people actually run into, while excluding "theoretical" things that are discovered by "reading the code".

johannes

#4 lore raw
Quoted 9 lines · Johannes Berg

Documentation/process/maintainer-netdev.rst the case today. Please follow the standard stable rules in · line 296

Quoted 5 lines · Jakub Kicinski
Documentation/process/maintainer-netdev.rst +4 -0
+Additionally, netdev does not consider bugs to be ``net``-worthy
+if they fulfill **all** of the following criteria:
+ - bug is in a hardware device driver;
+ - bug is either a missing error handling or is part of the error handling flow;

Do you really want to be this specific?

I agree, this does feel a little overly specific. Perhaps there is better wording to clarify the intent such that it could cover your example as well? Hmm.

Quoted 21 lines

Take this fix for example that I mentioned the other day:
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

It doesn't formally fall under that definition, but I think it should, it's a silly thing to send to stable etc.

This isn't even a USB device where you could reasonably argue that someone might plug in a random one and it could be programmed to look like the device in question and misbehave. Sure, you can build PCIe hardware too that can do that, technically, and there's technically external PCIe via Thunderbolt, but it's still far harder to actually do anything with.

Quoted 1 line

+ - bug was discovered by a static analysis / AI tool;

I'm not (yet?) convinced that this bullet point is right.

It risks getting into an argument about how much the LLM did to discover it, or if the actual discovery was a manual process after the LLM pointed out issues, or whatever ...

Quoted 8 lines

Maybe more importantly, why should that even change the result?

It's true that today the reason to start spelling this out more clearly is AI related, but that's really because of (a) the scale, and (b) many of the people running the LLMs not being aware of (and frankly often not really caring about) the community norms. I'm not convinced that the "silliness" of a change should be measured by how it originated.

Right. The point to me seems that "fixes" made purely to resolve tool hits (static analysis, checkpatch, LLM, whatever) have lower value than fixes which have a stronger motivation such as user reports.

I'm not sure I have a better wording, and perhaps you could remove this bit entirely.

Quoted 6 lines
Quoted 1 line

+ - bug was triggered/observed only with kernel changes or fault injection.

Given this fourth bullet point, we'd still accept fixes for such driver problems that people actually run into, while excluding "theoretical" things that are discovered by "reading the code".

Right. One could argue that some race conditions are difficult to trigger because a window is very narrow, and fault injection could make it much easier... But we could still accept such fixes as development improvement rather than through the "net" tree, so I think this criteria is good.

Quoted 2 lines

johannes

#5 lore raw
In reply to Jakub Kicinski
kernel test robot noticed the following build warnings:

Hi Jakub,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Jakub-Kicinski/docs-exclude-driver-and-netdevsim-bugs/20260604-003949
base:   net-next/main
patch link:    https://lore.kernel.org/r/20260603162943.2406080-1-kuba%40kernel.org
patch subject: [PATCH net-next] docs: exclude driver and netdevsim bugs
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project f43d6834093b19baf79beda8c0337ab020ac5f17)
docutils: docutils (Docutils 0.21.2, Python 3.13.5, on linux)
reproduce: (https://download.01.org/0day-ci/archive/20260604/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

Checksumming on output with GSO
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [docutils] Documentation/process/maintainer-netdev.rst:295: ERROR: Unexpected indentation. [docutils]

>> Documentation/process/maintainer-netdev.rst:299: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]

MAINTAINERS:40: WARNING: Inline strong start-string without end-string. [docutils] Documentation/userspace-api/landlock:504: ./security/landlock/errata/abi-4.h:5: ERROR: Unexpected section title.

vim +299 Documentation/process/maintainer-netdev.rst

292
293 Additionally, netdev does not consider bugs to be ``net``-worthy
294 if they fulfill **all** of the following criteria:
295 - bug is in a hardware device driver;
296 - bug is either a missing error handling or is part of the error handling flow;
297 - bug was discovered by a static analysis / AI tool;
298 - bug was triggered/observed only with kernel changes or fault injection.

 > 299	Fixes for such bugs should default to ``net-next`` and should **not** contain

300 a Fixes tag. Networking or driver maintainers may redirect such fixes to ``net``
301 at their discretion if they consider the condition to be relevant enough.
302

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

#6 lore raw
In reply to Jakub Kicinski
Quoted 26 lines · Jakub Kicinski

Initial wave of AI-generated fixes was mostly for core and protocols we care about. But the number of irrelevant driver fixes is slowly increasing. Add a section of explicit exclusions to our maintainer profile.

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 Documentation/process/maintainer-netdev.rst | 28 +++++++++++++++++++++
 1 file changed, 28 insertions(+)
Documentation/process/maintainer-netdev.rst +3 -0
index ec7b9aa2877f..cc4b5fa3b5c1 100644
@@ -272,6 +272,34 @@ the case today. Please follow the standard stable rules in
 :ref:`Documentation/process/stable-kernel-rules.rst <stable_kernel_rules>`,
 and make sure you include appropriate Fixes tags!
 
+Bug fixes
+~~~~~~~~~
+

Documentation/process/maintainer-netdev.rst the case today. Please follow the standard stable rules in · line 287

Quoted 10 lines
Documentation/process/maintainer-netdev.rst +10 -0
+Unless explicitly excluded all bug fixes should be targeting the ``net``
+tree and contain an appropriate Fixes tag.
+
+Obvious exclusions:
+
+ - fixes for bugs which only exist in ``net-next`` should target ``net-next``
+   (please still include the Fixes tag in the commit message)
+ - bugs which cannot be reached, e.g. in code paths not executed given
+   current in-tree callers
+ - fixes for compiler warnings and typos

If you decide to resubmit this patch, could you please remove "fixes for compiler warnings" from the exclusion list?

It is quite frustrating to receive a compiler warning originating from a different subsystem after the merge window, knowing it will not be addressed until the next merge window (around eight weeks later).

Thanks.

author maintainer
#7 lore raw
Quoted 14 lines · On Mon, 15 Jun 2026 12:14:36 +0300 Leon Romanovsky wrote:

Documentation/process/maintainer-netdev.rst the case today. Please follow the standard stable rules in · line 287

Quoted 10 lines
Documentation/process/maintainer-netdev.rst +10 -0
+Unless explicitly excluded all bug fixes should be targeting the ``net``
+tree and contain an appropriate Fixes tag.
+
+Obvious exclusions:
+
+ - fixes for bugs which only exist in ``net-next`` should target ``net-next``
+   (please still include the Fixes tag in the commit message)
+ - bugs which cannot be reached, e.g. in code paths not executed given
+   current in-tree callers
+ - fixes for compiler warnings and typos  

If you decide to resubmit this patch, could you please remove "fixes for compiler warnings" from the exclusion list?

Quoted 3 lines

It is quite frustrating to receive a compiler warning originating from a different subsystem after the merge window, knowing it will not be addressed until the next merge window (around eight weeks later).

Agreed, FWIW, but not planning to resubmit.
I think people misunderstood that I'm __documenting what I already do__ rather than trying to have a discussion :/

#8 lore raw
Quoted 15 lines · Jakub Kicinski
Quoted 14 lines · On Mon, 15 Jun 2026 12:14:36 +0300 Leon Romanovsky wrote:

Documentation/process/maintainer-netdev.rst the case today. Please follow the standard stable rules in · line 287

Quoted 10 lines
Documentation/process/maintainer-netdev.rst +10 -0
+Unless explicitly excluded all bug fixes should be targeting the ``net``
+tree and contain an appropriate Fixes tag.
+
+Obvious exclusions:
+
+ - fixes for bugs which only exist in ``net-next`` should target ``net-next``
+   (please still include the Fixes tag in the commit message)
+ - bugs which cannot be reached, e.g. in code paths not executed given
+   current in-tree callers
+ - fixes for compiler warnings and typos  

If you decide to resubmit this patch, could you please remove "fixes for compiler warnings" from the exclusion list?

Quoted 7 lines
Quoted 3 lines

It is quite frustrating to receive a compiler warning originating from a different subsystem after the merge window, knowing it will not be addressed until the next merge window (around eight weeks later).

Agreed, FWIW, but not planning to resubmit.
I think people misunderstood that I'm __documenting what I already do__ rather than trying to have a discussion :/

I'm pretty sure that people aren't aware of it.

Thanks